siteSub went missing due to zebra transition
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Izno
	Apr 29 2023, 4:09 PM

Description

I've hacked around this in Vector-2022.css ( https://en.wikipedia.org/wiki/MediaWiki:Vector-2022.css ), but, here's the form letter filled in...

Steps to replicate the issue (include links if applicable):

Load a page on English Wikipedia while logged out (e.g. https://en.wikipedia.org/wiki/World_of_Warcraft )

What happens?:

What should have happened instead?:

Software version: 1.41.0-wmf.6 (ccab434) 14:09, 24 April 2023

Other information: Reported at https://en.wikipedia.org/wiki/WP:VPT#Extra_line_break_and_missing_line_break_at_the_top_of_articles

I'm pretty sure this is because #siteSub { display: none } got wrapped into a class selector (.vector-feature-zebra-design-disabled) that isn't needed for #siteSub, regardless of whether Vector 22 is Zebrad or not.

TODO

Fix bug
Add Pixel regression test so this doesn't happen again

QA steps

The text "From Wikipedia, the free encyclopedia" should show on https://en.wikipedia.beta.wmflabs.org/wiki/Spain

QA Results - Beta

AC	Status	Details
1	✅	T335625#8817540

Details

	Subject	Repo	Branch	Lines +/-
	[Regression] Move #siteSub display rule into common.less	mediawiki/skins/Vector	master	+7 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG REPORT	ovasileva	T335155 [Follow-up] Zebra update design review & adjustments
		Resolved	BUG REPORT	ovasileva	T335625 siteSub went missing due to zebra transition

Event Timeline

Izno created this task.Apr 29 2023, 4:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2023, 4:09 PM

Izno mentioned this in T281974: Fix alignment of coordinates and page indicators (Vector 2022).Apr 29 2023, 4:13 PM

Izno added a project: Desktop Improvements (Vector 2022).Apr 29 2023, 7:54 PM

Sj awarded a token.Apr 30 2023, 2:41 AM

Jonesey95 subscribed.Apr 30 2023, 3:04 AM

Jdlrobson added a project: Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2).May 1 2023, 3:54 PM

Jdlrobson updated the task description. (Show Details)

ovasileva triaged this task as Unbreak Now! priority.May 1 2023, 3:59 PM

Jdlrobson updated the task description. (Show Details)

I deliberately did not include safemode=1 as the reason safemode doesn't show siteSub is because safemode doesn't load MediaWiki:Common.css et al.

Izno updated the task description. (Show Details)May 1 2023, 4:03 PM

Change 913960 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] [Regression] Move #siteSub display rule into common.less

https://gerrit.wikimedia.org/r/913960

gerritbot added a project: Patch-For-Review.May 1 2023, 4:48 PM

Jdlrobson updated the task description. (Show Details)May 1 2023, 5:02 PM

Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.May 1 2023, 5:26 PM

Jdlrobson added a parent task: T335155: [Follow-up] Zebra update design review & adjustments.

Jdlrobson set the point value for this task to 0.

Jdlrobson moved this task from Ready for Development to QA on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.May 1 2023, 5:47 PM

Jdlrobson updated the task description. (Show Details)

Change 913960 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [Regression] Move #siteSub display rule into common.less

https://gerrit.wikimedia.org/r/913960

Maintenance_bot removed a project: Patch-For-Review.May 1 2023, 6:10 PM

This was caught my our UI regression tests, but those presumably went unchecked as part of last week's deployment. I've added an agenda item to our next retrospective.