Page MenuHomePhabricator

"Show IP" button only needs the 'wikipage.content' hook on pages that refresh themselves
Closed, ResolvedPublic



RecentChanges and Watchlist require the IP reveal buttons to be added via the wikipage.content hook, because they can continually update. Other pages don't require this.

Using that hook means scoping the button to the element passed into the hook handler. This means that we can't easily add the button outside of that element, e.g. as needed on Special:Permalink (T331008). Therefore, we should only use the hook where we need to.

Testing notes

Everything should behave as before - so only regression testing is needed.

To explicitly test the live update on Special:RecentChanges:

  • click the play button at the top of the page
  • in another window, make an edit
  • the page should update, and the buttons should show as expected (no duplicates, no absent buttons).

Event Timeline

Change 915820 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Only use the 'wikipage.content' hook on RecentChanges and Watchlist

Change 915820 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Only use the 'wikipage.content' hook on RecentChanges and Watchlist

Moving to Done while the QA queue is long. This can be tested via T331008