This should just involve checking if the oldid query parameter has been included in the PageDisplay hook handler.

Change 901222 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/CheckUser@master] Add "Show IP" button next to temporary account username on Special:Permalink

https://gerrit.wikimedia.org/r/901222

Above patch produces:

(Pasted here for reference on the gerrit patch)

Zoomed in:

Zoomed in after pressing the button:

@Niharika @Prtksxna This is the first example we've come across of showing the button in banners across the top of the page, so I just wanted to check - do we want to show the buttons in general in these banners? If so, we can implement a general solution for all those cases. If not, then maybe we wouldn't want the button here after all?

Another example would be the block banner for a blocked temporary user, e.g.:

The usage of the yellow rectangle on the permalink page doesn't seem like a banner or notice (semantically). It seems like UI information that happens to be in a yellow box. I see what you're saying about figuring out what we should do about banners, I've created a different T333115: IP Masking: Should we show the "Show IP" button on banners for this.

Since the unregistered user's name is showing in context of a particular revision I think it makes sense to have the button and show the IP that was used to make this particular edit.

Hey @Tchanders sorry about the confusion. I mean to say that this yellow rectangle is NOT banner, at least not semantically. I think we should show the "Show IP" button here and reveal the particular IP that made the edit.

I made the other task for a place to discuss actual banners, like the one you shared for a blocked temp user.

Thanks @Prtksxna, I think I understood what you meant - it's just that the technical solution would be different depending on that answer.

Given the number of pages affected we're trying not to make custom fixes per page. If the decision was to allow it for all banners, we'd be able to make one change that would enable it on all banners (including Special:Permalink, where the yellow box occupies the same space as a banner, technically speaking). If we only wanted it on Special:Permalink we'd need to implement something custom for this page, which we should avoid unless we have to.

Following comments on T333115, we'll enable the Show IP button for banners in general - thanks everyone.

Change 915825 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Display IP reveal button in Special:Permalink

https://gerrit.wikimedia.org/r/915825

Change 901222 abandoned by Tchanders:

[mediawiki/extensions/CheckUser@master] Add "Show IP" button next to temporary account username on Special:Permalink

Reason:

Replaced by Ie3305e3e788d58b2d304d983303670934505d93b

https://gerrit.wikimedia.org/r/901222

Change 915825 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Display IP reveal button in Special:Permalink

https://gerrit.wikimedia.org/r/915825

@Tchanders When you hover or left-click and hold the button on Show IP, it crosses over other texts as seen in the screenshot below.

OS: macOS 13.3
Browsers: Chrome 112, Firefox 112, Safari 16.4
Skins: Vector 2022, 2010, Monobook, Minerva, Timeless
Environment: Local

Special:PermaLink: Id: 73

@GMikesell-WMF Thanks. I think this is acceptable. We wouldn't want to change the line height to fix it

In T331008#8838099, @Tchanders wrote:

@GMikesell-WMF Thanks. I think this is acceptable. We wouldn't want to change the line height to fix it

Does it not prevent clicking on the links on the line below? Haven't tested this myself but if it does prevent clicking on the links where the button covers the links, it would be best if the browser is told to click on the link instead of the button.

Change 918574 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Fix styling for IP reveal button in subtitle

https://gerrit.wikimedia.org/r/918574

In T331008#8838604, @Dreamy_Jazz wrote:

In T331008#8838099, @Tchanders wrote:

@GMikesell-WMF Thanks. I think this is acceptable. We wouldn't want to change the line height to fix it

Does it not prevent clicking on the links on the line below? Haven't tested this myself but if it does prevent clicking on the links where the button covers the links, it would be best if the browser is told to click on the link instead of the button.

Sorry you're right - I thought the highlight was extending beyond the button. New patch should fix it.

Change 918574 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Fix styling for IP reveal button in subtitle

https://gerrit.wikimedia.org/r/918574

@Tchanders So it looks like both Vector skins are fine. In Monobook, the highlighted box is crossing over. In Timeless, it's slightly uneven. In Minerva, it doesn't even have the Show IP at all in Special:Permalink

Mediawiki: 1.41.0-alpha (e1c1632)
CheckUser: 2.5 (5a25d76)
Vector Skin: (d487e62)
Minerva: (8730c21)
Monobook: (fa35078)
Timeless: (70b587f)

Skin	Result
Vector 2022
Vector 2010
Monobook
Timeless
Minerva

@GMikesell-WMF Thanks for finding these!

Would it be possible to raise separate tasks for Monobook, Minerva and Timeless? They shouldn't be subtasks of this as I think they shouldn't block IP Masking, and they can go on the AHT backlog (so tag them with anti-harassment, but not the current sprint). Thank you!

@Tchanders Ok I created T336787: Minerva, Monobook and Timeless "Show IP" button should appear correctly next to temporary account username on Special:Permalink just like the Vector Skin to the AHT backlog. Otherwise, I did not come across anything else so I will move this to Done. Thanks again!