Special:MergeHistory: No border to the textboxes or buttons when using the Minerva Skin
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	GMikesell-WMF
	May 11 2023, 5:23 PM

Description

Steps to replicate the issue (include links if applicable):

Go to preferences and switch to the Minerva skin
Go to the Special:MergeHistory page

What happens?:
Text box lines for Source Page, Destination Page names, and Show Mergeable Edits are missing the text box outlines

What should have happened instead?:
Text box lines should appear for Source Page, Destination Page names, and Show Mergeable Edits, just like the other skins

Other information (browser name/version, screenshots, etc.):

Minerva- Missing text box outlines (ignore the arrows in the History section, just talking about the text box above)

T330964_IPMasking_ShowIP_NotItalicised_MinervaHistory.png (758×1 px, 155 KB)

Vector sample Having text box outlines (ignore the arrows in the History section, just talking about the text box above)

Details

	Subject	Repo	Branch	Lines +/-
	Use HTMLForm and OOUI in Special:MergeHistory	mediawiki/core	master	+128 -98

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	BUG REPORT	Jdlrobson	T336534 Usernames in Special:MergeHistory using MinervaNeue skin are not crossed out when the username is deleted or suppressed
Resolved	BUG REPORT	Dreamy_Jazz	T336531 Special:MergeHistory: No border to the textboxes or buttons when using the Minerva Skin
Resolved		Dreamy_Jazz	T134675 Convert Special:MergeHistory to OOUI

Event Timeline

GMikesell-WMF created this task.May 11 2023, 5:23 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptMay 11 2023, 5:23 PM

GMikesell-WMF updated the task description. (Show Details)May 11 2023, 5:25 PM

GMikesell-WMF added a parent task: T336534: Usernames in Special:MergeHistory using MinervaNeue skin are not crossed out when the username is deleted or suppressed.May 11 2023, 5:38 PM

GMikesell-WMF mentioned this in T330964: "Show IP" button shown in italics when temporary account username is deleted or suppressed.

Converting Special:MergeHistory to use OOUI should address the problem at heart here. That task is T134675.

Dreamy_Jazz added a subtask: T134675: Convert Special:MergeHistory to OOUI.May 11 2023, 5:51 PM

Re-produceable on the English Wikipedia:

Dreamy_Jazz renamed this task from Special:MergeHistory- No text box lines under the Minerva Skin to Special:MergeHistory: No border to the textboxes when using the Minerva Skin.May 11 2023, 5:54 PM

Dreamy_Jazz attached a referenced file: F36992523: image.png. (Show Details)

Dreamy_Jazz added a project: MinervaNeue.

Dreamy_Jazz updated the task description. (Show Details)

minerva has a reset.less which removes the borders of every html tag and that makes it looks like it looks on the screenshot

div, span,
h1, h2, h3, h4, h5, h6, p, blockquote, pre,
a, abbr, acronym, address, big, cite, code,
del, ins, em, img,
small, strike, strong, sub, sup, tt,
b, u, i, center,
dl, dt, dd, ol, ul, li,
fieldset, form, label, legend,
input, button, select,
audio, video {
	margin: 0;
	padding: 0;
	border: 0;
	font: inherit;
	font-size: 100%;
	vertical-align: baseline;
	background: none;
}

There are border lines on OOUI styled input widgets, but that is not the case here (T134675)

Dreamy_Jazz renamed this task from Special:MergeHistory: No border to the textboxes when using the Minerva Skin to Special:MergeHistory: No border to the textboxes or buttons when using the Minerva Skin.May 11 2023, 5:58 PM

Tchanders removed a project: Anti-Harassment (AHaT Sprint 30: Avanton Gold Cone).May 18 2023, 5:08 AM

Change 921334 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Use HTMLForm and OOUI in Special:MergeHistory

https://gerrit.wikimedia.org/r/921334

gerritbot added a project: Patch-For-Review.May 19 2023, 12:43 PM

Jdforrester-WMF closed this task as Resolved.May 20 2023, 7:21 AM

Jdforrester-WMF assigned this task to Dreamy_Jazz.

Jdforrester-WMF closed subtask T134675: Convert Special:MergeHistory to OOUI as Resolved.

Change 921334 merged by jenkins-bot:

[mediawiki/core@master] Use HTMLForm and OOUI in Special:MergeHistory

https://gerrit.wikimedia.org/r/921334

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 20 2023, 8:00 AM

Maintenance_bot removed a project: Patch-For-Review.May 20 2023, 8:10 AM

	F36990126: T330964_IPMasking_ShowIP_NotItalicised_DeleteMerge.png
	May 11 2023, 5:23 PM

	F36990151: T330964_IPMasking_ShowIP_NotItalicised_MinervaHistory.png
	May 11 2023, 5:23 PM

Special:MergeHistory: No border to the textboxes or buttons when using the Minerva SkinClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related ObjectsSearch...

Event Timeline

Special:MergeHistory: No border to the textboxes or buttons when using the Minerva Skin
Closed, ResolvedPublicBUG REPORT
Actions

Related Objects
Search...