Page MenuHomePhabricator

Improve large table lint handling of nested tables and tables with image tags
Open, MediumPublic5 Estimated Story Points

Description

The large table lint throws up some false positives so needs some fine tuning before it can become practical. Thanks to @Jonesey95 for flagging these!

TODO

Event Timeline

Jdlrobson renamed this task from Improve large table lint to Improve large table lint handling of nested tables and tables with image tags.May 15 2023, 2:44 PM
Jdlrobson triaged this task as High priority.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Jonesey95.

Not sure I agree with

some large tables often contain images and are not problematic.

While a page like NRHP listings in Providence, RI would continue to count in the listings, that's only incidental to the fact the images aren't in the first column. That seems like a page that could very easily be a few more columns wide (the location and date listed columns particularly) and so should not be ignored by this lint. I anticipate there are many others with an image in the first column that are exactly this kind of list.

Tables inside tables

These are an antipattern anyway, but the complaint in the context of this request seems reasonable to correct.

ssastry subscribed.

Changed project tags to reflect that the change will be in Parsoid, not the Linter extension which provides the lint database and API and UI for accessing those lints ...the lint generation exists elsewhere, currently only in Parsoid.

I don't see how having an image in the first column, or not, is relevant to the width of a table. If this test is going to work, it needs to test for the actual conditions that make a table too wide for mobile or for a reasonable width of a content column in the most prevalent skins.

Jdlrobson added a subscriber: Mabualruz.

According to @Mabualruz the code on English Wikipedia is outdated so moving this task until later.

This Linter tracking should be disabled and refined via queries and reports until the actual problem conditions and criteria are understood.

Jdlrobson lowered the priority of this task from High to Medium.May 25 2023, 6:52 PM

Change 928674 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/services/parsoid@master] WIP Large tables lint test for nested tables

https://gerrit.wikimedia.org/r/928674

LGoto set the point value for this task to 5.Jul 13 2023, 5:52 PM

Change 928674 abandoned by Sbailey:

[mediawiki/services/parsoid@master] WIP Large tables lint test for nested tables

Reason:

Code used in another patch

https://gerrit.wikimedia.org/r/928674

Can you please turn off this linter condition while it this task is stalled and on the backlog? The false positives for this linter condition result in a lot of noise on quarry reports that ask for pages with any linter condition on them.

Jdlrobson added a subscriber: ovasileva.

@ovasileva I do think we should plan to revive this effort next quarter. It is frequently coming up in community discussions and bug reports and something we need to improve. I think off the back of the night mode autocorrection we have a better idea of how this sort of thing should work.