Page MenuHomePhabricator
Create Task
Maniphest T339228

Remove VRS code from ContentTranslation
Closed, ResolvedPublic
Actions

Description

Once we have ContentTranslation call parsoid directly in PHP in WMF production, we can remove the VRS code for calling parsoid in RESTbase.

NOTE: Add to release notes: The parties that rely on ContentTranslation and have a large number of big pages should run a script to pre-warm the parser cache when updating. See T338922: Introduce maintenance script for warming cache with Parsoid Outputs

Details

SubjectRepoBranchLines +/-
Remove more unused VirtualRestService code from CXmediawiki/extensions/ContentTranslationmaster+0 -322
Remove VRS related code from CXmediawiki/extensions/ContentTranslationmaster+6 -261
Customize query in gerrit

Related Objects
Search...

Event Timeline

daniel created this task.Jun 15 2023, 11:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 15 2023, 11:53 AM
daniel added a parent task: T179680: Hard deprecate VirtualRESTService.Jun 15 2023, 11:53 AM
daniel added a subtask: T339227: Remove VRS code from VisualEditor.
daniel added a parent task: T328559: Replace usage of RESTbase parsoid endpoints.
daniel edited subtasks, added: T338922: Introduce maintenance script for warming cache with Parsoid Outputs; removed: T339227: Remove VRS code from VisualEditor.Jun 15 2023, 11:56 AM
Nikerabbit updated the task description. (Show Details)Jun 16 2023, 12:07 PM

I am not sure which parties do you mean. There are no users of CX outside WMF to our knowledge.

gerritbot added a comment.Jun 16 2023, 1:07 PM

Change 930794 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/ContentTranslation@master] Remove VRS related code from CX

https://gerrit.wikimedia.org/r/930794

gerritbot added a project: Patch-For-Review.Jun 16 2023, 1:07 PM
DAlangi_WMF changed the task status from Open to In Progress.Jun 17 2023, 7:19 PM
DAlangi_WMF claimed this task.
DAlangi_WMF triaged this task as Medium priority.
DAlangi_WMF changed the status of subtask T338922: Introduce maintenance script for warming cache with Parsoid Outputs from Open to In Progress.
KartikMistry mentioned this in T323667: Use Parsoid in Mediawiki Core for Content Translation.Jun 19 2023, 7:15 AM
Nikerabbit added a project: Language-Team (Language-2023-April-June).Jun 19 2023, 11:28 AM
Nikerabbit moved this task from Quarter Backlog to In Review on the Language-Team (Language-2023-April-June) board.
Nikerabbit moved this task from Needs Triage to Enhancements on the ContentTranslation board.Jun 19 2023, 11:36 AM
gerritbot added a comment.Jun 28 2023, 4:29 AM

Change 930794 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Remove VRS related code from CX

https://gerrit.wikimedia.org/r/930794

Maintenance_bot removed a project: Patch-For-Review.Jun 28 2023, 4:30 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jun 28 2023, 5:00 AM
DAlangi_WMF closed subtask T338922: Introduce maintenance script for warming cache with Parsoid Outputs as Resolved.Jun 28 2023, 12:48 PM
Pginer-WMF edited projects, added Language-Team (Language-2023-July-September); removed Language-Team (Language-2023-April-June).Jun 30 2023, 11:45 AM
Pginer-WMF moved this task from Quarter Backlog to In Review on the Language-Team (Language-2023-July-September) board.
DAlangi_WMF closed this task as Resolved.Jul 1 2023, 6:11 PM

Patch was merged a while ago. Reopen if anything related to this comes up.

Nikerabbit reopened this task as Open.Jul 2 2023, 7:40 PM
Nikerabbit moved this task from In Review to Check after deployment on the Language-Team (Language-2023-July-September) board.

Please don't close tasks on our sprint board. There is a process we follow.

DAlangi_WMF added a comment.Jul 3 2023, 7:39 AM
In T339228#8984158, @Nikerabbit wrote:

Please don't close tasks on our sprint board. There is a process we follow.

Okay @Nikerabbit, sorry about that. I was unaware of the process. Noted with thanks!

gerritbot added a comment.Jul 12 2023, 8:23 AM

Change 937436 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/ContentTranslation@master] Remove more unused VirtualRestService code from CX

https://gerrit.wikimedia.org/r/937436

gerritbot added a project: Patch-For-Review.Jul 12 2023, 8:23 AM
gerritbot added a comment.Jul 13 2023, 9:41 AM

Change 937436 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Remove more unused VirtualRestService code from CX

https://gerrit.wikimedia.org/r/937436

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.18; 2023-07-18); removed MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jul 13 2023, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 13 2023, 10:11 AM
Nikerabbit moved this task from Check after deployment to Needs QA on the Language-Team (Language-2023-July-September) board.Aug 3 2023, 10:19 AM
MSantos moved this task from Unsorted to Radar on the RESTBase Sunsetting board.Aug 18 2023, 3:29 PM
Nikerabbit closed this task as Resolved.Aug 24 2023, 2:43 PM
Nikerabbit moved this task from Needs QA to Done on the Language-Team (Language-2023-July-September) board.

Closing as per T339322: Use Parsoid in all Wikis for Content Translation. No issues have been reported during the months this change has been live.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL