IP masking: Advanced mode and user preferences does not work for IP masked users on mobile so shouldn't be shown
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 21 2023, 12:09 AM

Description

Flagged by @Edtadros in T339380#8951475
Confirmed by @RHo that these links should be removed.

Screen Recording 2023-06-20 at 4.47.06 PM.mov.gif (922×1 px, 531 KB)

QA Results - Beta

AC	Status	Details
1	✅	T339994#9011235
2	✅	T339994#9011235

Details

	Subject	Repo	Branch	Lines +/-
	Remove AMC and Mobile user preferences for temporary users	mediawiki/extensions/MobileFrontend	master	+4 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T335440 [EPIC] Web team support for IP masking
		Resolved	BUG REPORT	ovasileva	T339994 IP masking: Advanced mode and user preferences does not work for IP masked users on mobile so shouldn't be shown

Event Timeline

Jdlrobson created this task.Jun 21 2023, 12:09 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 21 2023, 12:09 AM

Jdlrobson mentioned this in T339380: QA IP masking feature in Web team products.Jun 21 2023, 12:35 AM

@RHo I assume these should both be hidden for IP masked users?

Jdlrobson renamed this task from Advanced mode and user preferences does not work for IP masked users on mobile so shouldn't be shown to IP masking: Advanced mode and user preferences does not work for IP masked users on mobile so shouldn't be shown.Jun 22 2023, 6:15 PM

Jdlrobson triaged this task as High priority.

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1); removed Web-Team-Backlog.

Jdlrobson updated the task description. (Show Details)

In T339994#8956759, @Jdlrobson wrote:

@RHo I assume these should both be hidden for IP masked users?

Yes, this should look like a logged out user, so only the font size one should be available.

Jdlrobson removed Jdlrobson as the assignee of this task.Jun 23 2023, 7:16 PM

LGoto set the point value for this task to 2.Jun 29 2023, 5:25 PM

LGoto moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.Jun 29 2023, 5:44 PM

ovasileva added a parent task: T335440: [EPIC] Web team support for IP masking.Jul 10 2023, 3:22 PM

bwang claimed this task.Jul 11 2023, 4:11 PM

bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.

bwang removed bwang as the assignee of this task.Jul 11 2023, 7:46 PM

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.

bwang subscribed.

Change 937501 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/MobileFrontend@master] Remove AMC and Mobile user preferences for temporary users

https://gerrit.wikimedia.org/r/937501

gerritbot added a project: Patch-For-Review.Jul 12 2023, 3:34 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.Jul 12 2023, 11:53 PM

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/b2f3ebc003/w

Change 937501 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Remove AMC and Mobile user preferences for temporary users

https://gerrit.wikimedia.org/r/937501

Maintenance_bot removed a project: Patch-For-Review.Jul 13 2023, 12:10 AM

Jdlrobson assigned this task to Edtadros.Jul 13 2023, 12:21 AM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 13 2023, 1:00 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Advanced mode does not work for IP masked users on mobile so shouldn't be shown
✅ AC2: User preferences does not work for IP masked users on mobile so shouldn't be shown

Screenshot 2023-07-12 at 6.33.32 PM.png (589×1 px, 60 KB)

Edtadros updated the task description. (Show Details)Jul 13 2023, 1:45 AM

Mabualruz assigned this task to olga.Jul 13 2023, 4:37 PM

Mabualruz reassigned this task from olga to ovasileva.Jul 13 2023, 4:41 PM

Mabualruz added a subscriber: olga.

Looks good - moving to QA in prod.

RHo attached a referenced file: F37110690: Screen Recording 2023-06-20 at 4.47.06 PM.mov.gif. (Show Details)Jul 14 2023, 6:51 PM

Resolving. Will test in prod when IP masking is available as a whole

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/b2f3ebc003/w/~~

	F37137524: Screenshot 2023-07-12 at 6.33.32 PM.png
	Jul 13 2023, 1:43 AM

	F37110690: Screen Recording 2023-06-20 at 4.47.06 PM.mov.gif
	Jun 21 2023, 12:09 AM

IP masking: Advanced mode and user preferences does not work for IP masked users on mobile so shouldn't be shownClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions