Page MenuHomePhabricator
Create Task
Maniphest T340046

Targets system gives deprecation warnings for gadget modules
Closed, ResolvedPublic
Actions

Description

1 Use of Modules must target desktop and mobile. Module name:ext.gadget.background was deprecated
1 Use of Modules must target desktop and mobile. Module name:ext.gadget.bidibuttons was deprecated
1 Use of Modules must target desktop and mobile. Module name:ext.gadget.HoverPopTools was deprecated
1 Use of Modules must target desktop and mobile. Module name:ext.gadget.new-messages was deprecated
1 Use of Modules must target desktop and mobile. Module name:ext.gadget.prota was deprecated
1 Use of Modules must target desktop and mobile. Module name:ext.gadget.speedy was deprecated
1 Use of Modules must target desktop and mobile. Module name:ext.gadget.terminology was deprecated
1 Use of Modules must target desktop and mobile. Module name:ext.gadget.UTCLiveClock was deprecated

These seem to come from rMWbe122d4f2ad4: Deprecate use of targets and is unexpected, given our gadgets do not specify targets.

Details

SubjectRepoBranchLines +/-
Gadgets should default to mobile and desktop targetsmediawiki/extensions/Gadgetsmaster+3 -3
Change default RL target to desktop+mobilemediawiki/extensions/Gadgetsmaster+5 -3
Customize query in gerrit

Related Objects

Event Timeline

Nikerabbit created this task.Jun 21 2023, 3:25 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptJun 21 2023, 3:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Catrope subscribed.Jun 21 2023, 3:27 PM

This happens because Gadget.php sets the default target for a gadget to [ 'desktop' ] (code), which is now deprecated. This default should be changed to [ 'desktop', 'mobile' ], and we should probably remove the option to set the target from the Gadgets extension entirely in the future.

Catrope added a subscriber: Jdlrobson.Jun 21 2023, 3:28 PM
gerritbot added a comment.Jun 21 2023, 3:30 PM

Change 931954 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/Gadgets@master] Change default RL target to desktop+mobile

https://gerrit.wikimedia.org/r/931954

gerritbot added a project: Patch-For-Review.Jun 21 2023, 3:30 PM
Reedy renamed this task from Targets system gives seprecation warnings for gadget modules to Targets system gives deprecation warnings for gadget modules.Jun 21 2023, 3:34 PM
gerritbot added a comment.Jun 21 2023, 3:36 PM

Change 931955 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Gadgets@master] Gadgets should default to mobile and desktop targets

https://gerrit.wikimedia.org/r/931955

gerritbot added a comment.Jun 21 2023, 3:39 PM

Change 931954 abandoned by Jforrester:

[mediawiki/extensions/Gadgets@master] Change default RL target to desktop+mobile

Reason:

Jon's patch is being merged instead.

https://gerrit.wikimedia.org/r/931954

gerritbot added a comment.Jun 21 2023, 4:00 PM

Change 931955 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Gadgets should default to mobile and desktop targets

https://gerrit.wikimedia.org/r/931955

Maintenance_bot removed a project: Patch-For-Review.Jun 21 2023, 4:10 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 21 2023, 5:00 PM
Novem_Linguae subscribed.Jun 21 2023, 7:02 PM
Jdlrobson mentioned this in T127268: Dismantle ResourceLoader's "targets" system.Jun 22 2023, 3:39 PM
Jdlrobson merged a task: T340682: Large set of Gadgets "PHP Deprecated: Use of Modules must target desktop and mobile." after deployment of 1.41.0-wmf.15 to group1.Jun 28 2023, 8:39 PM
Jdlrobson added subscribers: brennen, Nux.
Jdlrobson merged a task: T340565: PHP Deprecated: Use of Modules must target desktop and mobile. Module name:ext.gadget.mobileonlygadget was deprecated in MediaWiki 1.41..Jun 29 2023, 9:54 PM
Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Performance-Team, MediaWiki-ResourceLoader.
Jdlrobson closed this task as Resolved.Jun 29 2023, 10:29 PM
Jdlrobson claimed this task.
Jdlrobson added a subscriber: Tacsipacsi.

I've gone through https://global-search.toolforge.org/?q=targets%5C%3D%28mobile%7Cdesktop%29%5B%5E%2C%5D&regex=1&namespaces=8&title=Gadgets-definition and this should now be fully addressed.

The only remaining wiki is huwiki and @Tacsipacsi has stated they'd prefer to do that at their own pace.
I'll be monitoring the URL above over next few weeks to see if any gadgets do get switched to targeting to get a better understanding of the circumstances in which that arises.

Snaevar subscribed.Jun 30 2023, 5:16 AM

Might want to send a message to Arjunaraoc user talk page at https://te.wikisource.org/wiki/%E0%B0%B5%E0%B0%BE%E0%B0%A1%E0%B1%81%E0%B0%95%E0%B0%B0%E0%B0%BF_%E0%B0%9A%E0%B0%B0%E0%B1%8D%E0%B0%9A:Arjunaraoc since he is the only interface admin on that project and that te.wikisource was mentioned in T340682

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL