Page MenuHomePhabricator

[minor] Main menu displays "In other languages" widget link
Open, LowPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • On any wikifunctions page, e.g. https://www.wikifunctions.org/wiki/Z8012, click on the main menu - the drop-down options will display "In other languaages" link.
  • Click on a gear button - the popup will be displayed
Screen Shot 2023-07-27 at 3.38.06 PM.png (692×844 px, 82 KB)
Screen Shot 2023-07-27 at 3.53.00 PM.png (1×2 px, 260 KB)

What happens?:
Couple of minor issues

  • the language widget link was moved to the article top menu tools. Should wikifunctions also make adjustmenets?

Screen Shot 2023-07-27 at 3.38.48 PM.png (996×578 px, 113 KB)

  • the gear icon is displayed too close to the edge of the drop down menu
  • "Add links" (a link to wikidata) is displayed in a bigger font

Event Timeline

Etonkovidova renamed this task from [minor] Main menu displays "In other languaages" widget link to [minor] Main menu displays "In other languages" widget link .Jul 27 2023, 11:08 PM

I've temporarily hidden #p-lang entirely via https://www.wikifunctions.org/wiki/MediaWiki:Common.css but we should fix this properly.

A few thoughts on this:
1: This should probably be fixed in MediaWiki:Vector-2022.css not common.css. An idea for a fix:

i: To fix cog wheel: #vector-main-menu-unpinned-container #p-lang button { margin: 6px 14px; }
ii: To fix link: #vector-main-menu-unpinned-container #p-lang .vector-menu-content a { padding: 6px 14px; font-size:0.875rem; }

2: I personally prefer the lang links in v22 to be at the top of the page rather than in the main menu.
3: This is fixed in V22 the vectorzebradesign update. See https://www.wikifunctions.org/wiki/Wikifunctions:Functioneers?safemode=1&vectorzebradesign=1. So there should not be any longterm css fixes needed.

I've temporarily hidden #p-lang entirely via https://www.wikifunctions.org/wiki/MediaWiki:Common.css but we should fix this properly.

This has removed the ability to change the interface language and the ability to add Wikidata links in Vector and Monobook.

A few thoughts on this:
1: This should probably be fixed in MediaWiki:Vector-2022.css not common.css. An idea for a fix:

i: To fix cog wheel: #vector-main-menu-unpinned-container #p-lang button { margin: 6px 14px; }
ii: To fix link: #vector-main-menu-unpinned-container #p-lang .vector-menu-content a { padding: 6px 14px; font-size:0.875rem; }

No, it should be fixed in Vector22/ULS. A temporary on-wiki hack is not the answer.

2: I personally prefer the lang links in v22 to be at the top of the page rather than in the main menu.

Those are entirely different controls.

3: This is fixed in V22 the vectorzebradesign update. See https://www.wikifunctions.org/wiki/Wikifunctions:Functioneers?safemode=1&vectorzebradesign=1. So there should not be any longterm css fixes needed.

Aha, neat. Let's use that then.

I've temporarily hidden #p-lang entirely via https://www.wikifunctions.org/wiki/MediaWiki:Common.css but we should fix this properly.

This has removed the ability to change the interface language and the ability to add Wikidata links in Vector and Monobook.

There's no real use-case for adding Wikidata links for 99% of pages on Wikifunctions. The language change control from ULS isn't supported and doesn't work correctly, but we can't configure it unfortunately; you should use the real language change control that we provide instead.

Ah I see, I misunderstood when I made my 2nd comment. However for my first point I think that while #p-lang is being hidden, it should only be hidden for V22 instead of all skins since the formatting issue is limited to that skin until the V22 update (Comment 3) is released, which could be in 1-2 weeks according to the update notes. If this was more about disabling the menu language feature (Not the WF one) entirely then I think that could be quite good but it didn't seem to me that this task was about that.

There's no real use-case for adding Wikidata links for 99% of pages on Wikifunctions. The language change control from ULS isn't supported and doesn't work correctly, but we can't configure it unfortunately; you should use the real language change control that we provide instead.

Where do I find that?

Also, what doesn't work correctly? If I manually remove the CSS you added, changing the language with ULS works fine for me.

As for adding Wikidata links, maybe it's not important for the main namespace, but there's no reason to prevent people from linking categories and templates (which is what I was trying to do).

This is probably present in pretty much every wiki with V22 except Wikipedia, at least MediaWiki also has it. Is the languages dropdown in Vector 2022's code or just a hack for all Wikipedia wikis?

Update: V22 just added the Zebra changes to all users and the alignment issues with the cog and text should be fixed.

Considering the fact that there is no other option for language switching for users who don't use Vector-2022, I have changed it so that uls is visible again to users who don't use vector-2022

Should this also be done for MediaWikiWiki?

Also, does that languages sidebar even apply to Wikifunctions? See https://www.wikifunctions.org/view/en/Z10012?useskin=monobook . Languages seem to be always inside the page content, never in the sidebar.