PR: https://github.com/wikimedia/wikipedia-ios/pull/4629

@scblr Form UI is in TestFlight Experimental build #42. Please design review this form UI. Banner and Apple Pay action sheet choice is not in place yet. The flow after tapping the Apple Pay button is not in place yet either.

Test steps:

1. On fresh install, force load announcements. Do this by backgrounding once, then pulling to refresh on the Explore feed. This populates the configs we need to display the form.
2. Go to Settings > Donate. Design review across multiple themes and dynamic type sizes. Also please check minimum amount error handling.
3. It may be helpful to look at the config, to see what to expect for each currency code and/or country code. The email opt-in only appears for certain countries, and different default amounts and transaction fees appear for different currencies. You can change your currency and country code by adjusting iOS Settings > Language and Region, change region and language.

Thanks @Tsevener – you themed it perfectly! 👏 Here’s some feedback:

1) Change copy to Donate to Wikipedia.

2) Remove the external link icon.

3) Done button is too large.

4) After selecting an amount, it’s possible to delete the entire input field (including the currency). Only the amount should be selectable/deletable.

5) Make sure to reset all input field contents and set them to the above (button) values. Here’s a video that shows that some values from the previous selection are kept.

6) Can we show the PTF (pay the fee) checkbox after users have typed or selected an amount? Here’s an example from the web banner. Otherwise, this situation could happen (no amount selected yet).

Bonus: it has proven to impact a higher average gift if the checkbox is shown after users select an amount.

7) Is there any way to hide the numbers when it’s empty/when users enter the form/flow?

Like this	Not this

The difference is (US example): rather than entering cents, users type in dollars first on their keyboard (higher donations). We can still show the cents (e.g. *.00) once users hit Done.

@scblr I fixed a few of your lighter-weight issues (3 and 5, small change to improve the 6 situation) in the PR, but I will need to come back later to the more difficult ones. I will do the Settings tweaks as a part of a different task (this one is only for the form UI). Unfortunately with the textfield, what I'm using is what SwiftUI gives us out-of-the-box, and I'm finding it difficult to customize. Once we get further along in development, feel free to spin up another task with those improvements.

In T345846#9192580, @Tsevener wrote:

@scblr I fixed a few of your lighter-weight issues (3 and 5, small change to improve the 6 situation) in the PR, but I will need to come back later to the more difficult ones. I will do the Settings tweaks as a part of a different task (this one is only for the form UI). Unfortunately with the textfield, what I'm using is what SwiftUI gives us out-of-the-box, and I'm finding it difficult to customize. Once we get further along in development, feel free to spin up another task with those improvements.

Sounds good, thanks @Tsevener 👍👍👍

@cmadeo Ready for more design review. This has been through one round but we are closer to the end-to-end flow now, so we can try another round. Here are some more involved test steps to trigger the payment sheet:

1. Download TestFlight Experimental build # 7.4.3(45) on a test device.
2. Log out of your usual testing Apple ID in iOS Settings, and instead log into the "iOS Sandbox Tester Apple ID" in 1Password. Do not enable 2 factor when prompted on the security modal (choose Other options), since this is a shared account.
3. Now add a Test card in Apple Wallet. I've had luck with the top Discover one.
4. Change your device region (Settings > General > Language and Region) to the Netherlands to qualify for our faked active campaign.
5. Open the Experimental app. Background, then foreground, then pull to refresh on the Explore feed to trigger campaigns to fetch.
6. Go to Settings. Tapping "Donate to Wikipedia" should now prompt you with an Apple Pay or Other method choice. Tap into the Apple Pay option.
7. Fill out amount and tap the Apple Pay button. Fill out billing address and email in the payment sheet (this can be fake information). Then authorize the payment.
8. Payment should succeed (this is all faked) and you will be popped back to Settings with the thank you toast.

Hi @Tsevener apologies if this are issue is one that should have new task written for it for later based on your comment from Fri, Sep 22.

	I can currently delete the currency in the text box

Additionally I'm still seeing the issue described by Robin above as #6

apologies if this are issue is one that should have new task written for it for later based on your comment from Fri, Sep 22.

@cmadeo thanks for catching that! Yeah, I haven't had time yet to revisit and see how far I can get with a custom textfield...right now this is what I can do with SwiftUI's default currency textfield handling. Please spin up a separate task for this if you don't mind, we can hash out soon if we think it's a blocker or not.

Additionally I'm still seeing the issue described by Robin above as #6

The minor improvement I made for #6 is that now I don't do minimum validation immediately after tapping the transaction fee checkbox, so that this screenshot from his feedback no longer occurs:

Hiding the checkbox would require a heavier lift and might introduce more bugs with this form, so I went with this. Let me know if this is okay, thanks!

@cmadeo Please let me know if this new "Apple is not in charge of raising money for this purpose." fine print looks ok. See https://phabricator.wikimedia.org/T346823#9229993 for background. Thanks!

Design review passed on this screenshot:

Fine print PR: https://github.com/wikimedia/wikipedia-ios/pull/4655

Looks good on 7.4.3 (2811)