@Mazevedo Notes from sync:

ArticleViewController+Announcements.swift has a self.navigate(to: url, useSafari: true) for navigating to Safari when tapping "Donate" on a campaign.
WMFSettingsViewController.m has a similar [self wmf_navigateToURL:[self donationURL] useSafari:YES]; call for the Donate navigation.

Setting that useSafari app to false will hopefully automatically route you to using SingleWebViewController.swift to keep this flow in-app.

Once you get the flow displaying in SingleWebViewController.swift, then you can maybe check the view controller's url property in viewDidAppear. If it equals thankyou.wikipedia.org, display that "Go back" button, which will take you back to the article or Settings root view once tapped.

@cmadeo It is possible for a user to reach this in-app web view from app Settings > Donate. In this case, it feels weird for them to see the "Return to article" button on the thank you page when they didn't come from an article. In this situation should we change the button title to just say "Return" and have it return them to the root Settings view?

@Tsevener updating the text to 'Return' or 'Done' and returning them to their root Settings view (or article) works for me

PR https://github.com/wikimedia/wikipedia-ios/pull/4649

Hi @cmadeo,

I have pushed a build with some design review for what we have on the new Donor Experiences so far.

1. Download TestFlight Experimental build # 7.4.3(45) on a test device.
2. Now, change your device region (Settings > General > Language and Region) to the Netherlands to qualify for our faked active campaign.
3. Open the Experimental app. Background, then foreground, then pull to refresh on the Explore feed to trigger campaigns to fetch.
4. Visit an EN or NL article, then tap "Donate now". It should take you to an in-app web view. I have mucked with this build so that after you tap a payment method, it will send you straight to the thank you page without charging you for testing purposes.
5. Go to Settings. Tapping "Donate to Wikipedia" should send you to the same in-app web view.

Note, this piece isn't in yet. https://phabricator.wikimedia.org/T333108#9221619 Feel free to note it in your feedback notes so we don't lose track of it. Thanks!

Thanks @Tsevener! Here are some things I came across during design review:

• In-put box feels a bit off / unfinished here, would it be possible for there to be an outline stroke in addition to the shadow? Maybe a 1 or .5pt #000 stroke?
• Additionally the arrow in the top left is two different colors. Could we use SF Symbol arrow.backward
• The font is also different than defined in the Mocks, would it be possible to use a serif font like Georgia or New York?

• Same arrow and type issues as above
• In the mocks the options are presented as side-by-side vs. stacked, is this possible?
• If you are partially scrolled down the page when you tap through, the dialog is scrolled down and partially cut-off (see second screenshot above)

• When donating from the setting view I am not seeing the thank you page
• I am only prompted to switch to a monthly donation when I select Paypal

@cmadeo Hmm, sorry, it could be that my hacky workaround to allow you to bypass donating in the web view is not acting well. I'll take a look and see if I can reproduce your issues and improve testing for them.

One thing to keep in mind - this is all Fundraising's web flow embedded in our web view, so we have no control over it. The only thing native we can adjust is the "Return to article" button that appears on the thank you page (which, it sounds like you can't reach, I'll look at that), and the "Thank you" toast that appears after they tap it and pop back to their previous screen. We might be able to improve your scrolling issue too.

@cmadeo There's a new Experimental build (47) with thank you bypass improvements and I schedule-slacked you a screencast of what I'm seeing. I'll move this back into your column in case you have any feedback on the thank you toast and "Return to article" button. Also if you still have trouble seeing the thank you page, let me know. I can repro your navigation bar scrolling bug - we'll try to fix that. Thanks!

Hi @Tsevener! Thanks for the clarifications. Things within the app are looking good, but I am seeing that the thank you page from the settings view is still showing “return to article” can we have it say “return to settings” if accessed from settings or update the string universally to be “Go back”?

PR that changes button to "Return" (from Settings) or "Return to article" (from article campaign) - based on requirements here https://phabricator.wikimedia.org/T333108#9221619.

https://github.com/wikimedia/wikipedia-ios/pull/4652

PR to prevent hiding of the navigation bar - https://github.com/wikimedia/wikipedia-ios/pull/4654

This should improve a bit of the scrolling weirdness in https://phabricator.wikimedia.org/T333108#9229278.

Looking good for me on 7.4.3 (2811)