Following the work in T350195 and T350436, we should update Vector to use the new theme icon.
| Before | After |
 |  |
QA Results - Beta
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T351142#9372363 |
QA Results - Prod
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T351142#9381771 |
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Update theme icon for client preferences in user links | mediawiki/skins/Vector | master | +14 -3 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Jdrewniak | T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations | |||
| Open | Jdrewniak | T313828 [EPIC] Typography: improve typography and allow for variable typography settings | |||
| Duplicate | Florian | T50946 Add font size adjustment feature | |||
| Duplicate | Jdlrobson | T91201 [GOAL] Accessibility settings/preferences on desktop and mobile | |||
| Duplicate | Jdlrobson | T345359 [Goal] Allow logged-out and logged-in users to set preferred typography | |||
| Resolved | ovasileva | T351142 Update theme icon for client preferences in user links | |||
| Resolved | DTorsani-WMF | T350436 Reading theme icon: Add reading theme icon to Codex and OOUI | |||
| Resolved | ovasileva | T352642 Use Codex icon for theme |
Event Timeline
Comment Actions
@Mabualruz T350436 should be considered part of the task. There is no Codex release this week but there should be one next week. So either we get the icon released in Codex or we provide a temporary solution in Vector 2022 until the Codex release. Either way we need an icon in Vector 2022 before releasing to beta next week. Can you reach out to DTorsani-WMF and Justin to get a sense on the timeline and make sure they are aware of the urgency?
Comment Actions
Thanks @Catrope, @DTorsani-WMF, and @JScherer-WMF for unblocking this.
https://gerrit.wikimedia.org/r/c/design/codex/+/976834/ this patch was supplied and it includes the svg file that will allow us to showcase the design as intended on beta. this will be our 1st patch with the svg
We need to have a 2nd patch with the proper mixin that we merge once https://gerrit.wikimedia.org/r/c/design/codex/+/976834/ reaches the release.
Comment Actions
@Mabualruz feels free to use a hardcoded SVG for the time being (https://gerrit.wikimedia.org/g/mediawiki/core/+/3bded6596a8b3ddceaec5c4c9d502f5a88c8fee1/resources/lib/codex-icons/codex-icon-paths.less#1). it would be good to check the SVG out before it ends up in Codex.
e.g. Patch 1 to Vector: switch to inlined SVG matching https://gerrit.wikimedia.org/r/c/design/codex/+/976834/3/packages/codex-icons/src/images/appearance.svg
Patch 2: Replace variable with upstream Codex variable (blocked on Codex release)
Comment Actions
Change 976950 had a related patch set uploaded (by Mabualruz; author: Mabualruz):
[mediawiki/skins/Vector@master] Update theme icon for client preferences in user links
Comment Actions
Change 976950 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Update theme icon for client preferences in user links
Comment Actions
@Jdlrobson, Is this ready in beta? the icon still looks like the old neato eye glasses:
