Page MenuHomePhabricator
Create Task
Maniphest T351394

Places: Add ‘View on map’ to customizable article toolbar
Closed, ResolvedPublic
Actions

Assigned To
cooltey
Authored By
scblr
Nov 16 2023, 12:47 PM
Tags
Referenced Files
F41566042: Screenshot_20231206-122913.png
Dec 6 2023, 11:34 AM
F41565971: Screenshot_20231206-121327 copy.png
Dec 6 2023, 11:34 AM
F41551547: Screenshot_20231201-102612_Wikipedia Dev.jpg
Dec 1 2023, 6:36 PM
F41551545: Screenshot_20231130-142337_Wikipedia Dev.jpg
Dec 1 2023, 6:36 PM
F41551546: Screenshot_20231130-142353_Wikipedia Dev.jpg
Dec 1 2023, 6:36 PM
F41524954: image.png
Nov 23 2023, 11:47 AM
F41524952: image.png
Nov 23 2023, 11:47 AM
F41524950: image.png
Nov 23 2023, 11:47 AM
View All 10 Files
Subscribers
ABorbaWMF
Aklapper
scblr

Description

Design (Figma)
1. Default menu
image.png (1×720 px, 348 KB)
2. Disabled state
image.png (1×720 px, 347 KB)
3. Customization
image.png (1×720 px, 66 KB)
  • Add 'View on map' below 'Edit history'
  • When the article does not contain a location, use the inactive color group for both icon and label (disabled state, see 2)
  • When users tap the 'View on map' link and it is disabled, show a default tooltip that says: Geographical coordinates are not available for this page
  • Make sure to add 'View on map' to the 'Customize toolbar' screen

APK: https://github.com/wikimedia/apps-android-wikipedia/pull/4308

Related Objects
Search...

Event Timeline

scblr created this task.Nov 16 2023, 12:47 PM
scblr updated the task description. (Show Details)Nov 16 2023, 1:46 PM
scblr mentioned this in T351397: Places: Build search tab functionalities and Filter screen on map view.Nov 16 2023, 2:28 PM
scblr updated the task description. (Show Details)Nov 16 2023, 2:43 PM
Sharvaniharan renamed this task from Add ‘View on map’ to customizable article toolbar to Nearby: Add ‘View on map’ to customizable article toolbar.Nov 20 2023, 6:52 PM
Sharvaniharan triaged this task as Medium priority.
Sharvaniharan moved this task from Epics in Progress to Ready for dev on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.
scblr updated the task description. (Show Details)Nov 23 2023, 11:47 AM
scblr updated the task description. (Show Details)Nov 23 2023, 1:12 PM
cooltey claimed this task.Nov 29 2023, 8:05 PM
cooltey moved this task from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.
cooltey moved this task from Doing to Design signoff on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.Dec 1 2023, 6:36 PM

Hi @scblr,

The implementation is completed, please download the APK to see the change.

Just want to let you know that in the customizable toolbar, if the user has already customized the order, the newly added "View on map" will show on the last position of the overflow menu.

But if the user has never updated it before (the preference will be empty), the default position will be below the "Edit history"

Screenshot_20231130-142353_Wikipedia Dev.jpg (2×1 px, 120 KB)
Screenshot_20231130-142337_Wikipedia Dev.jpg (2×1 px, 112 KB)
DefaultCustomized in an older version

Do we need to update the "View on map" behavior in the footer? The current behavior is that it will open it in your system map app like Google Maps.

Screenshot_20231201-102612_Wikipedia Dev.jpg (2×1 px, 89 KB)

cooltey updated the task description. (Show Details)Dec 2 2023, 2:57 PM
scblr added a comment.Dec 6 2023, 11:34 AM

Thanks @cooltey 👍

1)

Just want to let you know that in the customizable toolbar, if the user has already customized the order, the newly added "View on map" will show on the last position of the overflow menu.

But if the user has never updated it before (the preference will be empty), the default position will be below the "Edit history"

Screenshot_20231130-142353_Wikipedia Dev.jpg (2×1 px, 120 KB)
Screenshot_20231130-142337_Wikipedia Dev.jpg (2×1 px, 112 KB)
DefaultCustomized in an older version

Looks good to me!

2)

Do we need to update the "View on map" behavior in the footer? The current behavior is that it will open it in your system map app like Google Maps.

Screenshot_20231201-102612_Wikipedia Dev.jpg (2×1 px, 89 KB)

Yes, having the same behavior as in the overflow menu would be good.

3)

If I move "View on map" to the toolbar, it is:

a) Still visible in the overflow menu

b) Not greyed out in the toolbar (use the inactive color group)

Screenshot_20231206-121327 copy.png (2×1 px, 688 KB)

Can you look into this? Thanks!

4) Make sure to use the primary color group for all icons and labels in the toolbar (except for the ones that are disabled)

Screenshot_20231206-122913.png (2×1 px, 1 MB)

scblr moved this task from Design signoff to Did not pass Design on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.Dec 6 2023, 11:34 AM
cooltey moved this task from Did not pass Design to Design signoff on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.Dec 7 2023, 1:09 AM

Hi @scblr,

Yes, having the same behavior as in the overflow menu would be good.

Done!

3)

If I move "View on map" to the toolbar, it is:

a) Still visible in the overflow menu

Fixed!

b) Not greyed out in the toolbar (use the inactive color group)

Screenshot_20231206-121327 copy.png (2×1 px, 688 KB)

Can you look into this? Thanks!

Done! Also fixed the same issue on "Edit article" option.

4) Make sure to use the primary color group for all icons and labels in the toolbar (except for the ones that are disabled)

Done.

Please download the APK from the ticket description and let me know if you have questions. Thanks!

Sharvaniharan renamed this task from Nearby: Add ‘View on map’ to customizable article toolbar to Places: Add ‘View on map’ to customizable article toolbar.Dec 7 2023, 2:30 AM
scblr added a comment.Dec 7 2023, 1:59 PM

Looks good to me @cooltey – thanks!

scblr moved this task from Design signoff to Code Review on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.Dec 7 2023, 2:00 PM
cooltey moved this task from Code Review to Merged and Waiting on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.Dec 11 2023, 11:15 PM
Dbrant moved this task from Merged and Waiting to QA signoff on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.Feb 6 2024, 7:07 PM
ABorbaWMF moved this task from QA signoff to Ready for PM signoff on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.Feb 14 2024, 12:35 AM
ABorbaWMF subscribed.

Working for me on 2.7.50470-beta-2024-02-08

JTannerWMF moved this task from Ready for PM signoff to Ready for release on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.Feb 16 2024, 7:45 PM
Dbrant closed this task as Resolved.Feb 21 2024, 4:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL