Hi @scblr

This is the current LinkPreviewDialog when you tap on links on the article page, and I made a change to it so I can take a screenshot that shows the "Get directions" button.

Now, the "Get directions" is not showing anywhere and I cannot find the reason for not sending the Location information to the dialog, which is pretty weird.

The question is:

1. Should we change "Get directions" to "View on map" if the article has Location information so we can see it on the Places?
2. Does the design need to be updated? Showing three buttons on the bottom seems a bit crowded.

@cooltey two comments:

1. The get directions option should be in the overflow menu; see designs in the task description.
2. Per previous discussions with @Sharvaniharan and @JTannerWMF: only the LinkPreviewDialog within Places should be updated. The LinkPreviewDialog within the article should stay the same.

Thanks!

Hi @scblr

Per the discussion we had on Slack:

1. Change "Get directions" to "View on map"
2. Move the button to the overflow menu.
3. This change only affects the current LinkPreviewDialog on the article page.

Hi @scblr,

The implementation of the link preview dialog is now completed. While waiting for the search bar to be merged into the feature branch, you are welcome to review the design now.

Thank you @cooltey, looks great already! 👏

1) Can we show the expanded full sheet from the beginning?

Like this	not	Like this

2) Would it be possible to add a handlebar to the top of the sheet?

Implementation	vs	Design

3) The 'Save' action should show the same snackbar as in the article (above the sheet)

Implementation	vs	Design

4) There’s something off with the font definition used in the snackbar. It seems like there’s letter spacing applied to the h3-button type style, which should not be the case.

Implementation	vs	Design

Make sure to use...

font-family: Roboto
font-weight: Medium
font-size: 16sp
line-height: 24sp/1.5em

...with no letter spacing

5) Is there some shadow or watermark applied to the thumbnail in the sheet?

If yes, please remove it :)

In T351395#9420863, @scblr wrote:

4) There’s something off with the font definition used in the snackbar. It seems like there’s letter spacing applied to the h3-button type style, which should not be the case.

@scblr If you spot issues or inconsistencies with general components, such as our Snackbars, please catalog them in a separate ticket such as T336702, so that these changes apply everywhere, and are not linked to a specific feature.

I renamed the task to reflect the fact that we're making updates to the Link Preview component, which will apply globally wherever link previews are used.

If we need the appearance or behavior to deviate in the special case of Places, it would be great if we could list the deviations explicitly, and preferably keep them to a minimum.

Hi, @scblr
Please download the APK from the ticket description to see the changes.

1) Can we show the expanded full sheet from the beginning?

Done.

2) Would it be possible to add a handlebar to the top of the sheet?

Done.

3) The 'Save' action should show the same snackbar as in the article (above the sheet)

Done. Please note that if we need to show the snackbar, we have to dismiss the bottom sheet first before showing it.

4) There’s something off with the font definition used in the snackbar. It seems like there’s letter spacing applied to the h3-button type style, which should not be the case.

Done. (Looks like it is the default style for snackbar).

5) Is there some shadow or watermark applied to the thumbnail in the sheet?

There's nothing has been applied to the thumbnail, would you be able to check other places to see if it occurs again?

For the following two descriptions:

Tapping the search field when a location is active takes users to the search view with the active location. The keyboard is enabled, and the cursor is positioned at the end of the location string.
Tapping the 'Close' icon in the search bar takes users back to the map view, described in T351397

Since the actual search function is not in the feature branch yet, would it be possible to do these in another ticket?
Also, should we show the article title in the search bar when we tap on the marker?

Hi @scblr

Per code review comment:

1. When setting the bottomsheet to fully expand by default, it will cause a jumpy issue on the initial loading. Would it be possible to have the default peek behavior of the bottom sheet to avoid the issue?
2. About the bottomsheet handle, do we need to show the handle by default for the LinkPreviewDialog, not just for Places?

Thanks for all these updates @cooltey 🤝

1)

When setting the bottomsheet to fully expand by default, it will cause a jumpy issue on the initial loading. Would it be possible to have the default peek behavior of the bottom sheet to avoid the issue?

Ok, let’s keep the default peek behavior.

2) The status bar changes its color to paper when the bottom sheet is active. Can we avoid that behavior?

3)

About the bottomsheet handle, do we need to show the handle by default for the LinkPreviewDialog, not just for Places?

Yes, if feasible, please show the new handlebar everywhere to keep it consistent.

Hi @scblr, please download the APK to see the changes, thanks!

In T351395#9442070, @scblr wrote:

2) The status bar changes its color to paper when the bottom sheet is active. Can we avoid that behavior?

Done!

3)

About the bottomsheet handle, do we need to show the handle by default for the LinkPreviewDialog, not just for Places?

Done!

Thanks, @cooltey; this task is completed then! 👏

Working for me on 2.7.50470-beta-2024-02-08