Make the limited width and font size controls work for logged in users
Open, LowPublic5 Estimated Story Points
Actions

Description

Currently toggling limited width or font size throws a JavaScript error. We need to fix this before shipping to beta cluster. Ideally we'd like the solution to be a long-term and stable fix that we do not need to revisit again.

TODO

Talk with platform team about long term solutions in T345664.
Create a short term fix with a FIXME linking to the long term fix.
Add a test that means CI will break if the feature ever breaks again

Details

	Subject	Repo	Branch	Lines +/-
	Make the limited width and font size controls work for logged in users	mediawiki/skins/Vector	master	+81 -22

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Duplicate	Florian	T50946 Add font size adjustment feature
Duplicate	Jdlrobson	T91201 [GOAL] Accessibility settings/preferences on desktop and mobile
Open	Krinkle	T345664 How should client preferences work for logged in users?
Open	Edtadros	T351447 Make the limited width and font size controls work for logged in users

Event Timeline

Jdlrobson removed Krinkle as the assignee of this task.Thu, Nov 16, 6:30 PM

Jdlrobson triaged this task as High priority.

Jdlrobson created this task.

Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.

Jdlrobson mentioned this in T345664: How should client preferences work for logged in users?.Thu, Nov 16, 6:34 PM

Jdlrobson updated the task description. (Show Details)

ovasileva set the point value for this task to 5.Thu, Nov 16, 6:39 PM

Jdlrobson claimed this task.Mon, Nov 20, 7:02 PM

Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.

Change 975919 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Make the limited width and font size controls work for logged in users

https://gerrit.wikimedia.org/r/975919

gerritbot added a project: Patch-For-Review.Mon, Nov 20, 10:57 PM

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.Mon, Nov 20, 11:00 PM

Jdlrobson moved this task from Code Review to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.Tue, Nov 21, 3:31 AM

Change 975919 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Make the limited width and font size controls work for logged in users

https://gerrit.wikimedia.org/r/975919

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Tue, Nov 21, 4:00 AM

Maintenance_bot removed a project: Patch-For-Review.Tue, Nov 21, 4:10 AM

Jdlrobson updated the task description. (Show Details)Tue, Nov 21, 4:39 PM

Jdlrobson lowered the priority of this task from High to Medium.Tue, Nov 21, 5:39 PM

Jdlrobson lowered the priority of this task from Medium to Low.

Jdlrobson lowered the priority of this task from Low to Lowest.Tue, Nov 21, 10:14 PM

Jdlrobson raised the priority of this task from Lowest to Low.Mon, Nov 27, 6:30 PM

We put together a document describing handover of the API to the mediawiki platform team and concerns with the existing code. The conversation will continue there outside the scope of this ticket.

Make the limited width and font size controls work for logged in usersOpen, LowPublic5 Estimated Story PointsActions