Page MenuHomePhabricator
Create Task
Maniphest T351447

Make the limited width and font size controls work for logged in users
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Currently toggling limited width or font size throws a JavaScript error. We need to fix this before shipping to beta cluster. Ideally we'd like the solution to be a long-term and stable fix that we do not need to revisit again.

TODO

  • Talk with platform team about long term solutions in T345664.
  • Create a short term fix with a FIXME linking to the long term fix.
  • Add a test that means CI will break if the feature ever breaks again

QA Results - Beta

ACStatusDetails
1✅T351447#9377547

QA Results - Prod

ACStatusDetails
1✅T351447#9381757

Details

SubjectRepoBranchLines +/-
Make the limited width and font size controls work for logged in usersmediawiki/skins/Vectormaster+81 -22
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson removed Krinkle as the assignee of this task.Nov 16 2023, 6:30 PM
Jdlrobson triaged this task as High priority.
Jdlrobson created this task.
Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.
Jdlrobson mentioned this in T345664: How should client preferences work for logged in users?.Nov 16 2023, 6:34 PM
Jdlrobson updated the task description. (Show Details)
ovasileva set the point value for this task to 5.Nov 16 2023, 6:39 PM
Jdlrobson claimed this task.Nov 20 2023, 7:02 PM
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.
gerritbot added a comment.Nov 20 2023, 10:57 PM

Change 975919 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Make the limited width and font size controls work for logged in users

https://gerrit.wikimedia.org/r/975919

gerritbot added a project: Patch-For-Review.Nov 20 2023, 10:57 PM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.Nov 20 2023, 11:00 PM
Jdlrobson moved this task from Code Review to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.Nov 21 2023, 3:31 AM
gerritbot added a comment.Nov 21 2023, 3:33 AM

Change 975919 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Make the limited width and font size controls work for logged in users

https://gerrit.wikimedia.org/r/975919

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 21 2023, 4:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 21 2023, 4:10 AM
Jdlrobson updated the task description. (Show Details)Nov 21 2023, 4:39 PM
Jdlrobson lowered the priority of this task from High to Medium.Nov 21 2023, 5:39 PM
Jdlrobson lowered the priority of this task from Medium to Low.
Jdlrobson lowered the priority of this task from Low to Lowest.Nov 21 2023, 10:14 PM
Jdlrobson raised the priority of this task from Lowest to Low.Nov 27 2023, 6:30 PM
Jdlrobson reassigned this task from Jdlrobson to Edtadros.Nov 28 2023, 5:52 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Doing to QA on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.

We put together a document describing handover of the API to the mediawiki platform team and concerns with the existing code. The conversation will continue there outside the scope of this ticket.

Jdlrobson raised the priority of this task from Low to High.Dec 1 2023, 8:28 PM
Edtadros removed Edtadros as the assignee of this task.Dec 4 2023, 2:31 AM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: A logged in user should be able to change font size and width with out any errors in the console.

screenshot 161.mov.gif (750×2 px, 2 MB)

Edtadros updated the task description. (Show Details)Dec 4 2023, 2:32 AM
Jdlrobson closed this task as Resolved.Dec 4 2023, 6:07 PM
Jdlrobson claimed this task.
Edtadros added a project: Verified.Dec 5 2023, 6:53 AM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: A logged in user should be able to change font size and width with out any errors in the console.

screenshot 164.mov.gif (898×1 px, 2 MB)

Edtadros updated the task description. (Show Details)Dec 5 2023, 6:54 AM
Edtadros mentioned this in T351126: Verify 1.42.0-wmf.7 deployment.Dec 5 2023, 8:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits