Page MenuHomePhabricator

Reply link icon not shown in language variants of designated "short reply button" languages
Closed, ResolvedPublic


For example in Egyptian Arabic, we aren't showing the reply icon, even though that language is using standard Arabic messages via the language fallback mechanism:

image.png (176×240 px, 11 KB)

Rather than explicitly listing all current known fallbacks, we should do the following:

  • If a language is not found in the "reply_icon_languages" list (currently ar/zh/yue/ja/nod), get the fallback language list for that language
  • Check each fallback, and if it is found in the list, use the icon

As we may end up in a situation where a variant doesn't need an icon, even though one of the fallbacks does, we should convert the list to a dictionary and allow explicit true/false values. So, for example, if an Egyption Arabic translation was added and it was significantly longer than standard Arabic, we could explicitly set "arz": false to avoid it falling back to the true value from standard Arabic.

  • Talk pages will show the reply arrow icon when using varaints of ar/zh/yue/ja/nod, e.g.
    • ?uselang=arz
    • ?uselang=zh-tw

Event Timeline

Change 978544 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Check language fallbacks in isLanguageRequiringReplyIcon

Change 978544 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Check language fallbacks in isLanguageRequiringReplyIcon

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
Ryasmeen edited projects, added Verified; removed Editing QA.