Page MenuHomePhabricator

[Config Change] Add Clear Affordances (with arrow) to beta feature (desktop)
Closed, ResolvedPublic

Description

This task is a "sibling" of T321955 in so far as T321955 introduces the new Reply button styling on desktop without an arrow being prefixed to the button.

Whereas this ticket includes the work of introducing the new Reply button styling on desktop with an arrow being prefixed to the button.

T321955THIS TICKET
Before
image.png (239×1 px, 23 KB)
Screen Shot 2022-10-12 at 3.29.03 PM.png (1×1 px, 860 KB)
After
image.png (239×1 px, 25 KB)
Screen Shot 2022-11-21 at 10.56.29 AM.png (1×1 px, 411 KB)

Deployment timing

Deployment DateWikis and Interface LanguagesStatus
14 December 2022 (tomorrow)Wikis: zh.wiki, zh-yue.wiki, ja.wiki; Interface languages: Chinese zh), Cantonese (yue), Japanese (ja), Northern Thai (nod)✅ Deployed
19 December 2022 (Monday)Wikis: ar.wiki; Interface languages: Arabic (ar)✅ Deployed

Requirements

  • People who meet the criteria below will see the new Reply affordance styling when visiting any Article or User talk pages on desktop:
    • People who have the Discussion tools beta feature enabled
    • People who have the Show discussion activity setting within Special:Preferences#mw-prefsection-editing enabled
    • People using the desktop version of the site
    • People accessing the desktop version of the site, at any project, with their interface languages set to any one of the following:
      • Arabic (ar)
      • Chinese (zh)
      • Cantonese (yue)
      • Japanese (ja)
      • Norther Thai (nod)

Minimum test case

  1. Any any wiki, visit Special:Preferences#mw-prefsection-betafeatures (make sure your interface language is set to one of the languages listed above)
  2. Ensure the Discussion tools Beta Feature is enabled and the Show metadata about each discussion and enable a new page layout. list item appears within it
  3. Visit a User or Article talk page
  4. Verify that all Reply links/buttons appear in the way(s) we defined above
  5. Visit a talk page that is NOT in the User or Article talk namespace and verify that Reply links appear as they did prior to this deployment and the Add topic button T267444 introduces is not visible. Read: talk page sections should continue being styled as they had before today's deployment.

Done

  • Requirements are implemented and verified as having been implemented

Event Timeline

ppelberg updated the task description. (Show Details)
ppelberg updated the task description. (Show Details)

Per the conversation we had as a team offline today, the interface language someone has set should be the only input that determines whether people viewing the desktop site with the Show discussion activity setting enabled will see Reply buttons prefixed with an arrow.

(I've updated the task description to reflect the above.)

Just curious, but why not Korean too? Korean 답변 (hanja 答辯 according to Wikipedia search) is also just 2 characters. Was the list a result of a systematic review, or was it created through user feedback only?

Change 867310 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] VisualEnhancements: in some languages put an arrow by the reply button

https://gerrit.wikimedia.org/r/867310

Change 867311 had a related patch set uploaded (by DLynch; author: DLynch):

[operations/mediawiki-config@master] Complete deployment of DiscussionTools reply visual enhancements

https://gerrit.wikimedia.org/r/867311

Just curious, but why not Korean too? Korean 답변 (hanja 答辯 according to Wikipedia search) is also just 2 characters. Was the list a result of a systematic review, or was it created through user feedback only?

It was a combination of both, but I don't remember us talking about Korean language in particular. We'd be happy to change it as well if there's support for this among the Korean speakers.

Change 867310 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] VisualEnhancements: in some languages put an arrow by the reply button

https://gerrit.wikimedia.org/r/867310

Change 867619 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.13] VisualEnhancements: in some languages put an arrow by the reply button

https://gerrit.wikimedia.org/r/867619

Change 867620 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.14] VisualEnhancements: in some languages put an arrow by the reply button

https://gerrit.wikimedia.org/r/867620

It was a combination of both, but I don't remember us talking about Korean language in particular. We'd be happy to change it as well if there's support for this among the Korean speakers.

Perhaps someone working on this project might want to go there and ask. I don’t speak Korean and wouldn’t be an appropriate person.

I did a non-systematic quick scan of a few wikis that I felt might suffer from the same problem, and found cdo (回覆), gan (回覆), wuu (回复) and zh-classical (回覆); all CJK languages are likely to be affected, but some don’t have DiscussionTools enabled.

BTW, the UI of zh-classical isn’t properly translated (it’s in written Mandarin, not classical Chinese); had it been properly translated the label for Reply is likely just a single character (likely just 覆)

Change 867619 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.13] VisualEnhancements: in some languages put an arrow by the reply button

https://gerrit.wikimedia.org/r/867619

Change 867620 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.14] VisualEnhancements: in some languages put an arrow by the reply button

https://gerrit.wikimedia.org/r/867620

Mentioned in SAL (#wikimedia-operations) [2022-12-14T21:54:14Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:867619|VisualEnhancements: in some languages put an arrow by the reply button (T323537)]], [[gerrit:867620|VisualEnhancements: in some languages put an arrow by the reply button (T323537)]]

Mentioned in SAL (#wikimedia-operations) [2022-12-14T21:56:02Z] <samtar@deploy1002> samtar and kemayo: Backport for [[gerrit:867619|VisualEnhancements: in some languages put an arrow by the reply button (T323537)]], [[gerrit:867620|VisualEnhancements: in some languages put an arrow by the reply button (T323537)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-12-14T22:03:09Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:867619|VisualEnhancements: in some languages put an arrow by the reply button (T323537)]], [[gerrit:867620|VisualEnhancements: in some languages put an arrow by the reply button (T323537)]] (duration: 08m 55s)

Change 867311 merged by jenkins-bot:

[operations/mediawiki-config@master] Deployment of DiscussionTools reply visual enhancements for more wikis

https://gerrit.wikimedia.org/r/867311

Mentioned in SAL (#wikimedia-operations) [2022-12-14T22:04:38Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:867311|Deployment of DiscussionTools reply visual enhancements for more wikis (T323537)]]

Mentioned in SAL (#wikimedia-operations) [2022-12-14T22:06:23Z] <samtar@deploy1002> samtar and kemayo: Backport for [[gerrit:867311|Deployment of DiscussionTools reply visual enhancements for more wikis (T323537)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-12-14T22:12:51Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:867311|Deployment of DiscussionTools reply visual enhancements for more wikis (T323537)]] (duration: 08m 12s)

Change 868441 had a related patch set uploaded (by DLynch; author: DLynch):

[operations/mediawiki-config@master] Release new DiscussionTools reply button enhancement to Arabic

https://gerrit.wikimedia.org/r/868441

Change 868441 merged by jenkins-bot:

[operations/mediawiki-config@master] Release new DiscussionTools reply button enhancement to Arabic

https://gerrit.wikimedia.org/r/868441

Mentioned in SAL (#wikimedia-operations) [2022-12-19T15:02:50Z] <thcipriani@deploy1002> Started scap: Backport for [[gerrit:868441|Release new DiscussionTools reply button enhancement to Arabic (T323537)]]

Mentioned in SAL (#wikimedia-operations) [2022-12-19T15:04:28Z] <thcipriani@deploy1002> thcipriani and kemayo: Backport for [[gerrit:868441|Release new DiscussionTools reply button enhancement to Arabic (T323537)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-12-19T15:12:22Z] <thcipriani@deploy1002> Finished scap: Backport for [[gerrit:868441|Release new DiscussionTools reply button enhancement to Arabic (T323537)]] (duration: 09m 31s)

Does anyone know why the arrow does not appear before the Reply button when you set your interface language to zh-yue?

URLExpectedActual
https://zh-yue.wikipedia.org/wiki/Talk:%E5%85%AC%E4%BB%94%E9%BA%AA?uselang=zh-yueArrow appears before Reply buttonArrow does NOT appear before Reply:
Screen Shot 2022-12-22 at 11.58.25 AM.png (188×344 px, 25 KB)

Thank you to @Whatamidoing-WMF for spotting this issue.

Change 870973 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] Language code for zh-yue wiki is just yue

https://gerrit.wikimedia.org/r/870973

Turns out that you visit zh-yue.wikipedia.org or do uselang=zh-yue, but the code that the language object uses for it is just yue.

Change 870973 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Language code for zh-yue wiki is just yue

https://gerrit.wikimedia.org/r/870973

EAkinloose subscribed.
User/Article namespaceOthers
arwiki
Screenshot 2023-01-05 at 23.36.43.png (730×1 px, 69 KB)
Screenshot 2023-01-05 at 23.51.44.png (230×1 px, 87 KB)
zhwiki
Screenshot 2023-01-05 at 23.40.20.png (702×1 px, 85 KB)
Screenshot 2023-01-05 at 23.53.57.png (264×2 px, 115 KB)
jawiki
Screenshot 2023-01-05 at 23.44.08.png (342×1 px, 67 KB)
Screenshot 2023-01-05 at 23.56.10.png (384×1 px, 117 KB)