Page MenuHomePhabricator
Create Task
Maniphest T360014

User JavaScript not loading on 1.42.0-wmf.22 (Wikidata, Commons, other group1 wikis)
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The personal JavaScript does not load.

What should have happened instead?:
Personal JavaScript should load.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
ResourceLoader: Add WikiModule regression test for T360014mediawiki/coremaster+15 -4
ResourceLoader: Edit real pages in testGetPreloadedTitleInfomediawiki/coremaster+33 -33
WikiModule: Fix pages mergingmediawiki/coremaster+4 -1
WikiModule: Fix pages mergingmediawiki/corewmf/1.42.0-wmf.22+4 -1
Revert "group1 wikis to 1.42.0-wmf.22"operations/mediawiki-configmaster+549 -549
Customize query in gerrit

Related Objects

Event Timeline

jhsoby created this task.Mar 13 2024, 9:46 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 13 2024, 9:46 AM
jhsoby triaged this task as Unbreak Now! priority.Mar 13 2024, 9:47 AM

At least on Wikidata, this has an extremely high impact on users' workflow, so setting to UBN!

jhsoby added a parent task: T354440: 1.42.0-wmf.22 deployment blockers.Mar 13 2024, 9:48 AM
Lucas_Werkmeister_WMDE merged a task: T360013: Common.js not loading in Wikidata.Mar 13 2024, 9:48 AM
Lucas_Werkmeister_WMDE added a subscriber: Epidosis.
jhsoby updated the task description. (Show Details)Mar 13 2024, 9:48 AM
Lucas_Werkmeister_WMDE renamed this task from common.js not loading on Wikidata to User common.js not loading on Wikidata.Mar 13 2024, 9:48 AM
Lucas_Werkmeister_WMDE mentioned this in T360013: Common.js not loading in Wikidata.
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE added a project: Wikidata.
Lucas_Werkmeister_WMDE added a project: MediaWiki-ResourceLoader.
Lucas_Werkmeister_WMDE subscribed.

Tentatively tagging ResourceLoader, I think RL is responsible for loading this code (and I know it was refactored a bit this train).

Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptMar 13 2024, 9:50 AM
Lucas_Werkmeister_WMDE added a comment.EditedMar 13 2024, 9:53 AM

Also affects Commons (another group1 wiki).

Lucas_Werkmeister_WMDE renamed this task from User common.js not loading on Wikidata to User common.js not loading on 1.42.0-wmf.22 (Wikidata, Commons, other group1 wikis).Mar 13 2024, 9:54 AM
Mbch331 subscribed.Mar 13 2024, 9:57 AM
jhsoby renamed this task from User common.js not loading on 1.42.0-wmf.22 (Wikidata, Commons, other group1 wikis) to User JavaScript not loading on 1.42.0-wmf.22 (Wikidata, Commons, other group1 wikis).Mar 13 2024, 9:58 AM
jhsoby updated the task description. (Show Details)
jhsoby updated the task description. (Show Details)
Lucas_Werkmeister_WMDE added a comment.Mar 13 2024, 9:58 AM

I’m able to reproduce the issue locally; git bisect points at ResourceLoader: Add preload for foreign WikiModule title info as the first bad commit.

hashar added subscribers: matmarex, Krinkle, hashar.Mar 13 2024, 10:09 AM
In T360014#9625896, @Lucas_Werkmeister_WMDE wrote:

I’m able to reproduce the issue locally; git bisect points at ResourceLoader: Add preload for foreign WikiModule title info as the first bad commit.

That change had a glitch yesterday ( T359939 ) which got fixed. I am adding @matmarex and @Krinkle who worked on that code.

I am rolling back the train meanwhile.

gerritbot added a comment.Mar 13 2024, 10:14 AM

Change 1010854 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/mediawiki-config@master] Revert "group1 wikis to 1.42.0-wmf.22"

https://gerrit.wikimedia.org/r/1010854

gerritbot added a project: Patch-For-Review.Mar 13 2024, 10:14 AM

Change 1010854 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "group1 wikis to 1.42.0-wmf.22"

https://gerrit.wikimedia.org/r/1010854

Lucas_Werkmeister_WMDE added a comment.Mar 13 2024, 10:17 AM

In ?debug=2 mode, I can see that the load.php URL for modules=user is no longer loaded. (If I load it manually, it still responds with the same JS as before.)

Stashbot mentioned this in T354440: 1.42.0-wmf.22 deployment blockers.Mar 13 2024, 10:26 AM

Mentioned in SAL (#wikimedia-operations) [2024-03-13T10:26:36Z] <hashar@deploy2002> rebuilt and synchronized wikiversions files: Revert "group1 wikis to 1.42.0-wmf.22" - T354440 T360014

gerritbot added a comment.Mar 13 2024, 10:28 AM

Change 1010856 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@master] WikiModule: Fix pages merging

https://gerrit.wikimedia.org/r/1010856

Lucas_Werkmeister_WMDE added a comment.Mar 13 2024, 10:28 AM
In T360014#9625963, @gerritbot wrote:

Change 1010856 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@master] WikiModule: Fix pages merging

https://gerrit.wikimedia.org/r/1010856

I don’t claim to fully understand this code, but this at least fixes the issue for me locally. Please review :)

Michael subscribed.Mar 13 2024, 10:59 AM
gerritbot added a comment.Mar 13 2024, 11:10 AM

Change 1010871 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@master] WikiModule: Add test for T360014

https://gerrit.wikimedia.org/r/1010871

TheresNoTime subscribed.Mar 13 2024, 2:32 PM
gerritbot added a comment.Mar 13 2024, 2:57 PM

Change 1010581 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@wmf/1.42.0-wmf.22] WikiModule: Fix pages merging

https://gerrit.wikimedia.org/r/1010581

gerritbot added a comment.Mar 13 2024, 3:04 PM

Change 1010856 merged by jenkins-bot:

[mediawiki/core@master] WikiModule: Fix pages merging

https://gerrit.wikimedia.org/r/1010856

gerritbot added a comment.Mar 13 2024, 3:19 PM

Change 1010581 merged by jenkins-bot:

[mediawiki/core@wmf/1.42.0-wmf.22] WikiModule: Fix pages merging

https://gerrit.wikimedia.org/r/1010581

Stashbot added a comment.Mar 13 2024, 3:19 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-13T15:19:31Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 Started scap: Backport for [[gerrit:1010581|WikiModule: Fix pages merging (T360014)]]

Stashbot added a comment.Mar 13 2024, 3:21 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-13T15:21:57Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 lucaswerkmeister-wmde: Backport for [[gerrit:1010581|WikiModule: Fix pages merging (T360014)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Mar 13 2024, 3:33 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-13T15:32:59Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 Finished scap: Backport for [[gerrit:1010581|WikiModule: Fix pages merging (T360014)]] (duration: 13m 27s)

Lucas_Werkmeister_WMDE lowered the priority of this task from Unbreak Now! to Needs Triage.Mar 13 2024, 3:34 PM

I think this is resolved; we can leave the task open for potentially adding a test, but it’s no longer a train blocker.

Lucas_Werkmeister_WMDE removed a parent task: T354440: 1.42.0-wmf.22 deployment blockers.Mar 13 2024, 3:34 PM
hashar added a comment.Mar 13 2024, 3:40 PM

Danke schön @Lucas_Werkmeister_WMDE

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).Mar 13 2024, 7:01 PM
gerritbot added a comment.Mar 14 2024, 1:17 AM

Change 1011012 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] ResourceLoader: Edit real pages in testGetPreloadedTitleInfo

https://gerrit.wikimedia.org/r/1011012

gerritbot added a comment.Mar 14 2024, 11:54 PM

Change 1011012 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Edit real pages in testGetPreloadedTitleInfo

https://gerrit.wikimedia.org/r/1011012

gerritbot added a comment.Mar 14 2024, 11:54 PM

Change 1010871 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Add WikiModule regression test for T360014

https://gerrit.wikimedia.org/r/1010871

Jdforrester-WMF closed this task as Resolved.Mar 14 2024, 11:59 PM
Jdforrester-WMF assigned this task to Krinkle.
Maintenance_bot removed a project: Patch-For-Review.Mar 15 2024, 12:30 AM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.23; 2024-03-19); removed MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).Mar 15 2024, 1:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL