Page MenuHomePhabricator
Create Task
Maniphest T361396

1.43.0-wmf.2 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
dancy
Release Version
1.43.0-wmf.2
Release Date
Mon, Apr 22, 12:00 AM

2024 week 17 1.43-wmf.2 Changes wmf/1.43.0-wmf.2

This MediaWiki Train Deployment is scheduled for the week of Monday, April 22nd:

Monday April 22ndTuesday, April 23rdWednesday, April 24thThursday, April 25thFriday
Backports only.Branch wmf.2 and deploy to Group 0 Wikis.Deploy wmf.2 to Group 1 Wikis.Deploy wmf.2 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.2 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.43.0-wmf.1
Next: 1.43.0-wmf.3
SubjectRepoBranchLines +/-
group2 wikis to 1.43.0-wmf.2operations/mediawiki-configmaster+336 -336
group1 wikis to 1.43.0-wmf.2operations/mediawiki-configmaster+553 -553
group0 wikis to 1.43.0-wmf.2operations/mediawiki-configmaster+132 -132
testwikis wikis to 1.43.0-wmf.2operations/mediawiki-configmaster+132 -132
group0 wikis to 1.43.0-wmf.2operations/mediawiki-configmaster+135 -135
Branch commit for wmf/1.43.0-wmf.2mediawiki/corewmf/1.43.0-wmf.2+996 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Mar 29 2024, 8:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 29 2024, 8:42 PM
thcipriani assigned this task to brennen.Mon, Apr 15, 2:55 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: dancy.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).
brennen added a project: User-brennen.Mon, Apr 15, 4:08 PM
ABreault-WMF mentioned this in T362988: CTT tasks week of 2024-04-19.Fri, Apr 19, 3:27 PM
ssastry added subscribers: cscott, ssastry.Sat, Apr 20, 4:57 AM

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/832495 is riding this train which looks potentially risk and could cause ParserCache errors if the train is rolled back. Not sure if 1.43.1 can correctly process PC entries produced by master (1.43.2). So, I would not roll forward the train till we can establish that. I am signing off for the weekend but wanted to flag this before I disappeared because this came up in a slack conversation with Jon Robson. @cscott FYI.

cscott mentioned this in T363107: Potential logspam on rollback of 1.43-wmf.2.Mon, Apr 22, 3:24 PM
cscott added a subtask: T363107: Potential logspam on rollback of 1.43-wmf.2.
cscott added a comment.Mon, Apr 22, 3:36 PM

Thanks for the spot, @ssastry. T363107 has a description of the issue and two belt-and-suspenders patches to fix it. It doesn't look like 1.43.0-wmf.2 has been branched yet (?) but I'll submit them both to backport.

gerritbot added a comment.Tue, Apr 23, 1:07 AM

Change #1022534 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.43.0-wmf.2] Branch commit for wmf/1.43.0-wmf.2

https://gerrit.wikimedia.org/r/1022534

gerritbot added a project: Patch-For-Review.Tue, Apr 23, 1:07 AM
gerritbot added a comment.Tue, Apr 23, 1:27 AM

Change #1022534 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.2] Branch commit for wmf/1.43.0-wmf.2

https://gerrit.wikimedia.org/r/1022534

hashar added a subtask: T363086: ManagementSSHDown parse1002.eqiad.wmnet.Tue, Apr 23, 9:05 AM
hashar subscribed.Tue, Apr 23, 9:09 AM

Note that MediaWiki scap deployments exit with status 1 due to parse1002.eqiad.wmnet being down which prevents the docker_pull_k8s to complete successfully. All steps run though, but scap ultimately exit 1 which can be misleading (albeit the deployment itself has worked).

The host being down is T363086, it needs to be removed from the dsh group for kubernetes-workers. I have added it as a subtask so that deployers are aware of it, it is technically not blocking the train.

akosiaris closed subtask T363086: ManagementSSHDown parse1002.eqiad.wmnet as Resolved.Tue, Apr 23, 3:04 PM
Stashbot added a comment.Tue, Apr 23, 6:04 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-23T18:04:42Z] <brennen> train 1.43.0-wmf.2 (T361396) status: no current blockers, rolling to group0

gerritbot added a comment.Tue, Apr 23, 6:04 PM

Change #1023477 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group0 wikis to 1.43.0-wmf.2

https://gerrit.wikimedia.org/r/1023477

gerritbot added a comment.Tue, Apr 23, 6:05 PM

Change #1023477 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.43.0-wmf.2

https://gerrit.wikimedia.org/r/1023477

gerritbot added a comment.Tue, Apr 23, 6:16 PM

Change #1023478 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] testwikis wikis to 1.43.0-wmf.2

https://gerrit.wikimedia.org/r/1023478

gerritbot added a comment.Tue, Apr 23, 6:16 PM

Change #1023478 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.43.0-wmf.2

https://gerrit.wikimedia.org/r/1023478

Stashbot added a comment.Tue, Apr 23, 6:18 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-23T18:18:34Z] <brennen@deploy1002> Started scap: testwikis wikis to 1.43.0-wmf.2 refs T361396

Stashbot added a comment.Tue, Apr 23, 7:15 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-23T19:15:24Z] <brennen@deploy1002> Finished scap: testwikis wikis to 1.43.0-wmf.2 refs T361396 (duration: 56m 50s)

gerritbot added a comment.Tue, Apr 23, 7:16 PM

Change #1023488 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group0 wikis to 1.43.0-wmf.2

https://gerrit.wikimedia.org/r/1023488

gerritbot added a comment.Tue, Apr 23, 7:17 PM

Change #1023488 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.43.0-wmf.2

https://gerrit.wikimedia.org/r/1023488

Stashbot added a comment.Tue, Apr 23, 7:31 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-23T19:31:16Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.43.0-wmf.2 refs T361396

Zabe added a subtask: T363213: PHP Notice: Undefined property: stdClass::$afl_var_dump.Tue, Apr 23, 7:32 PM
brennen closed subtask T363213: PHP Notice: Undefined property: stdClass::$afl_var_dump as Resolved.Tue, Apr 23, 10:29 PM
Stashbot added a comment.Wed, Apr 24, 6:03 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-24T18:03:10Z] <brennen> train 1.43.0-wmf.2 (T361396) status: no current blockers, rolling to group1

Jdlrobson mentioned this in T361456: Verify 1.43.0-wmf.1 deployment.Wed, Apr 24, 6:04 PM
gerritbot added a comment.Wed, Apr 24, 6:05 PM

Change #1023929 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group1 wikis to 1.43.0-wmf.2

https://gerrit.wikimedia.org/r/1023929

gerritbot added a comment.Wed, Apr 24, 6:05 PM

Change #1023929 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.43.0-wmf.2

https://gerrit.wikimedia.org/r/1023929

Stashbot added a comment.Wed, Apr 24, 6:20 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-24T18:20:13Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.43.0-wmf.2 refs T361396

brennen mentioned this in T363486: MediaSearch: ApiUsageException: We could not complete your search due to a temporary problem. Please try again later..Thu, Apr 25, 3:23 PM
brennen moved this task from Backlog to Doing on the User-brennen board.Thu, Apr 25, 5:12 PM
Stashbot added a comment.Thu, Apr 25, 6:08 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-25T18:08:19Z] <brennen> train 1.43.0-wmf.2 (T361396) status: no current blockers, rolling to group2

gerritbot added a comment.Thu, Apr 25, 6:08 PM

Change #1024464 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group2 wikis to 1.43.0-wmf.2

https://gerrit.wikimedia.org/r/1024464

gerritbot added a comment.Thu, Apr 25, 6:09 PM

Change #1024464 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.43.0-wmf.2

https://gerrit.wikimedia.org/r/1024464

Stashbot added a comment.Thu, Apr 25, 6:23 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-25T18:23:46Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group2 wikis to 1.43.0-wmf.2 refs T361396

brennen closed this task as Resolved.Thu, Apr 25, 10:28 PM

Stable on all wikis since deploy. Optimistically resolving.

hashar reopened subtask T363086: ManagementSSHDown parse1002.eqiad.wmnet as Open.Fri, Apr 26, 9:54 AM
Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 26, 6:50 PM
Jclark-ctr closed subtask T363086: ManagementSSHDown parse1002.eqiad.wmnet as Resolved.Mon, Apr 29, 5:54 PM
Jclark-ctr reopened subtask T363086: ManagementSSHDown parse1002.eqiad.wmnet as Open.Mon, Apr 29, 6:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL