Page MenuHomePhabricator
Create Task
Maniphest T366618

Use a global preference for accepting the IP reveal agreement
Open, Needs TriagePublic2 Estimated Story Points
Actions

Description

Background

Users who have the right to reveal IPs of temporary users globally (or on multiple wikis) don't want to check a preference on each new wiki they visit for patrolling work.

We need a global preference that works like the local preference implemented in T326736: Create preference for viewing IP addresses used by temporary accounts.

Details

It would be nice to replace the local preference with a global preference, rather than introducing a global preference in addition to the local preference. Anyone accepting the preference would be accepting the agreement for all our wikis.

Advantages of this:

  • For users with the right to reveal IP on more than one wiki, they only need to accept the preference once
  • For users who only have the right to reveal IP on one wiki, once they have accepted the global agreement, they do not need to sign it again if they gain the right on another wiki
  • We will not need to determine what should happen if the global and local preferences don't match. The existence of a global and local preference led to complexity during the IPInfo project: T298977

Details

SubjectRepoBranchLines +/-
Handle 'info' preferences in Special:GlobalPreferencesmediawiki/extensions/GlobalPreferencesmaster+38 -0
Make IP reveal preference description appear in GlobalPreferencesmediawiki/extensions/CheckUsermaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Tue, Jun 4, 4:05 PM
Tchanders edited projects, added Trust and Safety Product Sprint; removed Epic.
Tchanders moved this task from Backlog to Update MediaWiki Core to introduce temp accounts on the Temporary accounts board.
Tchanders edited projects, added Temporary accounts (Update MediaWiki Core to introduce temp accounts); removed Temporary accounts.
Tchanders moved this task from Update MediaWiki Core to introduce temp accounts to Create/update essential tools/anti-abuse management on the Temporary accounts board.
Tchanders edited projects, added Temporary accounts (Create/update essential tools/anti-abuse management); removed Temporary accounts (Update MediaWiki Core to introduce temp accounts).
Tchanders added a project: MediaWiki-extensions-GlobalPreferences.Tue, Jun 4, 4:09 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptTue, Jun 4, 4:09 PM
Johannnes89 subscribed.Tue, Jun 4, 4:33 PM
Tchanders mentioned this in T367170: Assign IP reveal rights to certain groups for testwiki rollout.Tue, Jun 11, 12:53 PM
Tchanders edited projects, added Trust and Safety Product Sprint (Sprint 12 (Jun 24 - July 5)); removed Trust and Safety Product Sprint.Tue, Jun 25, 10:39 AM
Tchanders moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint 12 (Jun 24 - July 5)) board.
Dreamy_Jazz claimed this task.Wed, Jun 26, 11:04 AM
Dreamy_Jazz set the point value for this task to 23.
Dreamy_Jazz changed the point value for this task from 23 to 2.
Dreamy_Jazz moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint 12 (Jun 24 - July 5)) board.
gerritbot added a comment.Wed, Jun 26, 11:50 AM

Change #1049911 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalPreferences@master] [WIP] Handle 'info' preferences in Special:GlobalPreferences

https://gerrit.wikimedia.org/r/1049911

gerritbot added a project: Patch-For-Review.Wed, Jun 26, 11:50 AM
gerritbot added a comment.Wed, Jun 26, 11:53 AM

Change #1049913 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Make IP reveal preference description appear in GlobalPreferences

https://gerrit.wikimedia.org/r/1049913

Dreamy_Jazz added a comment.Wed, Jun 26, 2:52 PM

We will not need to determine what should happen if the global and local preferences don't match.

AFAIK based on my testing, MediaWiki-extensions-GlobalPreferences will handle this for us. The issue with IP Info seemed to be that a checkbox to agree to the tool use was not on Special:Preferences. As no such equivalent exists for temporary account IP reveal, we can rely on MediaWiki-extensions-GlobalPreferences handling the difference for us.

It also seems that the MediaWiki-extensions-GlobalPreferences support is enabled out of the box, but that the description text is not shown on Special:GlobalPreferences. I've made some patches that should address this by forcing this text to appear on Special:GlobalPreferences.

Dreamy_Jazz added a comment.EditedWed, Jun 26, 2:57 PM

This is what the preference looks like in Special:GlobalPreferences with the patches applied here:

image.png (242×924 px, 34 KB)

This again, but in a wider context:

image.png (1×981 px, 96 KB)

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint 12 (Jun 24 - July 5)) board.Wed, Jun 26, 3:48 PM
Dreamy_Jazz attached a referenced file: F55896245: image.png. (Show Details)Fri, Jun 28, 11:15 AM
Dreamy_Jazz added a comment.Fri, Jun 28, 11:21 AM

Suggested testing steps for when this is QA'd for local wiki:

  1. Install CheckUser and MediaWiki-extensions-GlobalPreferences
  2. Log into an account with the checkuser-temporary-account group. This is not checkuser as that has the -no-preference right, which will not be possible to use to test this. You can give the necessary right to the sysop group by adding the following to LocalSettings.php:
$wgGroupPermissions['sysop']['checkuser-temporary-account'] = true;
  1. Open Special:GlobalPreferences and verify that the preference to reveal temporary account IPs is displayed there along with the description for the preference.
  2. Open Special:Preferences and verify that the preference to reveal temporary account IPs is displayed there
  3. Using a variety of combinations of the preference being checked in Special:Preferences / Special:GlobalPreferences, test that when the preference is checked in either pages that the "Show IP" button is shown next to temporary account usernames. If the preference is unchecked in both forms, then the "Show IP" button should not be checked.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits