Page MenuHomePhabricator

Investigate setting IPInfo user preferences as Global Preferences
Open, LowPublicBUG REPORT

Description

What is the problem?

Currently, all the user preferences associated with IPInfo (T264150 and T292802) can be set globally.

We should decide whether this is desirable.

For example, we might prefer that administrators have to explicitly request access on each wiki they want to use IPInfo on.

If we decide to allow the preferences to be set globally, T&S needs to be aware that there are two possible places they need to look at (e.g. if they want to know who has access to IPInfo).

We should also be aware that allowing options to be set globally increases the amount of testing necessary (in my experience by a significant amount).

Steps to reproduce problem

To enable these options globally:

  1. Clone and enable GlobalPreferences extension ( wfLoadExtension("GlobalPreferences"); )
  2. Go to Special:GlobalPreferences (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Special:GlobalPreferences)
  3. Click on the "Beta features" tab
  4. Scroll down to the "IP Info" checkbox
  5. Click both checkboxes to make it global and turn it on globally
  6. Click Save
  7. Go to the "User profile" tab
  8. Scroll down to the section titled "IP Information"
  9. Check all four checkboxes to enable both options globally
  10. Click Save
Screenshots

The IP Info checkbox on the Beta features tab:

global_pref_beta.png (385×883 px, 41 KB)

IP Information section on the User profile tab:

global_pref_access.png (119×797 px, 5 KB)

Investigation

Investigate setting IPInfo user preferences as Global Preferences and how much work this entails before going back to Product on making that change.

GlobalPreferences

Event Timeline

If we decide to allow Global Preferences for these options there might be some behaviour and special cases we would have to consider.

For example, if I enable the Beta feature, ipinfo-enable and ipinfo-use-agreement globally, but I set ipinfo-use-agreement globally as unchecked, when I visit Special:Contributions I will see the enable IPInfo checkbox (below screenshot).

special_contribtions_checkbox.png (205×1 px, 25 KB)

If I check it and click "Enable IP Information tool" it will save a new value for ipinfo-use-agreement to the local wiki. But, because ipinfo-use-agreement is unset globally (and this is not overridden locally) the user will see a permission error.
special_contribtions_permission_error.png (116×551 px, 6 KB)

(It is also possible that they may see the IP Information if they have this cached on their browser from visiting this page previously.)

When they refresh the page they will see the "Enable IP Information tool" checkbox again, like in the first screenshot.

AGueyte renamed this task from Consider whether IPInfo user preferences should also be Global Preferences to Investigate setting IPInfo user preferences as Global Preferences.Jan 17 2022, 4:13 PM

Not triaging because this is still a Product Decision for @Niharika .

Niharika moved this task from Backlog to Future / Maybe on the IP Info board.

This is a nice-to-have at the moment.

Tchanders edited subscribers, added: Urbanecm, STran, kostajh and 2 others; removed: wikitrent.

Adding this into the temp accounts project, as it's related to making patrolling workflows less complicated - something that we want to ensure as we roll out temp accounts.