Page MenuHomePhabricator

Create preference for viewing IP addresses used by temporary accounts
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

See the parent task for more details.

We need a preference which, when selected, allows the user to reveal IP addresses (T325238) when they want to.

This should be added via the CheckUser extension, since that's where all the IP address reveal functionality lives.

Acceptance criteria

About the preference:

  • Checkbox, where checked means that the user can see IP address reveal buttons
  • Appears under the Special:Preferences#mw-prefsection-personal tab (the default tab)
  • Available to anyone with the checkuser-temporary-account right, and no-one else
  • Checked by default for users in the checkuser group see T327061: Enable temp account ip viewing preference by default for checkusers
  • Unchecked by default for everyone else
  • Section title TBC (T327281). For now, "Temporary account IP reveal"
  • Checkbox wording TBC (T327281). For now, "Enable revealing IP addresses for temporary accounts"

This task is just for adding the preference, not yet for checking it anywhere.

Notes
Testing notes
  • This should be tested locally
  • This should be tested with a user who has the checkuser-temporary-account right, e.g. by assigning $wgGroupPermissions['sysop']['checkuser-temporary-account'] = true; and testing with an admin account
  • It should probably also be tested with a user who doesn't have that right

Event Timeline

Tchanders renamed this task from Create preference for viewing IP addresses to Create preference for viewing IP addresses used by temporary accounts.Jan 11 2023, 3:51 PM
Tchanders created this task.

Change 880438 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/CheckUser@master] Add preference to view temp account IPs

https://gerrit.wikimedia.org/r/880438

Change 880438 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add preference to view temp account IPs

https://gerrit.wikimedia.org/r/880438

dom_walden set the point value for this task to 2.Jan 18 2023, 5:08 PM
dom_walden subscribed.

I have tested that a user with checkuser-temporary-account can set the new option both via Special:Preferences and Special:GlobalPreferences. I checked the database to see the correct value was saved.

Without the right, they do not see the new option.

Test environment: local docker CheckUser 2.5 (3cb190b) 14:10, 18 January 2023. GlobalPreferences 0.1.2 (9a1bd2d) 07:28, 16 January 2023.