Page MenuHomePhabricator
Create Task
Maniphest T366845

Black dots display on moved lines in diffs
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?: a black circle displays over the moved lines. It goes away when hovered.

image.png (395×878 px, 17 KB)

What should have happened instead?: Should not display.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
A similar issue also occurs with inline actually, except they're small blue triangles?

image.png (205×124 px, 3 KB)

Related link: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#It's_Thursday,_6_June_and_I_have_spots_before_my_eyes

Details

SubjectRepoBranchLines +/-
mediawiki.diff: Fix color regression and also use one more tokenmediawiki/corewmf/1.43.0-wmf.8+2 -1
mediawiki.diff: Fix color regression and also use one more tokenmediawiki/coremaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Izno created this task.Thu, Jun 6, 8:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Jun 6, 8:23 PM
Izno updated the task description. (Show Details)Thu, Jun 6, 8:29 PM
TheDJ added a parent task: T361402: 1.43.0-wmf.8 deployment blockers.Thu, Jun 6, 10:05 PM
Novem_Linguae subscribed.Fri, Jun 7, 6:36 AM
hgzh subscribed.Fri, Jun 7, 7:26 AM
GhostInTheMachine subscribed.Fri, Jun 7, 7:31 AM
Mormegil added subscribers: Volker_E, Mormegil.Fri, Jun 7, 8:41 AM

Same problem here. It seems to me this was caused at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1037742/1/resources/src/mediawiki.diff.styles/diff.less#b268 during T365759 (@Volker_E).

Johannnes89 subscribed.Fri, Jun 7, 1:04 PM
Jdlrobson added a parent task: T365759: Remove IE 11, Edge legacy 15-18, Firefox 39-48, Chrome 31-48 CSS hacks and workarounds in core, extensions and skins.Fri, Jun 7, 2:17 PM
Jdlrobson edited projects, added Front-end Modernization; removed Desktop Improvements (Vector 2022).
Jdlrobson subscribed.

Doesn't seem to be skin specific. Also impacts Monobook and Timeless:
https://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&diff=prev&oldid=1227609467&safemode=1&useskin=monobook
https://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&diff=prev&oldid=1227609467&safemode=1&useskin=timeless

There are no recent changes to diff code or https://gerrit.wikimedia.org/r/q/projects:mediawiki/php/wikidiff2
Which points to styling.

I ran git bisect and identified https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1037742 as the culprit.

1234qwer1234qwer4 subscribed.Fri, Jun 7, 3:45 PM
Pols12 added a project: Regression.Fri, Jun 7, 3:48 PM
Pols12 subscribed.

(Just for reference: ⚫ is in code because of T176485.
Per Jdlrobson’s investigations, this issue is a regression from MW-1.43-notes (1.43.0-wmf.8; 2024-06-04).)

gerritbot added a comment.Fri, Jun 7, 3:54 PM

Change #1040212 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.diff: Fix color regression and also use one more token

https://gerrit.wikimedia.org/r/1040212

gerritbot added a project: Patch-For-Review.Fri, Jun 7, 3:54 PM
Volker_E added a comment.EditedFri, Jun 7, 3:55 PM

Thanks @Izno, @Mormegil, @Jdlrobson and @Pols12 for the digging, patch provided.

IKhitron subscribed.Fri, Jun 7, 4:06 PM
gerritbot added a comment.Fri, Jun 7, 4:33 PM

Change #1040212 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.diff: Fix color regression and also use one more token

https://gerrit.wikimedia.org/r/1040212

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.9; 2024-06-11).Fri, Jun 7, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Fri, Jun 7, 5:30 PM
Volker_E closed this task as Resolved.Fri, Jun 7, 5:58 PM
Volker_E claimed this task.
gerritbot added a comment.Fri, Jun 7, 6:22 PM

Change #1040081 had a related patch set uploaded (by Dduvall; author: VolkerE):

[mediawiki/core@wmf/1.43.0-wmf.8] mediawiki.diff: Fix color regression and also use one more token

https://gerrit.wikimedia.org/r/1040081

gerritbot added a project: Patch-For-Review.Fri, Jun 7, 6:22 PM
gerritbot added a comment.Fri, Jun 7, 7:25 PM

Change #1040081 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.8] mediawiki.diff: Fix color regression and also use one more token

https://gerrit.wikimedia.org/r/1040081

Stashbot added a comment.Fri, Jun 7, 7:26 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-07T19:26:03Z] <dduvall@deploy1002> Started scap: Backport for [[gerrit:1040081|mediawiki.diff: Fix color regression and also use one more token (T366845)]]

Stashbot added a comment.Fri, Jun 7, 7:28 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-07T19:28:35Z] <dduvall@deploy1002> dduvall: Backport for [[gerrit:1040081|mediawiki.diff: Fix color regression and also use one more token (T366845)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Fri, Jun 7, 7:30 PM
Stashbot added a comment.Fri, Jun 7, 7:42 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-07T19:42:13Z] <dduvall@deploy1002> Finished scap: Backport for [[gerrit:1040081|mediawiki.diff: Fix color regression and also use one more token (T366845)]] (duration: 16m 10s)

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.8; 2024-06-04); removed MW-1.43-notes (1.43.0-wmf.9; 2024-06-11).Fri, Jun 7, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL