Page MenuHomePhabricator

History rows are not readable
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • Text in list is not readable.

What should have happened instead?:
The rule in core should be updated to use a design token:

#pagehistory li.selected { color: #202122; }
`

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

ACStatusDetails
1T367438#9904821

QA Results - PROD

ACStatusDetails
1T367438#9987098

Event Timeline

ovasileva set the point value for this task to 1.Jun 13 2024, 5:37 PM

Change #1047134 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/core@master] Use codex variables in history page to fix dark mode

https://gerrit.wikimedia.org/r/1047134

bwang removed bwang as the assignee of this task.Jun 18 2024, 4:31 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.
bwang subscribed.

Change #1047134 merged by jenkins-bot:

[mediawiki/core@master] History page: Use codex variables in history page to fix dark mode

https://gerrit.wikimedia.org/r/1047134

Change #1047163 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Use design tokens for suppressed and unpatrolled edits

https://gerrit.wikimedia.org/r/1047163

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
  1. Visit https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Conflict-title-0.14501166074480598-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n&action=history
  2. Text should be readable

2024-06-18_12-17-59.png (1×3 px, 532 KB)

Change #1047163 merged by jenkins-bot:

[mediawiki/core@master] Use design tokens for suppressed and unpatrolled edits

https://gerrit.wikimedia.org/r/1047163

ovasileva claimed this task.

Readable in light and dark mode. Resolving!

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
  1. Visit https://en.wikipedia.org/w/index.php?title=California&action=history
  2. Text should be readable

2024-07-16_11-12-49.png (1×3 px, 707 KB)