Page MenuHomePhabricator

Disable interactions with Flow content for users if temp accounts are used
Closed, ResolvedPublic

Description

Flow currently has no support for Temporary accounts and adding such support was declined in T342831: Temporary Accounts: Update StructuredDiscussions (Flow) because we intend to undeploy Flow.

As undeploying Flow is a large project, in the meantime, it would be nice if we disabled interactions with Flow boards for not-logged-in users. This should be possible via the onGetUserPermissionErrors hook by checking if temp account creations are enabled, and if the user is anon.

This task proposes that anonymous users and temporary account users are not able to modify Flow boards--they will be in read-only mode for these users.

References

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1051136 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/Flow@master] [temp accounts] Make Flow read-only for anon users

https://gerrit.wikimedia.org/r/1051136

Test wiki created on Patch demo by KHarlan (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/fb5a57311f/w

The patch seems to work:

image.png (1×1 px, 219 KB)

... although you can see that Flow has no recognition for temp account signatures, so the temp account appears like a regular account here:

image.png (962×1 px, 75 KB)

To further simplify, I think we could update the patch to make Flow boards read-only for temp accounts as well, in addition to anonymous users.

The community run https://www.mediawiki.org/wiki/Project:Support_desk system is current Flow based. It seems important that community administered tech support for MediaWiki continue to be accessible to unregistered users. The work at T365846: Assist communities in archiving Flow/StructuredDiscussions boards should maybe prioritize discussions with the mediawiki.org community to ensure that technical support for MediaWiki continue to function well with Temporary accounts.

The community run https://www.mediawiki.org/wiki/Project:Support_desk system is current Flow based. It seems important that community administered tech support for MediaWiki continue to be accessible to unregistered users. The work at T365846: Assist communities in archiving Flow/StructuredDiscussions boards should maybe prioritize discussions with the mediawiki.org community to ensure that technical support for MediaWiki continue to function well with Temporary accounts.

ack. Yes, we would not deploy temp accounts to wikis that have Flow boards as part of active, ongoing discussions. The patch proposed in this task is about enabling deployment to wikis like testwiki, and later pilot wikis without active Flow boards.

The work at T365846: Assist communities in archiving Flow/StructuredDiscussions boards should maybe prioritize discussions with the mediawiki.org community to ensure that technical support for MediaWiki continue to function well with Temporary accounts.

Sounds like a good idea, cc @ppelberg @Trizek-WMF

Mimurawil changed the task status from Open to In Progress.Jul 17 2024, 1:01 AM
Mimurawil claimed this task.

Change #1051136 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] [temp accounts] Set read-only mode for non-named users when temp accounts known

https://gerrit.wikimedia.org/r/1051136

Djackson-ctr subscribed.

Per the ticket Description, I have verified the new code has been implemented and is functioning and displaying as expected.

The work at T365846: Assist communities in archiving Flow/StructuredDiscussions boards should maybe prioritize discussions with the mediawiki.org community to ensure that technical support for MediaWiki continue to function well with Temporary accounts.

Sounds like a good idea, cc @ppelberg @Trizek-WMF

@Quiddity is working on this part. :)

Pppery renamed this task from Disable interactions with Flow content for anonymous users to Disable interactions with Flow content for users if temp accounts are used.Jul 19 2024, 2:09 AM