[S] Create modal sheet, next button and text field for Alt text MTV - flow B
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	HNordeenWMF
	Jul 16 2024, 11:26 PM

Description

Background

When writing alt text, it's important that the user can review the image in the context of the article and its caption. To allow this, we would like to show the user the article view automatically scrolled to the location of the relevant image in the background, and a halfsheet with the input box for alt text in the foreground.

Requirements

Create initial version of sheet with title, text field for alt text, and next button
Halfsheet can be minimized and then expanded again
Article view behind halfsheet can be scrolled, image can be opened in gallery view from article view behind
"Describe the image" input box has a fixed height
This task represents the work to trigger the task from flow B only

Design:

Figma

NOTE: Task is not intended to match designs fully, follow-up task T370327 will add image and link button, bottom copy/warning and counter, and guidance button

Related Objects
Search...

Status	Assigned	Task
Open	None	T357437 [Epic] Alt-Text Suggested Edit Experiment on iOS
Resolved	None	T357440 [Engineering Epic] Alt-text scaled experiment on iOS main flow and actions
Resolved	None	T370232 [S] Create modal sheet, next button and text field for Alt text MTV - flow B

Event Timeline

HNordeenWMF created this task.Jul 16 2024, 11:26 PM

HNordeenWMF triaged this task as Low priority.Jul 16 2024, 11:31 PM

HNordeenWMF moved this task from Tasks from Product Backlog to Needs Engineering Sync on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

HNordeenWMF updated the task description. (Show Details)

HNordeenWMF updated the task description. (Show Details)Jul 16 2024, 11:33 PM

HNordeenWMF attached a referenced file: F56470117: image.png. (Show Details)

HNordeenWMF attached a referenced file: F56470127: image.png. (Show Details)

HNordeenWMF mentioned this in T357440: [Engineering Epic] Alt-text scaled experiment on iOS main flow and actions.Jul 16 2024, 11:41 PM

HNordeenWMF mentioned this in T370327: [L] Modal sheet: Add image and link button, bottom copy/warning and counter, guidance button.Jul 17 2024, 5:23 PM

HNordeenWMF updated the task description. (Show Details)

HNordeenWMF updated the task description. (Show Details)Jul 17 2024, 5:49 PM

HNordeenWMF updated the task description. (Show Details)Jul 17 2024, 9:16 PM

HNordeenWMF mentioned this in T370236: [M] Publish Wikitext for Alt Text experiment - Flow B.Jul 17 2024, 10:18 PM

@HNordeenWMF I moved some requirements over to T370327, to help us get to MTV faster. Hope that's okay!

Tsevener renamed this task from Create sheet, next button and text field for Alt text MTV to [S] Create sheet, next button and text field for Alt text MTV.Jul 18 2024, 5:39 PM

Tsevener moved this task from Needs Engineering Sync to Ready for Development on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

AlexHollender-WMF unsubscribed.Jul 18 2024, 6:45 PM

Mazevedo renamed this task from [S] Create sheet, next button and text field for Alt text MTV to [S] Create modal sheet, next button and text field for Alt text MTV.Jul 23 2024, 3:15 PM

Mazevedo removed a subscriber: Jarrod_Baniqued.

Mazevedo claimed this task.Jul 29 2024, 6:55 PM

Mazevedo moved this task from Ready for Development to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Hi @scblr! Here on the modal header, the icon used is the SFSymbol named "accessibility." However, per Apple's guidelines, it "may only be used to refer to Apple's Accessibility features," so we can't use it here in this context.
Could we have an alternative to replace this icon?

Screenshot 2024-07-30 at 11.47.39.png (786×692 px, 69 KB)

HNordeenWMF mentioned this in T371428: [M] Add instrumentation for Sprint 1 tasks.Jul 30 2024, 7:21 PM

mazevedofs opened https://github.com/wikimedia/wikipedia-ios/pull/4906

tonisevener closed https://github.com/wikimedia/wikipedia-ios/pull/4906

Tsevener removed Mazevedo as the assignee of this task.Aug 1 2024, 2:29 PM

Tsevener moved this task from Doing to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Actually moving this to blocked, since we still need an icon.

Tsevener moved this task from Waiting for Build to Blocked or Waiting on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Aug 1 2024, 3:10 PM

@Tsevener Robin is out until Monday, let's move the addition of the icon into the follow-up task T370327: [L] Modal sheet: Add image and link button, bottom copy/warning and counter, guidance button

Tsevener moved this task from Blocked or Waiting to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Aug 1 2024, 9:31 PM

Tsevener moved this task from Waiting for Build to Design signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

HNordeenWMF raised the priority of this task from Low to Medium.Aug 1 2024, 9:33 PM

In T370232#10028171, @Mazevedo wrote:

Hi @scblr! Here on the modal header, the icon used is the SFSymbol named "accessibility." However, per Apple's guidelines, it "may only be used to refer to Apple's Accessibility features," so we can't use it here in this context.
Could we have an alternative to replace this icon?

Great catch @Mazevedo; I suggest leaving out the icon completely:

Figma

It’s more calm, anyway.

FYI @HNordeenWMF – I also updated T370327.

scblr updated the task description. (Show Details)Aug 5 2024, 12:55 PM

Mazevedo renamed this task from [S] Create modal sheet, next button and text field for Alt text MTV to [S] Create modal sheet, next button and text field for Alt text MTV - flow B.Aug 5 2024, 3:53 PM

Mazevedo mentioned this in T371829: Create modal sheet, next button and text field for Alt text MTV - flow C.

Mazevedo updated the task description. (Show Details)

Thanks @scblr! We'll update it in T370327

scblr updated the task description. (Show Details)Aug 6 2024, 12:11 PM

Hey @Mazevedo 👋

I saw this note in the task’s description:

NOTE: Task is not intended to match designs fully, follow-up task T370327 will add image and link button, bottom copy/warning and counter, and guidance button

And it currently looks like this:

CleanShot 2024-08-06 at 14.13.00@2x.png (2×932 px, 565 KB)

So, I guess this is more or less how it’s intended.

However, I left a few notes regarding bugs/behavior in T370231#10044735 that also affect this one.

scblr moved this task from Design signoff to Ready for Development on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Aug 6 2024, 12:25 PM

Mazevedo moved this task from Ready for Development to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Aug 6 2024, 3:04 PM

Mazevedo mentioned this in T371908: QA tasks for flow C.Aug 6 2024, 3:41 PM

Tsevener claimed this task.Aug 6 2024, 4:02 PM

Tsevener moved this task from Waiting for Build to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Keyboard bug fix: https://github.com/wikimedia/wikipedia-ios/pull/4917

Tsevener moved this task from Needs Code Review to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Aug 7 2024, 3:14 PM

Tsevener removed Tsevener as the assignee of this task.Aug 7 2024, 3:58 PM

Tsevener moved this task from Waiting for Build to Needs QA signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Tsevener mentioned this in T372657: Release 7.5.7.Aug 16 2024, 5:07 PM

Tsevener mentioned this in T372096: Release 7.5.7.

Working for me on 7.5.8 (3979)

HNordeenWMF moved this task from Ready for PM Signoff to Ready for Release on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Aug 30 2024, 5:29 PM

HNordeenWMF closed this task as Resolved.Sep 5 2024, 11:30 PM

	F57119504: CleanShot 2024-08-06 at 14.13.00@2x.png
	Aug 6 2024, 12:24 PM

	F56788514: Screenshot 2024-07-30 at 11.47.39.png
	Jul 30 2024, 2:51 PM

	F57069422: image.png
	Aug 5 2024, 12:54 PM

[S] Create modal sheet, next button and text field for Alt text MTV - flow BClosed, ResolvedPublicActions