Page MenuHomePhabricator

In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them in Firefox
Closed, ResolvedPublic8 Story Points

Description

This is related to bug 61289.

When you open a template that contains a lot of data, you should already be able to read everything in the full, expanded boxes. If thhe data takes four lines to display in the box, then you should see all four lines immediately, Uou should not get template parameter boxes that are 1.5 lines tall until you click inside the box.


Version: unspecified
Severity: minor

Details

Reference
bz62084

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz62084.

Fixed by gerrit 116669.

I am afraid this is still not happening in Firefox.
As Fram pointed out, "Example: Contra (album) [https://en.wikipedia.org/wiki/Contra_(album)?veaction=edit ], go to the "professional ratings", and explore. Parameters "rev10score" or "rev2score" do not indicate that a second line follows: parameters "rev3score" and "rev5score" give a sudden scrollbar when you click in them, because they are longer than 2 lines."

Ruddy Firefox bugs.

Jdforrester-WMF renamed this task from VisualEditor: In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them to In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them in Firefox.
Jdforrester-WMF set Security to None.
Jdforrester-WMF added a subscriber: TrevorParscal.
Jdforrester-WMF lowered the priority of this task from High to Normal.Jan 15 2015, 12:21 AM

Doesn't appear fixed. In fact, the parameters don't seem to expand at all, and do not have vertical scrollbars.

The underlying issue is that Firefox does not support the DOMNodeInsertedIntoDocument event, which we rely on to do the initial size adjustment. The event is actually deprecated, and we're planning to replace it with something else (T64174), so I'll mark that as another blocker.

Jdforrester-WMF changed the task status from Open to Stalled.Mar 2 2015, 4:35 AM
matmarex claimed this task.Mar 3 2015, 7:27 PM

Change 194197 had a related patch set uploaded (by Bartosz Dziewoński):
TextInputWidget: Use MutationObserver for #onElementAttach support

https://gerrit.wikimedia.org/r/194197

Jdforrester-WMF moved this task from Freezer to Blocked on the VisualEditor board.Mar 10 2015, 5:43 PM

Change 194197 merged by jenkins-bot:
TextInputWidget: Use MutationObserver for #onElementAttach support

https://gerrit.wikimedia.org/r/194197

Jdforrester-WMF moved this task from Blocked to Q4 on the VisualEditor board.Mar 15 2015, 3:20 AM

Verified the fix in betalabs - FF 35.