Page MenuHomePhabricator

ULS: Fix "JQMIGRATE: jQuery.fn.attr('selected')" in ext.uls.displaysettings.js
Closed, ResolvedPublic

Description

For dynamic state always use properties. Attributes are for the DOM, not for the live display. Older versions of jQuery used to cover this common mistake by setting the property in addition to the attribute when setting the attribute, but this has all sorts of nasty side-effects. Use prop('selected', value) instead for this, and pass it a boolean true/false value (so not "" or "selected").


Version: unspecified
Severity: major

Details

Reference
bz68998

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:27 AM
bzimport set Reference to bz68998.
Krinkle created this task.Aug 1 2014, 11:10 AM

Change 156092 had a related patch set uploaded by Santhosh:
Use prop instead of attr for changing 'selected' state

https://gerrit.wikimedia.org/r/156092

Change 156092 merged by jenkins-bot:
Use prop instead of attr for changing 'selected' state

https://gerrit.wikimedia.org/r/156092