Page MenuHomePhabricator

Flow: Topic history page doesn't reflect action in h1 heading or <title> tag
Open, MediumPublic

Description

The h1 heading just says "Topic on Talk:<Flow board name>", the same title as viewing the Topic itself.

It should be something like

"History of Topic on Talk:<Flow board name>"

or it could be

"History of Topic <topic title> on Talk:<Flow board name>"

The latter
+ Is more useful.

  • Doesn't match the Topic page heading (which doesn't include the topic title because it's repeated in the topic titlebar immediately below).
  • Contains two titles so is very likely to run onto many lines.

Meanwhile the HTML <title> tag is just the topic title. It lacks "History of Topic" in front and the usual " - <name of wiki/tagline of wiki>" that OutputPage:setTitle() gives normal pages when it calls setHTMLTitle() wit the 'pagetitle' message key.

Other pages for Flow actions such as viewing a diff also lack an indication of the action in the h1 heading and <title>. If we can get the principle right for one topic action, we can probably get it right for all.


Version: master
Severity: normal
URL: http://en.wikipedia.beta.wmflabs.org/wiki/Topic:Ryonek22pexo6sr8?action=history

Details

Reference
bz70472

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:53 AM
bzimport set Reference to bz70472.
bzimport added a subscriber: Unknown Object (MLST).
Spage created this task.Sep 6 2014, 2:37 AM
Mattflaschen-WMF triaged this task as Medium priority.Dec 11 2014, 5:03 AM
Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:25 AM
Adishaporwal added a subscriber: Adishaporwal.EditedAug 27 2015, 7:08 PM

Hey,
I am new to open source contribution and want to resolve the bug . I have following queries regarding it:
In this I have to change the heading and title of page. Anything else I need to do?

Please suggest me with how should I proceed?

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptAug 27 2015, 7:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Adishaporwal set Security to None.

@DannyH suggested (analogous to the message used for regular pages):

Revision history of Topic on $1

The $1 parameter should be the full board name, e.g. Talk:Flow.

I think this should be used for both the document title and the <h1>.

dg711 added a subscriber: dg711.Jan 11 2016, 7:26 PM
dg711 added a comment.Jan 13 2016, 6:18 PM

Can this get assigned to me? Its been quite a time the assignee has claimed this task . I'd like to patch on this one.

Catrope reassigned this task from Adishaporwal to dg711.Jan 13 2016, 6:45 PM
Catrope added a subscriber: Catrope.
DannyH removed a subscriber: DannyH.Jan 15 2016, 11:02 PM
dg711 added a comment.Jan 17 2016, 2:48 AM

HI , which repo should I browse the code exactly in. I've installed and run mediawiki on my local machine both manually as well as with mediawiki-vagrant . They render the regular pages for revision history .How do I switch to the wikipedia 'variant/role' to recreate the situation as mentioned the in the description on my local installation ?

Sn1per added a subscriber: Sn1per.Jan 17 2016, 4:10 AM

This is a StructuredDiscussions task, so you would need to enable the 'flow' vagrant role. Once you do that and then vagrant provision, Flow should be cloned into extensions/Flow under the mediawiki directory, and that is where you will need to make changes.

dg711 added a comment.Jan 20 2016, 6:16 AM

My vagrant installation always return either the "stack overflow" or "503 service unavailable error" whenever I request 127.0.0.1:8080 . I;ve wasted 3 nights straight for this frustating conclusion .
I've cloned it as "git clone --recursive ssh://dg7@gerrit.wikimedia.org:29418/mediawiki/vagrant " now .
It worked fine for once when I initially installed it by cloning "git clone --recursive https:gerrit.wikimedia.org/mediawiki/vagrant " , But I wouldn't have the commit access with that clone .

Should I just go with manual installation ?

My vagrant installation always return either the "stack overflow" or "503 service unavailable error" whenever I request 127.0.0.1:8080 . I;ve wasted 3 nights straight for this frustating conclusion .
I've cloned it as "git clone --recursive ssh://dg7@gerrit.wikimedia.org:29418/mediawiki/vagrant " now .
It worked fine for once when I initially installed it by cloning "git clone --recursive https:gerrit.wikimedia.org/mediawiki/vagrant " , But I wouldn't have the commit access with that clone .

Sorry it's not working yet.

You can change the URL of an existing clone with:

git remote set-url origin ssh://dg7@gerrit.wikimedia.org:29418/mediawiki/vagrant.git

Run:

PUPPET_DEBUG=true vagrant provision|tee debug_output.log

then post the debug_output.log.

Also post a screenshot of the error you see in the browser.

Should I just go with manual installation ?

That's an option, if you're familiar with LAMP steps. Some members of our team do that, but you will not be able to pick up Vagrant fixes and troubleshooting might be more difficult (or not).

dg711 added a comment.Jan 22 2016, 9:57 PM

Well, I use windows actually , so its WAMP for me . Should have switched to linux earlier :/

I'll give a few more attempts ASAP I get sufficient time .

Well, I use windows actually , so its WAMP for me . Should have switched to linux earlier :/

Oh. MediaWiki-Vagrant is not well tested on Windows hosts (though we would still like it to work).

So, I started from the scratch to avoid any error caused by myself earlier . Cloned it as -> ssh://dg7@gerrit.wikimedia.org:29418/mediawiki/vagrant.git

Now ,on vagrant up , it clones the mediawiki as well as other repositories via https only ,i.e, https://gerrit.wikimedia.org/r/p/mediawiki/core.git ( no commit access) .
How should I go about it ?

the log gives the following message at last : The SSH command responded with a non-zero exit status ........

The code loads on requesting 127.0.0.1:8080 , The only problem presently is with this SSH issue .

So, it runs like this with just monobook role enabled .
The screenshot :

Now, when I enabled and provisioned for "Flow" role along with monobook , it all broke when I executed "vagrant reload".
screenshot :


log ( provision ) : https://dpaste.de/kO0W
log( reload ) : https://dpaste.de/ePbW

Both pastes are 404 now.

Use https://phabricator.wikimedia.org/paste/create/ (still separate paste for each) so they don't disappear.

Tgr added a subscriber: Tgr.Jan 26 2016, 11:55 PM

The relevant parts are

==> default: Notice: /Stage[main]/Role::Echo/Mysql::Sql[create echo_unread_wikis]/Exec[create echo_unread_wikis]/returns: ERROR at line 1: Failed to open file '/vagrant/mediawiki/extensions/Echo/db_patches/echo_unread_wikis.sql', error: 2
==> default: Error: /Stage[main]/Role::Echo/Mysql::Sql[create echo_unread_wikis]/Exec[create echo_unread_wikis]/returns: change from notrun to 0 failed: /usr/bin/mysql -uroot -pvagrant -qfsAe "USE wikishared; SOURCE /vagrant/mediawiki/extensions/Echo/db_patches/echo_unread_wikis.sql;" returned 1 instead of one of [0]

and (redacted)

Loading composer repositories with package information
Installing dependencies (including require-dev)
  - Installing squizlabs/php_codesniffer (2.5.0)
    Cloning e4fb41d5d0387d556e2c25534d630b3cce90ea67
    Failed to download squizlabs/php_codesniffer from source: The process "git clone --no-checkout 'git://github.com/squizlabs/PHP_CodeSniffer.git' '/vagrant/mediawiki/extensions/SyntaxHighlight_GeSHi/vendor/squizlabs/php_codesniffer' && cd '/vagrant/mediawiki/extensions/SyntaxHighlight_GeSHi/vendor/squizlabs/php_codesniffer' && git remote add composer 'git://github.com/squizlabs/PHP_CodeSniffer.git' && git fetch composer" exceeded the timeout of 300 seconds.
    Now trying to download from dist
  - Installing squizlabs/php_codesniffer (2.5.0)
  [RuntimeException]                                                                                                                         
  Could not delete 
==> default: Error: /Stage[main]/Role::Geshi/Mediawiki::Extension[SyntaxHighlight_GeSHi]/Php::Composer::Install[/vagrant/mediawiki/extensions/SyntaxHighlight_GeSHi]/Exec[composer-install--vagrant-mediawiki-extensions-SyntaxHighlight_GeSHi]/returns: change from notrun to 0 failed: /usr/local/bin/composer install --optimize-autoloader --prefer-source returned 1 instead of one of [0]

The first is an echo bug, the second maybe a combination of a network issue and a vagrant file permissions issue? You might have to run Composer manually to clean up.

In T72472#1968112, @Tgr wrote:

The first is an echo bug, the second maybe a combination of a network issue and a vagrant file permissions issue? You might have to run Composer manually to clean up.

It doesn't seem like an Echo bug per se to me. It seems like you don't have db_patches/echo_unread_wikis.sql (which is in Echo master) for some reason. Try updating Echo to latest master before trying again. This worked for other people.

dg711 added a comment.EditedJan 28 2016, 12:35 AM

It doesn't seem like an Echo bug per se to me. It seems like you don't have db_patches/echo_unread_wikis.sql (which is in Echo master) for some reason. Try updating Echo to latest master before trying again. This worked for other people.

So , should I just have to rebase my local repo now ?

I did a "git rebase.." and "vagrant up" with flow role enabled and it worked somehow . But , I didn't find any effect of Flow .
I checked the LocalSettings.php in vagrant/mediawiki/ repo and couldn't find any

require_once "$IP/extensions/Flow/Flow.php";

So, do I have make these changes manually ? Or was Vagrant supposed to do that ?

So, do I have make these changes manually ? Or was Vagrant supposed to do that ?

Flow should be working, and settings.d/puppet-managed/20-Flow.php should have been automatically created.

The easiest way to test Flow out of the box is to go to Flow_test:Whatever or Flow_test_talk:Whatever (any page name in those namespaces works).

You can also (as Admin) use Special:EnableFlow to enable Flow on absolutely any page.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptAug 3 2016, 4:30 PM

@dg711: This issue has been assigned to you a while ago.
Could you please share a status update? Are you still working (or still plan to work) on this issue? Is there anything that others could help with? If you do not plan to work on this issue anymore, please remove yourself as assignee (via Add Action...Assign / Claim in the dropdown menu) so others could work on it. Thanks a lot!

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 18 2018, 7:00 PM
SBisson moved this task from Inbox to Triaged but Future on the Growth-Team board.Jul 20 2018, 5:58 PM
Aklapper removed dg711 as the assignee of this task.Nov 29 2019, 8:40 AM

Is this issue still open? Can I work on it?

kostajh added a subscriber: kostajh.Feb 6 2020, 1:37 PM

@Swayamsrk it's open, but it's not a high priority item and Flow is in maintenance mode, so I would maybe look for a different task to work on.