Flagged Revisions doesn't mark as reviewed the latest version after Visual Editor edit
Open, MediumPublic8 Estimated Story Points
Actions

Assigned To

None

Authored By

	Stryn
	Nov 8 2014, 1:25 PM

Description

Flagged Revisions doesn't mark as reviewed an edit (to unreviewed page) made using Visual Editor if the page hasn't been updated after the edit.

How to reproduce:

go to some article that hasn't been reviewed yet
make an edit to the article using Visual Editor
review the article
when you look at the article history you can see that the article you marked as reviewed has one unreviewed change (the one you just did using VE)

Version: unspecified
Severity: normal

Mentioned In: T341295: Make VE reload the whole page after saving when FlaggedRevs is active and the edit requires review
T78691: FlaggedRevisions icon "Non sighted" shown after saving even that editor has autoreview right

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:59 AM

• bzimport set Reference to bz73171.

• bzimport added a subscriber: Unknown Object (MLST).

Stryn set Security to None.

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Is this still an issue?

In T75171#1471012, @Jdforrester-WMF wrote:

Is this still an issue?

We're not updating the mw-fr-input-oldid hidden input in the FlaggedRevs page review form when we update the page contents.

But if you try to change it, you get "Invalid inclusion parameter key".
That key is actually a hash of several things (including the oldid): https://github.com/wikimedia/mediawiki-extensions-FlaggedRevs/blob/master/business/RevisionReviewForm.php#L211-L213
We'd need to regenerate it somehow I guess...