Page MenuHomePhabricator
Create Task
Maniphest T75171

When making a VisualEditor edit then marking the page as reviewed, the VisualEditor edit does not get marked reviewed
Open, MediumPublic8 Estimated Story PointsBUG REPORT
Actions

Description

After editing an unreviewed page using VisualEditor, reviewing the page doesn’t review the just-made edit if the page isn’t reloaded between publishing the edit and pressing review.

How to reproduce:

  1. go to some article that hasn't been reviewed yet
  2. make an edit to the article using Visual Editor. save the edit
  3. review the article
  4. when you look at the article history you can see that the article you marked as reviewed has one unreviewed change (the one you just did using VE)

I tried this at https://test2.wikipedia.org/wiki/Testing_something

Details

Reference
bz73171

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:59 AM
• bzimport added a project: FlaggedRevs.
• bzimport set Reference to bz73171.
• bzimport added a subscriber: Unknown Object (MLST).
Stryn created this task.Nov 8 2014, 1:25 PM
Stryn added a project: VisualEditor-MediaWiki.Jul 22 2015, 2:01 PM
Stryn set Security to None.
Restricted Application added a project: VisualEditor. · View Herald TranscriptJul 22 2015, 2:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF mentioned this in T78691: FlaggedRevisions icon "Non sighted" shown after saving even that editor has autoreview right .Jul 22 2015, 3:56 PM
Jdforrester-WMF subscribed.Jul 22 2015, 4:05 PM

Is this still an issue?

Stryn added a comment.Jul 22 2015, 4:44 PM
In T75171#1471012, @Jdforrester-WMF wrote:

Is this still an issue?

It is. Just tested it again at https://test2.wikipedia.org/wiki/Testing_something

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Jul 28 2015, 7:19 PM
Krenair subscribed.EditedJul 29 2015, 12:18 AM

We're not updating the mw-fr-input-oldid hidden input in the FlaggedRevs page review form when we update the page contents.

Krenair added a comment.Jul 29 2015, 12:33 AM

But if you try to change it, you get "Invalid inclusion parameter key".
That key is actually a hash of several things (including the oldid): https://github.com/wikimedia/mediawiki-extensions-FlaggedRevs/blob/master/business/RevisionReviewForm.php#L211-L213
We'd need to regenerate it somehow I guess...

Jdforrester-WMF edited a custom field.Jul 31 2015, 11:21 PM
Jdforrester-WMF moved this task from TR1: Releases to TR0: Interrupt on the VisualEditor board.Aug 26 2015, 1:36 AM
• AlexMonk-WMF subscribed.Feb 23 2016, 7:46 PM
• AlexMonk-WMF removed a subscriber: Krenair.Feb 23 2016, 7:49 PM
• Elitre subscribed.May 11 2016, 3:48 AM
Troubled.asset subscribed.May 13 2016, 6:43 PM
JTannerWMF moved this task from TR0: Interrupt to Freezer on the VisualEditor board.Nov 13 2018, 3:12 PM
matmarex mentioned this in T341295: Make VE reload the whole page after saving when FlaggedRevs is active and the edit requires review.Jul 6 2023, 9:40 PM
Johannnes89 subscribed.May 19 2024, 7:31 PM
Wargo subscribed.Nov 13 2024, 11:55 PM

If this is still issue, add more details.

Tacsipacsi renamed this task from Flagged Revisions doesn't mark as reviewed the latest version after Visual Editor edit to After a VisualEditor edit, reviewing the page reviews the last-but-one revision.Nov 16 2024, 4:35 PM
Tacsipacsi updated the task description. (Show Details)
Tacsipacsi changed the subtype of this task from "Task" to "Bug Report".
Tacsipacsi subscribed.

I tried to rephrase the description to be easier to understand (I hope I understood it correctly). However, when I tried to reproduce it on test2wiki, I couldn’t – when I opened VisualEditor, the FlaggedRevs interface disappeared, and when I published the edit, it didn’t come back, so there was no button that could have worked incorrectly. Well that’s also a way to fix this bug…

Novem_Linguae renamed this task from After a VisualEditor edit, reviewing the page reviews the last-but-one revision to When making a VisualEditor edit then marking the page as reviewed, the VisualEditor edit does not get marked reviewed.Nov 17 2024, 12:47 AM
Novem_Linguae updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits