Page MenuHomePhabricator
Create Task
Maniphest T75482

[Story] Make Wikibase add coordinates to GeoData on wikidata.org
Closed, ResolvedPublic
Actions

Description

[Please add some description]

Details

Reference
bz73482
SubjectRepoBranchLines +/-
Add geodata to parser outputmediawiki/extensions/Wikibasemaster+505 -3
Add GeoData and PageImages configuration for Wikibase repo wikisoperations/mediawiki-configmaster+59 -1
Register Wikibase coordinates as GeoData in ParserOutput [WIP]mediawiki/extensions/GeoDatamaster+95 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:46 AM
• bzimport added a project: MediaWiki-extensions-WikibaseRepository.
• bzimport set Reference to bz73482.
• bzimport added a subscriber: Unknown Object (MLST).
hoo created this task.Nov 16 2014, 10:27 AM
Lydia_Pintscher added a project: Wikidata.Dec 1 2014, 2:27 PM
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).Dec 1 2014, 2:34 PM
Lydia_Pintscher mentioned this in T35704: GeoData should pull coordinates from Wikidata on sites with the Wikibase Client.Dec 27 2014, 5:18 PM
Multichill renamed this task from Make Wikibase add coordinates to GeoData to Make Wikibase add coordinates to GeoData on wikidata.org.Dec 27 2014, 6:43 PM
Multichill updated the task description. (Show Details)
Multichill set Security to None.
Multichill added a comment.Dec 27 2014, 6:46 PM

Updated both bugs to make the distinction. This bug is to get https://www.wikidata.org/wiki/Special:Nearby to work based on data in Wikidata. The other bug is for sites like the Hebrew Wikipedia where the extension should pull data from Wikidata.

Lydia_Pintscher moved this task from incoming to needs discussion or investigation on the Wikidata board.Dec 27 2014, 7:46 PM
Sjoerddebruin awarded a token.Jun 1 2015, 5:26 PM
Sjoerddebruin subscribed.
Ricordisamoa subscribed.Jun 13 2015, 11:58 PM
Nemo_bis added a parent task: T35704: GeoData should pull coordinates from Wikidata on sites with the Wikibase Client.Sep 29 2015, 6:27 AM
Nemo_bis added a parent task: T112866: [Story] Add Wikibase integration with GeoData extension.Sep 29 2015, 6:53 AM
aude claimed this task.Sep 29 2015, 6:55 AM
aude mentioned this in T112866: [Story] Add Wikibase integration with GeoData extension.
aude merged a task: T112866: [Story] Add Wikibase integration with GeoData extension.
aude updated the task description. (Show Details)
aude added a project: Wikidata-Sprint-2015-09-29.
aude added a parent task: T112531: [Story] see items around me (Special:Nearby).
aude added subscribers: Nemo_bis, Aklapper.
aude added a project: GeoData.Sep 29 2015, 6:57 AM
aude moved this task from Proposed to Doing on the Wikidata-Sprint-2015-09-29 board.Sep 29 2015, 7:03 AM
aude added a subtask: T114092: Add tests for GeoData hooks handling.Sep 29 2015, 10:12 AM
Lydia_Pintscher moved this task from needs discussion or investigation to in progress on the Wikidata board.Sep 29 2015, 3:27 PM
aude added a subtask: T114220: [Task] Add hook or mechanism in Wikibase for other extensions to register additional extension data in ParserOutput.Sep 30 2015, 9:42 AM
gerritbot subscribed.Oct 5 2015, 7:15 AM

Change 243158 had a related patch set uploaded (by Aude):
Register Wikibase coordinates as GeoData in ParserOutput [WIP]

https://gerrit.wikimedia.org/r/243158

gerritbot added a project: Patch-For-Review.Oct 5 2015, 7:15 AM
gerritbot added a comment.Oct 5 2015, 9:59 AM

Change 243158 abandoned by Aude:
Register Wikibase coordinates as GeoData in ParserOutput [WIP]

Reason:
in favor of If4ec903 in Wikibase

https://gerrit.wikimedia.org/r/243158

aude added a comment.EditedOct 8 2015, 6:34 PM

after talking with MaxSem, we also need to set a type for each coordinate, if possible and set the dimension field also, if possible.

type could generally come from P31 (instanceof)

dimension could be based on area and length properties

Lydia_Pintscher added a comment.Oct 12 2015, 12:51 PM

New patch at https://gerrit.wikimedia.org/r/#/c/243625/

Lydia_Pintscher moved this task from Doing to Review on the Wikidata-Sprint-2015-09-29 board.Oct 12 2015, 12:54 PM
gerritbot added a comment.Oct 12 2015, 2:19 PM

Change 244165 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Add pageImagesPropertyIds configuration for Wikibase servers

https://gerrit.wikimedia.org/r/244165

gerritbot added a comment.Oct 12 2015, 3:16 PM

Change 244165 merged by jenkins-bot:
Add GeoData and PageImages configuration for Wikibase repo wikis

https://gerrit.wikimedia.org/r/244165

thiemowmde mentioned this in T114868: [Task] create script to populate data for Special:Nearby.Oct 12 2015, 3:57 PM
Multichill added a comment.Oct 12 2015, 7:06 PM
In T75482#1713211, @aude wrote:

after talking with MaxSem, we also need to set a type for each coordinate, if possible and set the dimension field also, if possible.

type could generally come from P31 (instanceof)

dimension could be based on area property

Do you want to have the fixed types listed at https://www.mediawiki.org/wiki/Extension:GeoData#Parser_function or be more flexible?

Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-10-13.Oct 13 2015, 12:34 PM
Tobi_WMDE_SW moved this task from Proposed to Review on the Wikidata-Sprint-2015-10-13 board.
JanZerebecki added a parent task: T115325: [Task] run refreshLinks on wikidatawiki.Oct 13 2015, 1:29 PM
• Jonas renamed this task from Make Wikibase add coordinates to GeoData on wikidata.org to [Story] Make Wikibase add coordinates to GeoData on wikidata.org.Oct 13 2015, 6:07 PM
• Jonas updated the task description. (Show Details)
• Jonas added a project: Story.
gerritbot added a comment.Oct 13 2015, 7:03 PM

Change 243625 merged by jenkins-bot:
Add geodata to parser output

https://gerrit.wikimedia.org/r/243625

JanZerebecki subscribed.Oct 13 2015, 7:13 PM

Is GeoData type used for anything besides showing the type in Geohack and as a way to get a better default when dim is not set?
Setting the dim for something from Wikidata has quite a few more ways, the uncomplicated way would be having a property we can directly use for it, but not doing any guessing when it is not there.

MaxSem added a comment.Oct 13 2015, 9:43 PM

GeoHack does not use GeoData. "not doing any guessing when it is not there" is bad, unless a page with coordinates but without a dim is an exception rather than a rule.

daniel removed a subtask: T114220: [Task] Add hook or mechanism in Wikibase for other extensions to register additional extension data in ParserOutput.Oct 14 2015, 3:35 PM
JanZerebecki added a comment.Oct 14 2015, 4:24 PM

For what else is the GeoData type used, than guessing dimension?

JanZerebecki removed a parent task: T115325: [Task] run refreshLinks on wikidatawiki.Oct 14 2015, 4:27 PM
Tobi_WMDE_SW moved this task from Review to Done on the Wikidata-Sprint-2015-10-13 board.Oct 15 2015, 8:33 AM
aude added a comment.Oct 15 2015, 10:02 AM

@Multichill @MaxSem @JanZerebecki we now have specific task for adding type for Wikibase coordinates and I commented there more how I thought we can handle it:

T115481#1727575

aude added a comment.Oct 15 2015, 10:03 AM

@JanZerebecki type would potentially be used as a consideration for filtering and rendering map features at various zoom levels

JanZerebecki mentioned this in T115481: [Task] Set type parameter for GeoData coordinates in Wikibase.Oct 15 2015, 11:36 AM
JanZerebecki mentioned this in T115480: [Task] Set dim parameter for GeoData coordinates in Wikibase.Oct 16 2015, 10:08 PM
Multichill added a comment.Oct 29 2015, 8:50 PM

https://www.wikidata.org/wiki/Special:Nearby shows Geodata :-D

Thanks Katie for resolving this. Announced in https://www.wikidata.org/w/index.php?title=Wikidata:Project_chat&diff=264532244&oldid=264530469

aude closed this task as Resolved.Oct 29 2015, 10:46 PM
aude closed subtask T115482: [Task] Enable GeoData extension on wikidata.org as Resolved.
aude removed a project: Patch-For-Review.
simon04 mentioned this in T141080: Wikidata items with two coordinates do not show up in geosearch.Jul 22 2016, 8:46 AM
Restricted Application added a subscriber: PokestarFan. · View Herald TranscriptJul 26 2017, 11:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL