Page MenuHomePhabricator

Quoting shouldn't readd me to a task I've unsubscribed from
Open, LowestPublic

Description

As a phabricator user who follows notifications, I want to be able to unsubscribe from reports which I do *not* want to follow, without being re-added unless considered necessary by a human, so that my notifications contain what's relevant for me.

What happens instead: I remove myself from a task https://phabricator.wikimedia.org/T76356#823765 and a mere reply adds me again https://phabricator.wikimedia.org/T76356#823886
Search helper: subscribe subscribes subscribed unsubscribes unsubscribed unsubscribe mention mentioned mentions auto-subscribe auto-subscribes auto-subscribed re-added re-add re-subscribe re-subscribed re-subscribes insufficiently magical insufficient magic


See Also:
T96464: Upon edit, a task description which mentions a Phab user (re)adds that Phab user to CC/Subscribers field
T109359: @mentions add subscribers even if they were explicitly unsubscribed already

Event Timeline

Nemo_bis created this task.Dec 8 2014, 8:11 AM
Nemo_bis raised the priority of this task from to Needs Triage.
Nemo_bis updated the task description. (Show Details)
Nemo_bis added a project: Phabricator.
Nemo_bis changed Security from none to None.
Nemo_bis updated the task description. (Show Details)
Nemo_bis added a subscriber: Nemo_bis.

A mere reply... to a comment you made. Isn't it reasonable to expect that the commenter wants you to know?

In the line above, change "you" by just any Phabricator user, because users like Nemo_bis are not representative. :)

Qgil triaged this task as Lowest priority.Dec 8 2014, 10:37 AM
Qgil edited projects, added Phabricator (Upstream); removed Phabricator.
Qgil moved this task from Backlog to Need Discussion on the Phabricator (Upstream) board.
In T76993#824543, @Qgil wrote:

A mere reply... to a comment you made. Isn't it reasonable to expect that the commenter wants you to know?

Not when the quoted user has refused to follow the task.

In the line above, change "you" by just any Phabricator user, because users like Nemo_bis are not representative. :)

Most users don't follow notifications and/or don't remove self from subscribers, so I think the user story sufficiently restricted the target audience. :)

Should we merge this task and T78468 into a request not to CC users automatically when they are "just" quoted?

Should we merge this task and T78468 into a request not to CC users automatically when they are "just" quoted?

That would also work. Whatever is easiest to get implemented.

Nemo_bis updated the task description. (Show Details)Aug 17 2015, 8:07 PM
dr0ptp4kt added a subscriber: dr0ptp4kt.EditedNov 12 2015, 7:30 PM

I don't myself have a problem with being re-added to the CC if I'm

@mention'd

in a late Comment (I would rather know that I've been quoted so I can re-enter the conversation to clarify if necessary). But If I've intentionally removed my

@handle

from the Description (if it was there in the first place) and I've un-CC'd myself, I don't want to be bothered with an email again until a new Comment is added where my

@handle``
 is explicitly included (or if someone re-adds it to the Description).

I don't myself have a problem with being re-added to the CC if I'm

@mention'd

in a later post. But If I've intentionally removed my

@handle

from the Description (if it was there in the first place) and I've un-CC'd myself, I don't want to be bothered again until a new Comment is added (or the Description is updated) where my

@handle

is explicitly included.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMay 23 2016, 6:04 PM
epriestley updated the task description. (Show Details)May 25 2016, 4:36 PM
MZMcBride updated the task description. (Show Details)Aug 14 2016, 11:00 AM
Danny_B updated the task description. (Show Details)Aug 14 2016, 11:07 AM

Over at https://secure.phabricator.com/T11471#190152, @epriestley writes:

If you don't like the @mention-implies-CC behavior, you can disable it by applying this patch to your install:

diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
index 1a3dd1c..16c08cd 100644
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
@@ -1367,6 +1367,9 @@ abstract class PhabricatorApplicationTransactionEditor
     array $xactions,
     array $changes) {
+    // Do not subscribe @mention'd users.
+    return null;
+
     if (!($object instanceof PhabricatorSubscribableInterface)) {
       return null;
     }

We've only seen negative feedback about this behavior from one install, but use it frequently on this install and believe it is a useful feature overall, even if it isn't always perfect. As a general rule, we don't make upstream changes which only benefit one install. But if this feature is unusually disruptive on your install, the cost of maintaining that patch might be smaller than the cost of having the feature.

Nemo_bis updated the task description. (Show Details)Aug 18 2016, 12:11 PM
Johnywhy added a subscriber: Johnywhy.EditedMay 30 2018, 7:54 AM
In T76993#824543, @Qgil wrote:

A mere reply... to a comment you made. Isn't it reasonable to expect that the commenter wants you to know?

No doubt. But if I unsubscribe myself, then it's reasonable to respect my desire NOT to be notified. Even if I'm mentioned.

Ideally there should be a config option: "Don't allow others to re-subscribe me." I've seen that on other systems.