Error: Module not found: toast Error: Module not found: toast
Doh.
It should appear on https://en.m.wikipedia.org/wiki/Special:MobileDiff/589569887 but isn't.
Description
Description
Details
Details
Customize query in gerrit
Related Objects
Related Objects
- Mentioned In
- rMEXT69a573ca44d9: Updated mediawiki/extensions Project: mediawiki/extensions/Thanks…
rMEXT0882d8885e77: Updated mediawiki/extensions Project: mediawiki/extensions/Thanks…
rETHA4b83a38928f9: Mobile: Conform to new LoggingSchema
rETHA62801e2b3ebf: Mobile: Conform to new LoggingSchema
rETHA7a3d154447f3: Mobile: Conform to new LoggingSchema
T71804: Thanks: add instrumentation to Thanks
T61207: Thanks given via mobile are not shown on desktop history page
rETHAe9942dc9685b: Make sure, that toast is loaded for Thanks notifications
T63737: Thank notification on mobile should support click to undo - Mentioned Here
- T86687: Thanks is broken again (Mobile Thanks needs qunit tests)
Event Timeline
Comment Actions
Note 1: ^ that task (T63737) is asking for Thank links to either have a confirmation step, or to be removed, from the mobile history pages.
Note 2: The example link (https://en.m.wikipedia.org/wiki/Special:MobileDiff/589569887) does display a Thank button, when viewed on my desktop, but it doesn't display on my phone.
Comment Actions
Change 178471 had a related patch set uploaded (by Florianschmidtwelzow):
Make sure, that toast is loaded for Thanks notifications
Comment Actions
Change 178558 had a related patch set uploaded (by Florianschmidtwelzow):
Make sure, that toast is loaded for Thanks notifications
Comment Actions
Change 178471 abandoned by Florianschmidtwelzow:
Make sure, that toast is loaded for Thanks notifications
Reason:
I0fa25512ef4be21855b0f83a4670e8291657e3e4
Comment Actions
Change 178558 merged by jenkins-bot:
Make sure, that toast is loaded for Thanks notifications
Comment Actions
Although I can see the Thanks button here: https://m.mediawiki.org/wiki/Special:MobileDiff/1319901
The button that previously worked is still not visible for me on Firefox or Chrome beta browsers on Android (experimental mode both). Clicking items from the mobile watchlist send me to diffs with no Thanks (in fact with Chrome I don't even see the author; Firefox does show it).
Comment Actions
@Qgil: Hmm, can't reproduce on mediawiki.org, alpha and firefox :/ I see the thanks button (and the author) when i click on an item in the watchlist. Have you an example link where you don't see the thanks button? Are there any JavaScript errors in your console (Crtl + J)?
Comment Actions
https://ca.m.wikipedia.org/wiki/Especial:MobileDiff/14464985 seen in Firefox Mobile for Android (Experimental mode)
Same page seen from Firefox browser for Debian (Iceweasel)
"JQMIGRATE: Logging is active" load.php:150 "Exception thrown by ext.thanks.mobilediff" load.php:161 "Error: Module not found: toast" Error: Module not found: toast Stack trace: [object Object]
Same page seen from Chrome for Debian
load.php?debug=false&lang=ca&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20141210T…:150 JQMIGRATE: Logging is active load.php?debug=false&lang=ca&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20141210T…:161 Exception thrown by ext.thanks.mobilediff load.php?debug=false&lang=ca&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20141210T…:161 Error: Module not found: toast Error: Module not found: toastload.php?debug=false&lang=ca&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20141210T…:161 log
All three consistent: no Thanks button.
https://m.mediawiki.org/wiki/Special:MobileDiff/1320003 on Chrome beta for Android (Experimental mode)
No Thanks button, no author info, no idea how to debug. The page looks good in Chrome and Iceweasel for Debian.
PS: Ctrl + Shift + I here. :)
Comment Actions
@Qgil: Argh, i missed to cherry pick the change and so nobody deployed it into the actual wikipedias :( That means, that the change (which fixed this issue) will be deployed today, what you see is the problem described in this task.
https://m.mediawiki.org/wiki/Special:MobileDiff/1320003 on Chrome beta for Android (Experimental mode)
Hmm, at least on Firefox and chrome desktop the author and thanks button is visible. I will check this later today when i have a little bit more time, ok? :) That looks curios.
Comment Actions
Re-opening, I see no Thank button in Firefox or Opera (e.g. this random diff). I get this error in webconsole:
"Exception thrown by ext.thanks.mobilediff" load.php:150 "Error: Module not found: loggingSchemas/MobileWebClickTracking" Error: Module not found: loggingSchemas/MobileWebClickTracking Stack trace: .require@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=ext.centralNotice.bannerChoiceData%7Cext.centralNotice.bannerController.lib%2Cmobile%2Cmobiledevice%7Cext.mantle%7Cext.mantle.hogan%2Cmodules%2Coo%7Cjquery.accessKeyLabel%2Cclient%2Ccookie%2CmwExtension%7Cmediawiki.cldr%2CjqueryMsg%2Clanguage%2Cnotify%2Ctemplate%2Cutil%7Cmediawiki.language.data%2Cinit%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.startup%7Cmobile.head%2Ctemplates%7Coojs&skin=minerva&version=20150109T030008Z&*:28:214 @https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=ext.eventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.eventLogging.subscriber%7Cext.gadget.switcher%7Cext.mantle.views%7Cext.thanks.mobilediff%7Cext.wikimediaEvents.deprecate%2Cstatsd%7Cjquery.hidpi%7Cmediawiki.api%2Chidpi%2Cuser%7Cmediawiki.ui.anchor%2Cinput%7Cmobile.ajax%2Cdrawers%2Ceditor%2Cissues%2CloggingSchemas%2Coverlays%2Credirect%2Credlinks%2Creferences%2Csearch%2Csettings%2Cstable%2Cstartup%2Ctoast%2Ctoggling%2Cuser%2Cwatchstar%2Cwikigrok%7Cmobile.pagelist.scripts%7Cmobile.special.mobilediff.scripts%7Cmobile.upload.ui%7Cmobile.wikigrok.abTest%7Cschema.MobileWebDiffClickTracking%2CMobileWebEditing%2CMobileWebMainMenuClickTracking%2CMobileWebUIClickTracking%2CMobileWebUploads%2CMobileWebWatchlistClickTracking%2CMobileWebWikiGrok%2CMobileWebWikiGrokError%2CNavigationTiming%2CPopups%2CSaveTiming%2CUniversalLanguageSelector%7Cuser.defaults&skin=minerva&version=20150109T150504Z&*:12:844 @https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=ext.eventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.eventLogging.subscriber%7Cext.gadget.switcher%7Cext.mantle.views%7Cext.thanks.mobilediff%7Cext.wikimediaEvents.deprecate%2Cstatsd%7Cjquery.hidpi%7Cmediawiki.api%2Chidpi%2Cuser%7Cmediawiki.ui.anchor%2Cinput%7Cmobile.ajax%2Cdrawers%2Ceditor%2Cissues%2CloggingSchemas%2Coverlays%2Credirect%2Credlinks%2Creferences%2Csearch%2Csettings%2Cstable%2Cstartup%2Ctoast%2Ctoggling%2Cuser%2Cwatchstar%2Cwikigrok%7Cmobile.pagelist.scripts%7Cmobile.special.mobilediff.scripts%7Cmobile.upload.ui%7Cmobile.wikigrok.abTest%7Cschema.MobileWebDiffClickTracking%2CMobileWebEditing%2CMobileWebMainMenuClickTracking%2CMobileWebUIClickTracking%2CMobileWebUploads%2CMobileWebWatchlistClickTracking%2CMobileWebWikiGrok%2CMobileWebWikiGrokError%2CNavigationTiming%2CPopups%2CSaveTiming%2CUniversalLanguageSelector%7Cuser.defaults&skin=minerva&version=20150109T150504Z&*:12:1 runScript@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150107T194221Z:160:485 execute/</checkCssHandles@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150107T194221Z:160:970 execute@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150107T194221Z:161:749 handlePending@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150107T194221Z:159:28 runScript@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150107T194221Z:160:497 execute/</checkCssHandles@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150107T194221Z:160:970 execute@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150107T194221Z:161:749 handlePending@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150107T194221Z:159:28 runScript@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150107T194221Z:160:497 execute/</checkCssHandles@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150107T194221Z:160:970 execute/</cssHandle/<@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150107T194221Z:161:100 jQuery.Callbacks/fire@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150107T194221Z:44:928 jQuery.Callbacks/self.fireWith@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150107T194221Z:46:258 jQuery.Callbacks/self.fire@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150107T194221Z:46:301 addEmbeddedCSS@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150107T194221Z:155:871 addEmbeddedCSS/<@https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150107T194221Z:155:333
Comment Actions
Change 184083 had a related patch set uploaded (by Florianschmidtwelzow):
Mobile: Conform to new LoggingSchema
Comment Actions
Change 184084 had a related patch set uploaded (by Florianschmidtwelzow):
Mobile: Conform to new LoggingSchema
Comment Actions
Change 184085 had a related patch set uploaded (by Florianschmidtwelzow):
Mobile: Conform to new LoggingSchema
Comment Actions
Yap :( Now it's in production on wikipedia. There are still flow tests failing, anyone an idea?
Comment Actions
Change 184976 had a related patch set uploaded (by Florianschmidtwelzow):
Mobile: Conform to new LoggingSchema
Comment Actions
Yes, but it should be backported i think. Its now in production and wmf15 was branched before the merge of this (if i'm right, haven't checked from mobile phone), so the next planned release with this fix would be wmf16, and this are 14 days before it will deployed on wikipedias. If there are no other opinions, i will try to plan a SWAT for it tomorrow, ok? :)
Comment Actions
Agreed @Florian can you mail mobile-l with subject "Lightning deploy needed" with the details to make sure we get this scheduled? Thanks dude! :-)
Comment Actions
Change 184084 abandoned by Kaldari:
Mobile: Conform to new LoggingSchema
Reason:
No longer needed.