Page MenuHomePhabricator

VisualEditor should insert localised DEFAULTSORT: (SORTUJ:) in Polish
Closed, ResolvedPublic

Description

VisualEditor should insert localised DEFAULTSORT: (SORTUJ:) in Polish. https://pl.wikipedia.org/wiki/Wikipedia:Kawiarenka/Kwestie_techniczne#Wdro.C5.BCenie_i_checklista

Event Timeline

matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added subscribers: matmarex, tarlocesilion.
Jdforrester-WMF renamed this task from VisualEditor should insert localised DEFAULTSORT: (SORTUJ:) in Polish to Parsoid should insert localised DEFAULTSORT: (SORTUJ:) in Polish.Jan 22 2015, 7:23 PM
Jdforrester-WMF set Security to None.
ssastry triaged this task as Medium priority.Mar 3 2015, 9:44 PM

It should probably insert localized DEFAULTSORT in all languages, and for all other magic words as well. Here's a complaint in he.wikipedia:
https://he.wikipedia.org/w/index.php?title=%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94%3A%D7%A2%D7%95%D7%A8%D7%9A_%D7%97%D7%96%D7%95%D7%AA%D7%99%2F%D7%9E%D7%A9%D7%95%D7%91&type=revision&diff=17091505&oldid=17079762

Picking the first translation that appears in the 'defaultsort' line in languages/messages/Messages*.php should be the right thing to do instead of inserting DEFAULTSORT everywhere.

matmarex renamed this task from Parsoid should insert localised DEFAULTSORT: (SORTUJ:) in Polish to VisualEditor should insert localised DEFAULTSORT: (SORTUJ:) in Polish.Nov 16 2023, 7:34 PM
matmarex edited projects, added VisualEditor, VisualEditor-MediaWiki; removed Parsoid.

I guess this became invalid for Parsoid when its special handling for DEFAULTSORT was removed in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/908937 (as discussed in T337398), instead it's a VisualEditor bug now.

matmarex assigned this task to Nardog.

It looks like @Nardog's patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/972928 for T337398 resolved this. Thank you!

I think we can close this task, and I'll leave a note on the other one for the Editing team QA engineers, in case they want to verify this as well.