| Jdlrobson | |
| Mar 6 2015, 7:08 PM |
| F73453: test.png | |
| Mar 10 2015, 7:30 PM |
| F57155: device-2014-06-04-085320.png | |
| Mar 6 2015, 7:08 PM |
Proposal:
Links, headings and html comments are highlighting in light grey, all other content is black.
See
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T91796 Deemphasise wikitext markup in mobile wikitext editor | |||
| Declined | Florian | T95041 Deploy CodeMirror extension to beta cluster | |||
| Resolved | Reedy | T108687 Security review for CodeMirror extension branch master |
@Jhernandez, @Jdlrobson and me talked on IRC about it and we think it would be nearly impossible (with our all limited time and resources) to develop an own solution, which would work on _all_ browsers. So we think a library would be the easiest way doing this. We discussed CodeMirror (which has already a mediawiki extension [1]) and i started to implement it to see, if it fits our needs and is implementable in our editor. The result:
It would need some tweaks to the setup code, so i think it would be easier to use the extensions code and port it to MobileFrontend, which would require to commit codemirror and the mediawiki mode addon from the extension developer. Otherwise (if we reuse the resourceloader module of this extension) we could require Extension:CodeMirror in order to use codemirror. I'm unsure what would be the best way :(
Hey cool, the developer of CodeMirror seems to be registered here, adding him as a subscriber so he can see, that we're working with his code, maybe he can help us and/or has useful input @Pastakhov.
Thanks you for adding me here.
The CodeMirror library is awesome. Originally I wanted syntax highlighting and auto completion for the PhpTags extension. But I couldn't leave gray wikitext markup although it wasn't trivial task and I made the CodeMirror extension. There are few unfinished tasks, for example [[File: ... ]], prefix[[link]] and auto completion. Also I have not tested it with right-to-left text.
You are welcome if you want to contribute to the CodeMirror extension for resolve your own tasks. I'll help If I can.
Change 195991 had a related patch set uploaded (by Florianschmidtwelzow):
Rework extensions setup
Change 195995 had a related patch set uploaded (by Florianschmidtwelzow):
Add CodeMirror for alpha users to better understand wikitext
Cool stuff guys!
I think this would make a good alpha experiment :)
I'm not sure if aggressive A/B testing is necessary for a relatively small change like this, though. We could simply do a few user tests to see if this makes editing more user-friendly.
Change 195995 merged by jenkins-bot:
Add CodeMirror for alpha users to better understand wikitext
@Jdlrobson: Without CodeMirror installed, you'll never the the new editor :) I uploaded https://gerrit.wikimedia.org/r/#/c/199941/ to make it able to install CodeMirror just as a provider for the codemirror libraries without doing anything visible. I think it would be easier to deploy the extension with deactivated frontend, just for use in MobileFrontend, what do you mean? I'm still not sure, if this is the right way, it would need a (security-)review of the extension, before we can deploy it, right?
I do not mind to change owner of CodeMirror repository to someone who will review changes on security before merging. If I'm not mistaken this is necessary in order to use it on Wikimedia projects.
Change 202360 had a related patch set uploaded (by Pastakhov):
fix mwextModes property of CodeMirror editor
Change 202421 had a related patch set uploaded (by Pastakhov):
Lets CodeMirror automatically resize to fit its content
Change 202421 merged by jenkins-bot:
Lets CodeMirror automatically resize to fit its content
Reopening since CodeMirror is a no-go (T95041).
@Jdlrobson Is this a duplicate of T101246, or is this supposed to be mobile-specific?
@kaldari it's kind of similar but the opposite intention Experienced editors will want syntax highlighting emphasing wikitext, non-experienced having them gray. :)
T101246 doesn't specify what is emphasized and what isn't, but I think it's mainly intended to address the desktop WikiText editor. This bug seems to be about the mobile editor, but nothing in the title, projects, or description mentions that, so I'm not sure. Is this bug just about the mobile editor?
Feel free to merge then :) Just make sure to clarify in the description we might want to deemphasise the syntax.
@Jdlrobson In case you haven't been following the discussion on those other bugs, the Editing team probably wouldn't be happy with this (although I could be wrong). I still need to clarify the scope of this bug though. Is this bug just about the mobile editor?