Maniphest T93675

Should be a standard way to access tablet browser width threshold
Closed, ResolvedPublic
Actions

Description

In MobileFrontend we set a global $wgMFDeviceWidthTablet and make this available in LESS and js config. It basically defines the threshold where we consider a mobile device to be a tablet device. Note we do not define a desktop threshold (which we should do)

Flow has $wgFlowDeviceWidthTablet
I've just added this to Extension:Gather
In core the magic 768 number appears in mediawiki.action.view.categoryPage.less

Time to make this variable in core?

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Set threshold for is a tablet in LESS variable	mediawiki/core	master	+9 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
		Resolved		Jdlrobson	T71366 [EPIC] Extract Minerva skin from MobileFrontend to its own repository
		Resolved		None	T124992 MobileFrontend should use @deviceWidthTablet rather than @wgMFDeviceWidthTablet
		Resolved		None	T124988 Gather should use @deviceWidthTablet rather than @wgMFDeviceWidthTablet
		Resolved		Jdlrobson	T124990 QuickSurveys should use @deviceWidthTablet
		Resolved		Jdlrobson	T93675 Should be a standard way to access tablet browser width threshold
		Resolved		jo12bar	T124994 Vector should make use of deviceWidthTablet Less variable
		Resolved		None	T124995 Cards should use global @deviceWidthTablet LESS variable

Event Timeline

Jdlrobson created this task.Mar 23 2015, 10:16 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added projects: Web-Team-Backlog-Archived, UI-Standardization, StructuredDiscussions, Vector (legacy skin).

Jdlrobson moved this task to Incoming on the Web-Team-Backlog-Archived board.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2015, 10:16 PM

Ricordisamoa awarded a token.Mar 24 2015, 12:26 AM

Ricordisamoa subscribed.

Florian added a project: MediaWiki-General.Mar 24 2015, 8:55 AM

Florian subscribed.

• bmansurov moved this task from Incoming to 2015-16 Q4 on the Web-Team-Backlog-Archived board.Mar 25 2015, 5:14 PM

• DannyH triaged this task as Low priority.Mar 26 2015, 5:47 PM

• DannyH subscribed.

Jdlrobson moved this task from 2015-16 Q4 to Triaged but Future on the Web-Team-Backlog-Archived board.Apr 10 2015, 5:32 PM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 10 2015, 5:32 PM

• JKatzWMF moved this task from Triaged but Future to 2016-17 Q2 on the Web-Team-Backlog-Archived board.Apr 15 2015, 5:53 PM

phuedx moved this task from 2016-17 Q2 to 2014-15 Q4 on the Web-Team-Backlog-Archived board.Jun 2 2015, 4:58 PM

Quiddity mentioned this in T107241: Add responsive design to window sizes between 895px and 1165px.Jul 29 2015, 1:49 AM

Jdlrobson added a parent task: T71366: [EPIC] Extract Minerva skin from MobileFrontend to its own repository.Aug 14 2015, 6:09 PM

• Jhernandez raised the priority of this task from Low to Medium.Aug 17 2015, 11:19 AM

• Jhernandez edited projects, added MobileFrontend; removed Web-Team-Backlog-Archived.Aug 17 2015, 11:25 AM

Jdlrobson added a project: Reading-Web-Sprint-63-Ellip….Dec 21 2015, 4:44 PM

Jdlrobson set Security to None.

Jdlrobson claimed this task.Dec 21 2015, 11:18 PM

Jdlrobson moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-63-Ellip… board.

Change 260517 had a related patch set uploaded (by Jdlrobson):
Set threshold for is a tablet in LESS variable

https://gerrit.wikimedia.org/r/260517

gerritbot added a project: Patch-For-Review.Dec 22 2015, 12:06 AM

Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-63-Ellip… board.Dec 22 2015, 12:09 AM

• bmansurov moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-63-Ellip… board.Dec 22 2015, 2:52 AM

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-63-Ellip… board.Dec 22 2015, 7:29 PM

phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-63-Ellip… board.Dec 23 2015, 4:31 PM

Having a weird PHPUnit issue. Hopefully will get to bottom of it...

Jdlrobson moved this task from -1 (Needs More Work) to Doing on the Reading-Web-Sprint-63-Ellip… board.Dec 24 2015, 3:14 PM

Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-63-Ellip… board.Dec 24 2015, 10:49 PM

Change 261457 had a related patch set uploaded (by Jdlrobson):
Set threshold for is a tablet in LESS variable

https://gerrit.wikimedia.org/r/261457

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-63-Ellip… board.Dec 29 2015, 11:05 PM

Jdlrobson edited projects, added Front-end-Standards-Group; removed Reading-Web-Sprint-63-Ellip….Jan 19 2016, 9:10 PM

Jdlrobson moved this task from Inbox to Needs code review on the Front-end-Standards-Group board.

Change 261457 merged by jenkins-bot:
Set threshold for is a tablet in LESS variable

https://gerrit.wikimedia.org/r/261457

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)), MW-1.27-release-notes.Jan 27 2016, 2:00 AM

Jdlrobson closed this task as Resolved.Jan 27 2016, 10:36 PM

Jdlrobson added a parent task: T124990: QuickSurveys should use @deviceWidthTablet.

Jdlrobson added a parent task: T124988: Gather should use @deviceWidthTablet rather than @wgMFDeviceWidthTablet.

Jdlrobson added a parent task: T124992: MobileFrontend should use @deviceWidthTablet rather than @wgMFDeviceWidthTablet.

• bmansurov closed subtask T124995: Cards should use global @deviceWidthTablet LESS variable as Resolved.Feb 10 2016, 7:50 PM

Volker_E moved this task from Needs code review to Done on the Front-end-Standards-Group board.Jul 13 2016, 4:23 PM

Volker_E mentioned this in T117951: Remove templaters' need for .nomobile and support authoring media queries for templates.Jul 13 2016, 4:32 PM

Krinkle mentioned this in T140804: Remove $wgResourceLoaderLESSVars and ResourceLoaderGetLessVars hook.Jul 19 2016, 6:56 PM

Jdlrobson closed subtask T124994: Vector should make use of deviceWidthTablet Less variable as Resolved.Dec 14 2016, 12:53 AM

Volker_E removed a project: Patch-For-Review.Sep 12 2021, 3:37 AM