Page MenuHomePhabricator

Should be a standard way to access tablet browser width threshold
Closed, ResolvedPublic

Description

In MobileFrontend we set a global $wgMFDeviceWidthTablet and make this available in LESS and js config. It basically defines the threshold where we consider a mobile device to be a tablet device. Note we do not define a desktop threshold (which we should do)

Flow has $wgFlowDeviceWidthTablet
I've just added this to Extension:Gather
In core the magic 768 number appears in mediawiki.action.view.categoryPage.less

Time to make this variable in core?

Details

Related Gerrit Patches:

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task to Incoming on the Readers-Web-Backlog board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2015, 10:16 PM
Ricordisamoa added a subscriber: Ricordisamoa.
Florian added a subscriber: Florian.
DannyH triaged this task as Low priority.Mar 26 2015, 5:47 PM
DannyH added a subscriber: DannyH.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 10 2015, 5:32 PM
Jhernandez raised the priority of this task from Low to Medium.Aug 17 2015, 11:19 AM
Jdlrobson moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-63-Ellip… board.

Change 260517 had a related patch set uploaded (by Jdlrobson):
Set threshold for is a tablet in LESS variable

https://gerrit.wikimedia.org/r/260517

Having a weird PHPUnit issue. Hopefully will get to bottom of it...

Change 261457 had a related patch set uploaded (by Jdlrobson):
Set threshold for is a tablet in LESS variable

https://gerrit.wikimedia.org/r/261457

Change 261457 merged by jenkins-bot:
Set threshold for is a tablet in LESS variable

https://gerrit.wikimedia.org/r/261457