Page MenuHomePhabricator
Create Task
Maniphest T94793

Support ImageMap extension in Parsoid
Closed, ResolvedPublic
Actions

Description

The GraphViz extension relies on ImageMap for HTML output. Images emitted by the ImageMap extension are not marked up as images by Parsoid, so OCG output (for example) does not include them (do they render properly in our site CSS for VE?).

We could teach Parsoid about ImageMap, so that it emits consistent markup for all images.

Details

SubjectRepoBranchLines +/-
Move ImageMap parsoid support from Parsoid repo to ImageMap repomediawiki/extensions/ImageMapmaster+349 -0
Remove ImageMap extensionmediawiki/services/parsoidmaster+0 -583
Add 'parsoid' dependency to 'ImageMap', remove 'ImageMap' dep from Parsoidintegration/configmaster+2 -1
Bump wikimedia/parsoid to 0.13.0-a18mediawiki/vendorwmf/1.36.0-wmf.20+1 K -700
Bump wikimedia/parsoid to 0.13.0-a18mediawiki/vendormaster+1 K -700
Native ImageMap implementationmediawiki/services/parsoidmaster+479 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

cscott created this task.Apr 2 2015, 1:59 AM
cscott raised the priority of this task from to Lowest.
cscott updated the task description. (Show Details)
cscott added a project: Parsoid.
cscott subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2015, 1:59 AM
cscott added a comment.Apr 2 2015, 2:03 AM

See also T94795, which is an end-run around the issue and does not require special Parsoid support.

Welterkj subscribed.EditedApr 10 2015, 10:34 PM

Graph images rendered by the GraphViz extension (and ImageMap) appear as non-editable images in VE when editing. In other words, the behavior of the extensions in VE is what I would expect/hope for.

Welterkj renamed this task from Support ImageMap extension in Parsoid. to Support GraphViz extension in Parsoid..Apr 10 2015, 11:03 PM
Welterkj updated the task description. (Show Details)
Welterkj set Security to None.
Welterkj added a comment.EditedApr 10 2015, 11:06 PM

Oops. The original description was correct so I restored it.

Welterkj renamed this task from Support GraphViz extension in Parsoid. to Support ImageMap extension in Parsoid..Apr 11 2015, 12:53 PM
Welterkj updated the task description. (Show Details)
LGoto moved this task from Needs Triage to Backlog on the Parsoid board.Feb 17 2020, 4:43 PM
• ssastry moved this task from Backlog to Feature requests on the Parsoid board.Mar 7 2020, 8:56 PM
• ssastry raised the priority of this task from Lowest to Medium.Mar 29 2020, 11:31 PM
• ssastry moved this task from Feature requests to Missing Functionality on the Parsoid board.
Arlolra claimed this task.Apr 1 2020, 3:00 PM
gerritbot added a comment.Apr 1 2020, 10:54 PM

Change 585344 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] [WIP] ImageMap

https://gerrit.wikimedia.org/r/585344

gerritbot added a project: Patch-For-Review.Apr 1 2020, 10:54 PM
• ssastry renamed this task from Support ImageMap extension in Parsoid. to Support ImageMap extension in Parsoid.Apr 20 2020, 9:17 PM
• ssastry added a project: Parsing-Active-Work.
• ssastry moved this task from Incoming Work (but not yet ready) to Doing (Other Work) on the Parsing-Active-Work board.
• ssastry added a parent task: T227844: Piped wikilinks in imagemaps go to label instead of target.May 1 2020, 4:28 PM
• ssastry mentioned this in T236809: Refactor Parser.php to allow alternate parser (Parsoid).May 27 2020, 2:00 PM
• ssastry moved this task from Missing Functionality to Current & Upcoming Work on the Parsoid board.Jul 2 2020, 6:39 PM
• ssastry added a project: Parsoid-Rendering.Jul 15 2020, 5:52 PM
• ssastry added a parent task: T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid.Jul 24 2020, 9:15 PM
Aklapper added a parent task: T94795: Support ImageMap extension in OCG bundler & renderer.Aug 10 2020, 10:33 AM
• ssastry added a parent task: T254181: Run parserTests with Parsoid in extension repos.Sep 24 2020, 6:46 PM
• ssastry removed a parent task: T254181: Run parserTests with Parsoid in extension repos.
• ssastry added a subtask: T254181: Run parserTests with Parsoid in extension repos.
Arlolra mentioned this in T227844: Piped wikilinks in imagemaps go to label instead of target.Nov 16 2020, 8:44 PM
gerritbot added a comment.Nov 20 2020, 2:41 AM

Change 585344 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Native ImageMap implementation

https://gerrit.wikimedia.org/r/585344

Maintenance_bot removed a project: Patch-For-Review.Nov 20 2020, 3:10 AM
Arlolra closed this task as Resolved.Nov 20 2020, 2:58 PM

Still a few FIXMEs but we can consider this done.

  • Localized "imagemap_desc_types" still needs support
  • CSS magnify links
gerritbot added a comment.Dec 1 2020, 3:41 AM

Change 644393 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a18

https://gerrit.wikimedia.org/r/644393

gerritbot added a project: Patch-For-Review.Dec 1 2020, 3:41 AM
gerritbot added a comment.Dec 1 2020, 4:14 AM

Change 644221 had a related patch set uploaded (by C. Scott Ananian; owner: Subramanya Sastry):
[mediawiki/vendor@wmf/1.36.0-wmf.20] Bump wikimedia/parsoid to 0.13.0-a18

https://gerrit.wikimedia.org/r/644221

gerritbot added a comment.Dec 1 2020, 4:31 AM

Change 644393 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a18

https://gerrit.wikimedia.org/r/644393

gerritbot added a comment.Dec 1 2020, 2:04 PM

Change 644221 merged by jenkins-bot:
[mediawiki/vendor@wmf/1.36.0-wmf.20] Bump wikimedia/parsoid to 0.13.0-a18

https://gerrit.wikimedia.org/r/644221

Maintenance_bot removed a project: Patch-For-Review.Dec 1 2020, 2:11 PM
cscott closed subtask T254181: Run parserTests with Parsoid in extension repos as Resolved.Nov 5 2021, 4:10 PM
gerritbot added a comment.Dec 10 2021, 6:42 PM

Change 745930 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[integration/config@master] Add 'parsoid' dependency to 'ImageMap', remove 'ImageMap' dep from Parsoid

https://gerrit.wikimedia.org/r/745930

gerritbot added a project: Patch-For-Review.Dec 10 2021, 6:42 PM
gerritbot added a comment.Dec 10 2021, 7:17 PM

Change 745936 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/ImageMap@master] Move ImageMap parsoid support from Parsoid repo to ImageMap repo

https://gerrit.wikimedia.org/r/745936

gerritbot added a comment.Dec 10 2021, 7:44 PM

Change 745945 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Remove ImageMap extension

https://gerrit.wikimedia.org/r/745945

gerritbot added a comment.Jun 16 2022, 5:04 PM

Change 745930 abandoned by C. Scott Ananian:

[integration/config@master] Add 'parsoid' dependency to 'ImageMap', remove 'ImageMap' dep from Parsoid

Reason:

no longer necessary

https://gerrit.wikimedia.org/r/745930

gerritbot added a comment.Sep 27 2023, 3:02 PM

Change 745945 abandoned by Arlolra:

[mediawiki/services/parsoid@master] Remove ImageMap extension

Reason:

In favour of Id7d9e82ee4ff20a79ba1a5b2433fa29bc5f76e68

https://gerrit.wikimedia.org/r/745945

gerritbot added a comment.Sep 27 2023, 3:02 PM

Change 745936 abandoned by Arlolra:

[mediawiki/extensions/ImageMap@master] Move ImageMap parsoid support from Parsoid repo to ImageMap repo

Reason:

In favour of I6cffa4420d2daa70174fa926d5c7a4d983792969

https://gerrit.wikimedia.org/r/745936

Maintenance_bot removed a project: Patch-For-Review.Sep 27 2023, 3:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits