Parsoid srcset is inconsistent with core
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cscott
	Oct 8 2019, 2:59 PM

Description

Follow up to T226683: Ensure that JS & PHP imageinfo requests return responsive urls in the same order: it turns out that Parsoid's output doesn't match core for the srcset attribute, and in my reading of https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Responsive_images we need a matching sizes attribute as well.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Bump wikimedia/parsoid to v0.13.0-a6	mediawiki/vendor	master	+462 -231
	Match ordering of core's srcset attribute; add mock API support	mediawiki/services/parsoid	master	+32 -15

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
Open		None	T50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
Open		None	T54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
Open		None	T396539 Introduce a way to edit a span of text from within read mode
Open		None	T385558 Improve copy and paste from read mode to VE
Open		None	T174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
Open	Feature	None	T54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
Open		None	T55784 [EPIC] Use Parsoid HTML for all page views
Open		None	T258838 [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid
Open		None	T272987 [EPIC] Parsoid read views for DiscussionTools
Resolved		ssastry	T110909 Parsoid tripped up by extensions that process wikitext
Stalled		None	T131393 Page indicators aren't visible in articles
Resolved		ssastry	T107332 Parsoid-native implementation for <indicator> (page status indicators)
Resolved		Dbrant	T227844 Piped wikilinks in imagemaps go to label instead of target
Declined		None	T94795 Support ImageMap extension in OCG bundler & renderer
Resolved		Arlolra	T94793 Support ImageMap extension in Parsoid
Open		None	T261329 Prepare Parsoid for MW
Resolved		cscott	T254181 Run parserTests with Parsoid in extension repos
Resolved		cscott	T234932 Parsoid srcset is inconsistent with core

Event Timeline

cscott created this task.Oct 8 2019, 2:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 8 2019, 2:59 PM

LGoto moved this task from Needs Triage to Backlog on the Parsoid board.Feb 15 2020, 12:05 AM

LGoto moved this task from Backlog to Bugs & Crashers on the Parsoid board.Feb 21 2020, 5:27 PM

ssastry triaged this task as Medium priority.Apr 10 2020, 7:58 PM

ssastry removed a subscriber: Parsing-Team--ARCHIVED.

ssastry added a project: Parsoid-Rendering.Jul 16 2020, 4:00 AM

Change 618174 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] WIP: Match core's srcset attribute

https://gerrit.wikimedia.org/r/618174

gerritbot added a project: Patch-For-Review.Aug 4 2020, 6:02 AM

Current status:

Screenshot from 2020-08-04 16-58-59.png (1×3 px, 577 KB)

Change 618174 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Match ordering of core's srcset attribute; add mock API support

https://gerrit.wikimedia.org/r/618174

ssastry assigned this task to cscott.Aug 6 2020, 5:57 PM

ssastry added a project: Parsing-Active-Work.

ssastry moved this task from Incoming Work (but not yet ready) to Doing (Roadmap Critical Path) on the Parsing-Active-Work board.

ssastry added a parent task: T254181: Run parserTests with Parsoid in extension repos.

Maintenance_bot removed a project: Patch-For-Review.Aug 6 2020, 6:11 PM

ssastry closed this task as Resolved.Aug 6 2020, 8:18 PM

Change 620755 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to v0.13.0-a6

https://gerrit.wikimedia.org/r/620755

gerritbot added a project: Patch-For-Review.Aug 17 2020, 5:30 PM

Change 620755 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to v0.13.0-a6

https://gerrit.wikimedia.org/r/620755

Maintenance_bot removed a project: Patch-For-Review.Aug 17 2020, 7:12 PM