Page MenuHomePhabricator

ContentTranslation link adaption adds <nowiki/> tag
Closed, ResolvedPublic

Event Timeline

KartikMistry raised the priority of this task from to Needs Triage.
KartikMistry updated the task description. (Show Details)
KartikMistry added a subscriber: KartikMistry.
Amire80 triaged this task as Medium priority.Apr 7 2015, 9:27 AM
Amire80 added projects: Parsoid-Nowiki, Parsoid.
Amire80 added a subscriber: ssastry.

Parsoid doesn't handle empty content links specially. Is it difficult to remove empty <a> tags in CX? Or should they not have been empty in the first place?

Also see T95730 for a similar issue in VE. I have to understand which of these normalizations are not possible to do in clients, and for what reason.

Amire80 renamed this task from Link adaption adds <nowiki/> tag to ContentTranslation link adaption adds <nowiki/> tag.May 21 2015, 6:15 AM

I found one scenario where this can be reproduced consistently:

  1. Translate an article to French.
  2. Type "Paris" in the target column.
  3. Select "Paris".
  4. A link card will appear in the sidebar. Click "Add link" ("Ajouter un lien") in the link card.

Observed: The selected word "Paris" is linked correctly - it becomes an <a> tag. But immediately after that <a> tag, another <a> tag with no content is inserted.

Several questions:

  1. Should we remove empty <a> tags before publishing as a workaround till it's fixed comprehensively? It's an ugly hack, but it will reduce the junk in the published articles.
  2. Is it fixed by https://gerrit.wikimedia.org/r/#/c/204738/ ? I cannot test it at the moment.
Amire80 claimed this task.

Tested.