You will be redirected immediately to PayPal, for 3 USD. There should be an interstitial page alerting you to the currency conversion--unless we disabled that intentionally??
When fixed: write tests and document current policy, so this doesn't sneak up on us again.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T87621 [epic] PayPal upgrade | |||
| Resolved | XenoRyet | T131816 Paypal Express checkout 1 hour test | |||
| Resolved | Pcoombe | T131118 Fundraise in India | |||
| Resolved | awight | T98447 Assisted currency conversion for PayPal is broken again |
@MeganHernandez_WMF thinks this may have been done intentionally. Do we have any notes about when this was changed?
We're not running campaigns in any of these countries for the time being and should investigate if this was intentional.
That's what I was thinking as well, but I've gone through the code version history, and the last change I found was Mar 2013, where we specifically pause for interaction if the currency is not supported.
Change 280141 had a related patch set uploaded (by Awight):
[WIP] Change meaning of validation variables
Looks like just settings:
$wgPaypalGatewayFallbackCurrency = 'USD'; $wgPaypalGatewayNotifyOnConvert = false;
Not seeing any emails or admin logs about the change
@Ppena / @MeganHernandez_WMF : Do we need to change these settings? It's currently converting and redirecting to PayPal without a confirmation page on our site. Once you get to PayPal it does show the conversion from the donation currency to the donor's account currency.
@Ejegg I don't remember intentionally changing it, so I support keeping an interstitial page alerting donors to the currency conversion- that's a better and more clear flow.
Something is borken.
Takes me to an interstitial page with no warning about the currency conversion, but amount and currency fields for 150 JPY.
PayPal legacy does convert correctly, but without an interstitial page.
PayPal express checkout behaves different, and always shows the interstitial with currency=JPY.
K the PP legacy bug was simply that we never turned the interstitial warning back on. I'll do that for all gateways.
Change 341592 had a related patch set uploaded (by Awight):
[mediawiki/extensions/DonationInterface] [WIP] Form did not validate if manual errors are present
Change 280141 abandoned by Awight:
[WIP] Change meaning of validation variables
Reason:
Hahaha looks like we've been through this town already
Change 341592 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Form should not validate if manual errors are present
Change 341478 had a related patch set uploaded (by Ejegg; owner: Awight):
[mediawiki/extensions/DonationInterface@master] Integration test that the PayPal legacy gateway shows an error form rather than redirect.
Change 341478 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Integration test that the PayPal legacy gateway shows an error form rather than redirect.
Change 350495 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Move fallback message to the currency_code slot