Changes in MobileFrontend can break Gather so Gather's tests should probably be run in MobileFrontend
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| mediawiki-extensions-qunit-mobile | integration/config | master | +35 -0 | |
| Common job for extensions that runs qunit | integration/config | master | +63 -18 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T99686 Gather can't merge code due to issue with karma (jenkins mwext-qunit job) | |||
| Resolved | hashar | T99877 MobileFrontend qunit tests should run Gather tests as well |
Event Timeline
Comment Actions
In short, we need a qunit job that clone and his triggered by a bunch of extensions like the mediawiki-testextensions jobs.
Comment Actions
We need a new qunit job that is like mediawiki-testextensions but runs qunit instead of PHPUnit.
Comment Actions
Doing some refactoring in preparation:
https://gerrit.wikimedia.org/r/#/c/216097/ JJB: zuul-cloner-extdeps slightly more reusable
https://gerrit.wikimedia.org/r/#/c/216105/ Factor VE submodule update in a macro
https://gerrit.wikimedia.org/r/#/c/216100/ Refactor mediawiki-extensions-{phpflavor}
That will let us reuse the logic from mediawiki-extensions-{phpflavor} and create a qunit/karma equivalent.
Comment Actions
Better reflecting the priority. If it was a high one it would have been fixed sometime ago.
Comment Actions
Change 216132 had a related patch set uploaded (by Hashar):
Common job for extensions that runs qunit
Comment Actions
The first prod change to pass is https://gerrit.wikimedia.org/r/#/c/216292/3 and mediawiki-extensions-qunit ran happily in 2 minutes.
Now I gotta add a -mobile version.
Comment Actions
Change 216322 had a related patch set uploaded (by Hashar):
mediawiki-extensions-qunit-mobile
Comment Actions
Change 216322 abandoned by Hashar:
mediawiki-extensions-qunit-mobile
Reason:
Clarified with Timo. His RL patch https://gerrit.wikimedia.org/r/#/c/216886/ will fulfill mobile needs and Jon from mobile is in the loop.
Thus no need for a mediawiki-extensions-qunit-mobile job!
Comment Actions
From a discussion with Timo: running qunit with useformat=mobile is not needed. https://gerrit.wikimedia.org/r/#/c/216886/ updates the ResourceLoader to let us run qunit jobs the mobile way.
What is left to be done?
Verify what uses the mediawiki-extensions-qunit job added by https://gerrit.wikimedia.org/r/#/c/216132/ . But I think both Gather and MobileFrontend are sharing it.
We might want to remove the per extension jobs that brings in dependencies. Should be superseeded by that new shared job.