Page MenuHomePhabricator

MartinK (Martin Kraft)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 5 2015, 9:27 PM (233 w, 12 h)
Availability
Available
IRC Nick
MartinK
LDAP User
Unknown
MediaWiki User
Martin Kraft [ Global Accounts ]

Recent Activity

Tue, Aug 27

MartinK awarded T231344: Design a new, responsive on-wiki landing page template for WLM a Like token.
Tue, Aug 27, 5:45 PM · Wikimania-Hackathon-2019, Wiki-Loves-Monuments (2019)

Aug 28 2018

MartinK added a comment to T197617: TemplateStyles should be able to add skin-specific CSS.

Just checked it on de.Wiki and it seems to be working.
@Tgr Thanks for the express delivery!

Aug 28 2018, 5:49 PM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), TemplateStyles

Aug 27 2018

MartinK added a comment to T197617: TemplateStyles should be able to add skin-specific CSS.

@Tgr Thanks for the implementation. It would be good ta have it deployed on Commons asap, because we also need some time to build and test the landing pages - that need to be ready on Thursday evening latest.

Aug 27 2018, 10:32 PM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), TemplateStyles

Aug 24 2018

MartinK added a comment to T197617: TemplateStyles should be able to add skin-specific CSS.

@Jdlrobson The problem is, that with MediaQueries react to the viewport width - not to the width of the content column. The very same viewport-width can result in totally different content widths, depending on the skin, the content lives in.

  • In Minerva e.g. the content column is limited but fills up the full viewport on smaller devices.
  • In Vector the content column floats to infinit but has to share its space with the side column
  • In Timeless there are to side-columns and a max-width
  • etc.

So for a really good working layout, one needs to know, which skin one is in.

Aug 24 2018, 9:22 PM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), TemplateStyles

Aug 23 2018

MartinK added a comment to T197617: TemplateStyles should be able to add skin-specific CSS.

I can't stress enough that it's really important to be able to use this feature right from the beginning of the campaign on. We had a significant slump in contributors last year, which, according to our analysis, can also be attributed to the inadequate optimization for the increasing proportion of mobile users.

Aug 23 2018, 12:18 PM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), TemplateStyles
MartinK added a comment to T197617: TemplateStyles should be able to add skin-specific CSS.

@Tgr: Any plans, when this is going to be deployed.
As I told you on Wikimania. We need this feature for the LandingPages of this years WLM-Campaigns - starting in little more than a week now.

Aug 23 2018, 11:14 AM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), TemplateStyles

Aug 9 2018

MartinK added a comment to T197617: TemplateStyles should be able to add skin-specific CSS.

@Tgr @Deskana Just as a quick reminder: We talked about this task on Wikimania. And both of you agreed, that it should be possible to implement and deploy it by mid August, so that is ready to use for this years WLM campaign (starting end of this month).

Aug 9 2018, 8:29 AM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), TemplateStyles

Jul 1 2018

MartinK updated subscribers of T197617: TemplateStyles should be able to add skin-specific CSS.
Jul 1 2018, 6:37 PM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), TemplateStyles
MartinK updated subscribers of T197617: TemplateStyles should be able to add skin-specific CSS.

@Aklapper Please revert the vandalism of @Vvjjkkii (also in other tickets).

Jul 1 2018, 6:37 PM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), TemplateStyles

Jun 19 2018

MartinK added a comment to T197617: TemplateStyles should be able to add skin-specific CSS.

Btw. an additional skin class on .mw-parser-output wouldn't solve the problem, since it is not possible to specify a selector for this element in TemplateStyles. On .mw-parser-output is different from within .mw-parser-output.

Jun 19 2018, 9:54 PM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), TemplateStyles
MartinK added a comment to T197617: TemplateStyles should be able to add skin-specific CSS.

However, wouldn’t it eliminate the goal of mw-parser-output if such selector was allowed?

Jun 19 2018, 9:49 PM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), TemplateStyles

Jun 18 2018

MartinK added a comment to T197617: TemplateStyles should be able to add skin-specific CSS.

I would recommend, to suffix (instead of prefix) any selector including body with .mw-parser-output

Jun 18 2018, 9:08 PM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), TemplateStyles
MartinK awarded T197617: TemplateStyles should be able to add skin-specific CSS a Like token.
Jun 18 2018, 4:34 PM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), TemplateStyles

Apr 6 2018

MartinK added a comment to T191612: Make the creation of CSS pages with TemplateStyles work more sensibly on the German Wikipedia.

IMHO there is nothing to be said against enabling subpages in de.Wiki, since they are already widely used in the Template-Namespaces anyhow – including but not limited to the documentation pages under "xy/Doku".

Apr 6 2018, 2:43 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Wikimedia-Site-requests, Wikimedia-Extension-setup, TemplateStyles

Apr 4 2018

MichaelSchoenitzer awarded T190910: Create and deploy configuration change to enable TemplateStyles on German Wikipedia on 2018-04-04 a Party Time token.
Apr 4 2018, 10:55 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Wikimedia-Site-requests, Wikimedia-Extension-setup, TemplateStyles

Mar 31 2018

DC awarded T190910: Create and deploy configuration change to enable TemplateStyles on German Wikipedia on 2018-04-04 a Love token.
Mar 31 2018, 3:38 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Wikimedia-Site-requests, Wikimedia-Extension-setup, TemplateStyles

Mar 28 2018

MartinK added a comment to T190910: Create and deploy configuration change to enable TemplateStyles on German Wikipedia on 2018-04-04.

IMHO CSS (especially sanitised CSS) does not offer a lot of fun options to vandals. From a vandals point of view it is probably way more satisfying to lease some swear words in articles than changing the font-size.
And if something like this happens, it can be handled easily by 3/4-protecting the CSS files.

Mar 28 2018, 6:00 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Wikimedia-Site-requests, Wikimedia-Extension-setup, TemplateStyles
MartinK added a comment to T190910: Create and deploy configuration change to enable TemplateStyles on German Wikipedia on 2018-04-04.

T190945 shouldn't be a blocker.
In de.Wiki only admins are allowed to change the content type (to sanitized CSS). So they are in control of the number and purpose of CSS documents and their protection status.
By the way: Although most of the templates aren't protected either, we didn't experience a lot of vandalism there. So why should CSS be worse?

Mar 28 2018, 4:57 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Wikimedia-Site-requests, Wikimedia-Extension-setup, TemplateStyles
CKoerner_WMF awarded T190910: Create and deploy configuration change to enable TemplateStyles on German Wikipedia on 2018-04-04 a Party Time token.
Mar 28 2018, 2:29 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Wikimedia-Site-requests, Wikimedia-Extension-setup, TemplateStyles
Cirdan awarded T190910: Create and deploy configuration change to enable TemplateStyles on German Wikipedia on 2018-04-04 a Love token.
Mar 28 2018, 12:31 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Wikimedia-Site-requests, Wikimedia-Extension-setup, TemplateStyles
MartinK awarded T190910: Create and deploy configuration change to enable TemplateStyles on German Wikipedia on 2018-04-04 a Love token.
Mar 28 2018, 9:41 AM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Wikimedia-Site-requests, Wikimedia-Extension-setup, TemplateStyles
MartinK triaged T190910: Create and deploy configuration change to enable TemplateStyles on German Wikipedia on 2018-04-04 as Normal priority.
Mar 28 2018, 9:29 AM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Wikimedia-Site-requests, Wikimedia-Extension-setup, TemplateStyles

Jan 19 2018

MartinK added a comment to T176269: Disallow <templatestyles> tags in non-Template namespaces.

I too, don't see a reason, why it should be necessary to prevent people from using <templatestyles> within normal Wiki-Pages. There are quite some use cases where styles are only necessary for a single page – e.g. the MainPage or the central Meta-Pages. And it would be just a waste of energy to force people to create single-use-templates for that.

Jan 19 2018, 5:13 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), TemplateStyles

Dec 30 2017

MartinK awarded T133410: Deploy TemplateStyles to WMF production a Burninate token.
Dec 30 2017, 8:02 PM · Epic, Performance-Team (Radar), User-notice, Readers-Web-Backlog (Tracking), Traffic, Operations, Wikimedia-Extension-setup, TemplateStyles

Dec 21 2017

MartinK added a comment to T182189: Banner 29 - redesign.

Jepp. I tested that via resizing and I think, that we should implement it in a way that it works when resizing, since it is quite common to resizes the browser while reading and comparing another document.
I've already seen a banner with some of the changes applied.

Dec 21 2017, 6:44 PM · WMDE-Fundraising-Tech, WMDE-FUN-Team

Dec 15 2017

MartinK added a comment to T182189: Banner 29 - redesign.

@kai.nissen thanks for the fast reaction!
I just rechecked it. Here are my comments:

Dec 15 2017, 9:18 PM · WMDE-Fundraising-Tech, WMDE-FUN-Team
MartinK assigned T182189: Banner 29 - redesign to kai.nissen.
Dec 15 2017, 10:59 AM · WMDE-Fundraising-Tech, WMDE-FUN-Team

Dec 11 2017

MartinK added a comment to T182189: Banner 29 - redesign.

Hi! Thanks for implementing the banner. Although the overall look'n'feel is quite good already, I do have some requests and suggestions concerning the layout:

Dec 11 2017, 2:09 PM · WMDE-Fundraising-Tech, WMDE-FUN-Team

Feb 7 2017

MartinK awarded T107021: [AG] Provide a permanent link for sharing generated licence a Yellow Medal token.
Feb 7 2017, 2:37 PM · TCB-Team, Tool-Attribution-Generator

Dec 7 2016

MartinK awarded T152593: Redlinks should open the respective editor that's set in the user or global settings a Love token.
Dec 7 2016, 11:49 AM · WikiEditor, VisualEditor

Aug 24 2016

MartinK awarded T483: RfC: Allow styling in templates a Like token.
Aug 24 2016, 8:37 PM · User-Ryasmeen, TechCom-RFC (TechCom-Approved), VisualEditor, Parsing-Team, Proposal, TemplateStyles, Wikimedia-Hackathon-2016

Jul 1 2016

MartinK added a comment to T138665: Support SVG interactivity and animation in media-viewer.

+1 (We talked about this in Esino Lario.)

Jul 1 2016, 9:18 PM · Multimedia, MediaViewer

Jun 25 2016

MartinK awarded T138665: Support SVG interactivity and animation in media-viewer a Like token.
Jun 25 2016, 6:48 PM · Multimedia, MediaViewer

Mar 11 2016

MartinK added a comment to T74109: Upgrade OTRS to a more recent stable release.

We still got the some layout-issues:

Mar 11 2016, 5:42 PM · Patch-For-Review, User-notice, Operations, OTRS

Feb 23 2016

MartinK awarded T127881: Enable VisualEditor for logged-out and newly registered users on German Wikipedia a Pterodactyl token.
Feb 23 2016, 11:22 PM · User-Ryasmeen, Wikimedia-Site-requests, VisualEditor

Feb 8 2016

MartinK awarded T121895: Pasting text for a link label removes the link a The World Burns token.
Feb 8 2016, 7:05 PM · MW-1.28-release (WMF-deploy-2016-09-06_(1.28.0-wmf.18)), VisualEditor-MediaWiki-Links, VisualEditor-CopyPaste, VisualEditor
MartinK awarded T55973: VisualEditor: Link input widget should have separate inputs for target and display text a Like token.
Feb 8 2016, 7:04 PM · User-Ryasmeen, Design, VisualEditor-MediaWiki-Links, VisualEditor, VisualEditor-EditingTools

Jan 26 2016

MartinK awarded T124804: All wikis under wikimedia.org (Meta, Commons, loginwiki, others) are using wikimedia.org VHost, including /wiki/ -> wikimediafoundation.org redirect a The World Burns token.
Jan 26 2016, 7:34 PM · Incident-20160126-WikimediaDomainRedirection, Wikimedia-Apache-configuration, Operations, netops

Dec 30 2015

MartinK added a comment to T87336: PageImages shouldn't return images that are not in the lead section.

@Jdlrobson Sorry, but I don't see a difference between a "PageImage" and a "LeadImage" here:

Dec 30 2015, 12:03 AM · MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)), Reading-Web-Sprint-87-♨️😭, Reading-Web-Sprint-86-🔪🦃, Readers-Web-Backlog, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, PageImages

Dec 21 2015

MartinK added a comment to T95026: PageImages should be able to pick Wikidata's P18 as chosen image.

Beside that this suggestion would rise editorial problems – especially if the WikiData-images would overrule (3.) the images used in the local articles:

Dec 21 2015, 10:05 AM · Readers-Web-Backlog, Wikidata, PageImages
MartinK added a comment to T95026: PageImages should be able to pick Wikidata's P18 as chosen image.

Please differentiate between Commons' project goal and the international legal reality. Copyright laws are complex – especially in an international context. And regardless of its ambitions, there are a lot of Commons images that can not be used in certain language versions. E.G. German Wikipedia can not use all the images wth licence templates implementing {{Urheberrechtlich_geschützt}}
https://commons.wikimedia.org/wiki/Special:WhatLinksHere/Template:Urheberrechtlich_gesch%C3%BCtzt

Dec 21 2015, 9:36 AM · Readers-Web-Backlog, Wikidata, PageImages
MartinK raised the priority of T87336: PageImages shouldn't return images that are not in the lead section from Low to Normal.

@Nemo_bis sorry, but you don't get the point: This is not just a problem of this very image (and it definitely can not be solved by a deletion request). This is a general problem:

Dec 21 2015, 9:23 AM · MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)), Reading-Web-Sprint-87-♨️😭, Reading-Web-Sprint-86-🔪🦃, Readers-Web-Backlog, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, PageImages

Dec 20 2015

MartinK added a comment to T95026: PageImages should be able to pick Wikidata's P18 as chosen image.

As I already pointed out in T87336 this is not really a good idea from the copyright point of view, because..

  • pageimages belong to the language versions of wikipedia and therefore need to obey the local copyright laws..
  • while WikiData seems to be based on US-copyright alone.
Dec 20 2015, 4:49 PM · Readers-Web-Backlog, Wikidata, PageImages
MartinK raised the priority of T87336: PageImages shouldn't return images that are not in the lead section from Low to Normal.

@Nemo_bs: Does that really solve the problem? No it doesn't!
It just demonstrates that we do have another problem and that task T95026 isn't a solution but an implementation that would cause a lot of copyright problems itself:

Dec 20 2015, 4:40 PM · MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)), Reading-Web-Sprint-87-♨️😭, Reading-Web-Sprint-86-🔪🦃, Readers-Web-Backlog, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, PageImages

Dec 19 2015

MartinK added a comment to T87336: PageImages shouldn't return images that are not in the lead section.

This task is really important, because the current system of using the first image regardless of its context produces strange results sometimes. Take the german Dean Martin article for example:
https://de.wikipedia.org/w/index.php?title=Dean_Martin&action=info

Dec 19 2015, 9:44 PM · MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)), Reading-Web-Sprint-87-♨️😭, Reading-Web-Sprint-86-🔪🦃, Readers-Web-Backlog, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, PageImages
MartinK raised the priority of T87336: PageImages shouldn't return images that are not in the lead section from Low to Normal.
Dec 19 2015, 9:25 PM · MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)), Reading-Web-Sprint-87-♨️😭, Reading-Web-Sprint-86-🔪🦃, Readers-Web-Backlog, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, PageImages

Nov 15 2015

MartinK raised the priority of T52864: Have a conversation about migrating from GNU Mailman 2.1 to GNU Mailman 3.0 from Lowest to High.
Nov 15 2015, 3:36 PM · Operations, Wikimedia-Mailing-lists

Oct 27 2015

MartinK added a comment to T74109: Upgrade OTRS to a more recent stable release.

Imho for volunteers like us the key benefit of OTRS Version 5 is the mobile ready user interface. Being able to Prozess some Tickets while commuting would realy increase our productivity.

Oct 27 2015, 8:07 AM · Patch-For-Review, User-notice, Operations, OTRS

Sep 14 2015

MartinK added a comment to T112446: Upload wizard fails with api-error-badtoken, cannot resubmit.

@matmarex We are in the middle of Wiki Loves Monuments right now. For multi uploads this probably is the most busy time of the year. Therefore it is really important to fix this issue as fast as possible!

Sep 14 2015, 7:54 PM · WMF-deploy-2015-09-08_(1.26wmf22), WMF-deploy-2015-09-15_(1.26wmf23), Patch-For-Review, Multimedia, UploadWizard
MartinK merged T112514: Interner Fehler: Der Token ist fehlerhaft. into T112446: Upload wizard fails with api-error-badtoken, cannot resubmit.
Sep 14 2015, 2:22 PM · WMF-deploy-2015-09-08_(1.26wmf22), WMF-deploy-2015-09-15_(1.26wmf23), Patch-For-Review, Multimedia, UploadWizard
MartinK merged task T112514: Interner Fehler: Der Token ist fehlerhaft. into T112446: Upload wizard fails with api-error-badtoken, cannot resubmit.
Sep 14 2015, 2:22 PM · Multimedia, UploadWizard
MartinK reopened T112446: Upload wizard fails with api-error-badtoken, cannot resubmit as "Open".
Sep 14 2015, 2:21 PM · WMF-deploy-2015-09-08_(1.26wmf22), WMF-deploy-2015-09-15_(1.26wmf23), Patch-For-Review, Multimedia, UploadWizard
MartinK merged task T112446: Upload wizard fails with api-error-badtoken, cannot resubmit into T112514: Interner Fehler: Der Token ist fehlerhaft..
Sep 14 2015, 2:19 PM · WMF-deploy-2015-09-08_(1.26wmf22), WMF-deploy-2015-09-15_(1.26wmf23), Patch-For-Review, Multimedia, UploadWizard
MartinK updated subscribers of T112514: Interner Fehler: Der Token ist fehlerhaft..
Sep 14 2015, 2:19 PM · Multimedia, UploadWizard

Sep 3 2015

MartinK added a comment to T110208: Requests from a specific network are blocked.

Just as a note:
I am running a small wiki for the students attending my lecture on the same shared hosting servers we are talking about here. This Wiki was also affected by the block, since it included instant commons (which may be one of the main use cases for API-access from servers).

Sep 3 2015, 8:41 AM · Operations, netops, Traffic

Jul 16 2015

MartinK added a comment to T105789: A new panoramic viewer for commons.

I just tested it and the button appears and works.

Jul 16 2015, 8:51 PM · Community-Wishlist-Survey-2016, Multimedia, Commons, Wikimania-Hackathon-2015

Jul 15 2015

MartinK added a comment to T105789: A new panoramic viewer for commons.

Since the distortion is the major argument against using pano images in Wikipedia, it would be great if this viewer not only integrates with commons, but with MediaWiki as well. An integration into the MediaViewer or some kind of extension that can be enabled via common.js

Jul 15 2015, 8:47 PM · Community-Wishlist-Survey-2016, Multimedia, Commons, Wikimania-Hackathon-2015

Apr 23 2015

MartinK added a comment to T91811: Share A Fact images should include license or attribution info about the image.

Even if Fair Use is the excuse to ignore the the CC attribution requirements, this feature has to be disabled in all language versions, where Fair Use does not exist (e.g. most of continental Europe).

Apr 23 2015, 2:28 PM · WMF-Legal, WorkType-Maintenance, Wikipedia-Android-App-Backlog