Page MenuHomePhabricator
Create Task
Maniphest T101540

D42. Flow talkpage conversion (LQT->Flow) should not send an email to users with enotifwatchlistpages about the page move or redirect creation
Closed, ResolvedPublic
Actions

Description

As a user with the enotifwatchlistpages preference enabled ("Email me when a page or file on my watchlist is changed"), I receive email for the LQT->Flow pagemove that is part of the conversion process (when user:Flow_talk_page_manager moves the LQT-header/page-history to the /..._archive location. e.g. https://www.mediawiki.org/w/index.php?title=Talk:Collaboration/LQT_Archive_1&diff=prev&oldid=1664326)

We should consider how this will scale, during entire namespace conversions (for both LQT->Flow, and for Wikitext->Flow).
Possibly we could send a clearer email for these specific actions?
Or possibly not send emails for this particular use-case?
Or something else?

Task filed, based on the comments by @Risker in https://www.mediawiki.org/wiki/Topic:Siiavth54u8a0rm8:

Incidentally, what brought me here today was an email message informing me that User:Flow_talk_page_manager had moved a page called Talk:Flow Portal/Archive2 (a page that as far as I knew wasn't on my watchlist), and when I followed the link....there was nothing there. I can't tell what got moved where [...]

I (Quiddity) have now used 2 of my test accounts to watchlist a variety of the pages/threads/posts in the list of "Day 4" LQT conversions, and set the enotifwatchlistpages preference on them, in order to replicate and see additional details.

Screenshot:

Screen Shot 2015-06-11 at 8.46.43 AM.png (552×964 px, 137 KB)

Details

SubjectRepoBranchLines +/-
Suppress notification emails for Flow user actions (including import)mediawiki/extensions/Flowmaster+21 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Quiddity created this task.Jun 5 2015, 6:44 PM
Quiddity raised the priority of this task from to Needs Triage.
Quiddity updated the task description. (Show Details)
Quiddity added projects: StructuredDiscussions, Collaboration-Team-Triage.
Quiddity added subscribers: Quiddity, Risker.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2015, 6:44 PM
• Mattflaschen-WMF mentioned this in T85816: Enable Flow for talkpage for Extension:MobileFrontend on mediawiki.org (convert from LQT).Jun 10 2015, 3:00 AM
• Mattflaschen-WMF renamed this task from Flow talkpage conversion (LQT->Flow) sends an email to users with enotifwatchlistpages for the page-move - investigate concerns for how this scales to Flow talkpage conversion (LQT->Flow) should not send an email to users with enotifwatchlistpages about the page move or redirect creation.Jun 10 2015, 3:03 AM
• Mattflaschen-WMF added a parent task: T92303: Convert LQT pages on MediaWiki.org to Flow (tracking).
• Mattflaschen-WMF set Security to None.
• Elitre subscribed.Jun 10 2015, 7:49 AM
• Mattflaschen-WMF added a project: Collaboration-Team-Sprint-C-2015-06-17.Jun 12 2015, 5:41 PM
• Mattflaschen-WMF subscribed.
• DannyH added a project: Collaboration-Team-Sprint-D-2015-06-30.Jun 16 2015, 6:56 PM
• DannyH renamed this task from Flow talkpage conversion (LQT->Flow) should not send an email to users with enotifwatchlistpages about the page move or redirect creation to D8. Flow talkpage conversion (LQT->Flow) should not send an email to users with enotifwatchlistpages about the page move or redirect creation.Jun 16 2015, 7:24 PM
• Mattflaschen-WMF mentioned this in T98996: LQT conversion sends notifications for every single topic I've participated in, not just Unread ones.Jun 18 2015, 5:18 AM
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF claimed this task.Jun 18 2015, 6:26 AM
• Mattflaschen-WMF moved this task from Sprint D - ends July 1 to In Development on the Collaboration-Team-Sprint-D-2015-06-30 board.
• Mattflaschen-WMF triaged this task as High priority.Jun 18 2015, 6:28 AM
gerritbot subscribed.Jun 18 2015, 6:29 AM

Change 219127 had a related patch set uploaded (by Mattflaschen):
Suppress notification emails for Flow user actions (including import)

https://gerrit.wikimedia.org/r/219127

gerritbot added a project: Patch-For-Review.Jun 18 2015, 6:29 AM
gerritbot added a comment.Jun 18 2015, 5:32 PM

Change 219127 merged by Matthias Mullie:
Suppress notification emails for Flow user actions (including import)

https://gerrit.wikimedia.org/r/219127

matthiasmullie mentioned this in rEFLW2f9fdd7b5786: Suppress notification emails for Flow user actions (including import).Jun 18 2015, 5:33 PM
matthiasmullie mentioned this in rMEXT729c1ca26c0e: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….
• DannyH renamed this task from D8. Flow talkpage conversion (LQT->Flow) should not send an email to users with enotifwatchlistpages about the page move or redirect creation to D42. Flow talkpage conversion (LQT->Flow) should not send an email to users with enotifwatchlistpages about the page move or redirect creation.Jun 18 2015, 5:38 PM
Catrope moved this task from In Development to QA Review on the Collaboration-Team-Sprint-D-2015-06-30 board.Jun 18 2015, 5:39 PM
Etonkovidova subscribed.Jun 19 2015, 5:01 PM

Checked on http://test.wikimedia.beta.wmflabs.org/wiki/

a user with the enotifwatchlistpages preference enabled ("Email me when a page or file on my watchlist is changed"), I receive email for the LQT->Flow pagemove

Now, a user does not receive any notification about LQT->Flow page move.

However, after a page has been converted to Flow all email notifications stop. The user notifications(in the upper menu) are fine.

• DannyH moved this task from QA Review to In Development on the Collaboration-Team-Sprint-D-2015-06-30 board.Jun 22 2015, 5:15 PM
• DannyH subscribed.

Moving this back to In Dev.

Elena found a problem in QA -- threads that are converted from LQT to Flow are not sending emails at all after the conversion.

Jdforrester-WMF added a project: WMF-deploy-2015-06-23_(1.26wmf11).Jun 22 2015, 9:07 PM
Etonkovidova added a comment.Jun 22 2015, 10:23 PM

Re-cheked: in order to receive proper Email notification after LQT->Flow conversion, Flow Email notification option should be enabled(not enabled by default).

"Email me when a page or file on my watchlist is changed" - on User profile preferences does not affect options on Notifications tab.

Etonkovidova moved this task from In Development to Product Review on the Collaboration-Team-Sprint-D-2015-06-30 board.Jun 22 2015, 10:24 PM
• DannyH closed this task as Resolved.Jun 22 2015, 11:18 PM
• DannyH moved this task from Product Review to Done on the Collaboration-Team-Sprint-D-2015-06-30 board.
• Mattflaschen-WMF added a comment.Jun 24 2015, 2:12 AM

See T101350: Conflict between user preferences for emails and user preferences for notifications via email, about the issue above (which is a UX issue, though not specific to imports).

• DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Jun 30 2015, 7:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL