Cannot handle multiple HTMLForms in single SpecialPage
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	01tonythomas
	Jun 11 2015, 1:26 PM

Description

[ originally posted in http://www.gossamer-threads.com/lists/wiki/wikitech/454703 ]

Creating two HTMLForms in single Special page with code:

public function execute($par) {
		$this->setHeaders();
                $array1 = $this->getAnnounceFormFields();
		$array2 = $this->getCreateFormFields();

	        $htmlFormNewIssue = new HTMLForm(  $array1, $this->getContext() );
		$htmlFormNewIssue->setSubmitText( 'Create a new Issue' );
		$htmlFormNewIssue->setSubmitCallback( array( 'SpecialNewsLetterPublishers', 'onSubmitNewIssue') );
		$htmlFormNewIssue->show();


		$htmlFormNewNewsLetter = new HTMLForm( $array2, $this->getContext()  );
		$htmlFormNewNewsLetter->setSubmitText( 'Create a new Newsletter');
		$htmlFormNewNewsLetter->setSubmitCallback( array( 'SpecialNewsLetterPublishers', 'onSubmitNewsLetter') );
		$htmlFormNewNewsLetter->show();
}

Shows up the multiple forms, but clicking 'Submit' on one form submits both 'Forms'. ie it is not possible to submit only one form. The complete code is over here : https://phabricator.wikimedia.org/P770

Details

	Subject	Repo	Branch	Lines +/-
	HTMLForm: Allow distinguishing between form views and submission attempts	mediawiki/core	master	+76 -39

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
Open	None	T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
Open	None	T100161 Convert all of MediaWiki core to OOUI PHP (tracking)
Open	None	T107037 Convert all MW core special pages to OOUI
Resolved	Esanders	T108792 Convert Special:Import to OOUI
Resolved	matmarex	T102114 Cannot handle multiple HTMLForms in single SpecialPage

Event Timeline

01tonythomas created this task.Jun 11 2015, 1:26 PM

01tonythomas raised the priority of this task from to Needs Triage.

01tonythomas updated the task description. (Show Details)

01tonythomas added a project: MediaWiki-HTMLForm.

01tonythomas subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2015, 1:26 PM

01tonythomas updated the task description. (Show Details)Jun 11 2015, 1:28 PM

01tonythomas set Security to None.

01tonythomas updated the task description. (Show Details)

01tonythomas added a parent task: T100125: Implement 'Create a newsletter' feature for Newsletter extension.

01tonythomas added subscribers: matmarex, • Prtksxna, Tinaj1234 and 3 others.

Qgil mentioned this in T100125: Implement 'Create a newsletter' feature for Newsletter extension.Jun 18 2015, 7:05 AM

01tonythomas removed a parent task: T100125: Implement 'Create a newsletter' feature for Newsletter extension.Jun 18 2015, 7:10 AM

Any update on this ?

01tonythomas mentioned this in T103813: Overview of newsletters with subscribe/unsubscribe options.Jun 25 2015, 2:55 PM

TTO mentioned this in T108792: Convert Special:Import to OOUI.Aug 12 2015, 7:21 AM

Something like this might work?

if ( $this->getRequest()->wasPosted() ) {
	$action = $this->getRequest()->getVal( 'action' );
	switch ( $action ) {
		case 'form1':
			$form = $this->getForm1();
			break;
		case 'form2':
			$from = $this->getForm2();
			break;
		default:
			throw new Exception(...);
	}
	$form->show(); // Handle submission, etc.
} else {
	// hidden action=form1 field
	$this->getForm1()->displayForm();
	// hidden action=form2 field
	$this->getForm2()->displayForm();
}

Legoktm added a parent task: T108792: Convert Special:Import to OOUI.Aug 12 2015, 7:34 AM

TTO subscribed.Aug 13 2015, 9:25 AM

Glaisher subscribed.Aug 26 2015, 12:09 PM

Jdlrobson added a project: Front-end-Standards-Group.May 11 2016, 6:22 PM

Jdlrobson moved this task from Inbox to Blocked on the Front-end-Standards-Group board.May 11 2016, 6:26 PM

Jdforrester-WMF triaged this task as Medium priority.May 11 2016, 6:37 PM

Jdforrester-WMF moved this task from Blocked to Accepted on the Front-end-Standards-Group board.

matmarex claimed this task.May 25 2016, 1:40 PM

Change 291837 had a related patch set uploaded (by Bartosz Dziewoński):
HTMLForm: Allow distinguishing between form views and submission attempts

https://gerrit.wikimedia.org/r/291837

gerritbot added a project: Patch-For-Review.May 30 2016, 10:13 PM

matmarex moved this task from Accepted to Needs code review on the Front-end-Standards-Group board.Jun 8 2016, 6:36 PM

matmarex lowered the priority of this task from Medium to Low.Jul 18 2016, 7:03 PM

Change 291837 merged by jenkins-bot:
HTMLForm: Allow distinguishing between form views and submission attempts

https://gerrit.wikimedia.org/r/291837

It will now work as expected for forms that have an identifier set (call $form->setFormIdentifier( 'foo' ) when setting up the form). The identifier must be different for every form on the page.

Cannot handle multiple HTMLForms in single SpecialPage Closed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Cannot handle multiple HTMLForms in single SpecialPage
Closed, ResolvedPublic
Actions

Related Objects
Search...