Add 'url' module for native URL constructor (with conditionally loaded polyfill)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	Jun 22 2015, 4:44 PM

Description

https://developer.mozilla.org/en-US/docs/Web/API/URL/URL
https://url.spec.whatwg.org/
https://github.com/whatwg/url

Natively available in Firefox 26+, Chrome, Safari, Opera. Not in any version of IE yet.

Spec is still relatively new, but use of it (with conditional polyfill) may simplify our code base, speed up execution, and get us more in line with standardised interfaces and parsing algorithms. Right now we have a custom regex that works for most URLs but does have its shortcomings.

Details

	Subject	Repo	Branch	Lines +/-
	web2017-polyfills: Update URL polyfill to latest version with our fixes	mediawiki/core	master	+67 -6
	web2017-polyfills: Add WHATWG URL polyfill	mediawiki/core	master	+725 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Duplicate	None	T108565 Shortening only a domain without a trailing slash fails
Declined	None	T66884 mediawiki.Uri does not support IPv6 URIs
Resolved	Jdlrobson	T106244 URL encoded values using fallback 8-bit encoding (invalid UTF-8) cause mediawiki.Uri to crash
Declined	None	T207365 URL with % in fragment breaks scripts that use mw.Uri
Resolved	Krinkle	T103379 Add 'url' module for native URL constructor (with conditionally loaded polyfill)

Event Timeline

Krinkle created this task.Jun 22 2015, 4:44 PM

Krinkle raised the priority of this task from to Needs Triage.

Krinkle updated the task description. (Show Details)

Krinkle added projects: MediaWiki-General, JavaScript.

Krinkle subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2015, 4:44 PM

Krinkle added a project: Performance Issue.Jun 22 2015, 4:44 PM

Krinkle set Security to None.

Ricordisamoa awarded a token.Sep 23 2015, 10:08 PM

Ricordisamoa subscribed.

Krinkle removed a project: Performance Issue.Sep 24 2015, 12:19 AM

Krinkle renamed this task from Evaluate using the native "URL" constructor to Add 'url' module for native URL constructor (with conditionally loaded polyfill).Apr 2 2019, 3:34 AM

Krinkle merged a task: T117651: Align mediawiki.Uri more with the native URL constructor.

Krinkle added a subscriber: StudiesWorld.

Krinkle added a parent task: T108565: Shortening only a domain without a trailing slash fails.Apr 2 2019, 3:37 AM

Krinkle merged a task: T68617: mw.Uri should support URLs like http://wikimedia.org without trailing slash.

Krinkle added a parent task: T66884: mediawiki.Uri does not support IPv6 URIs.

Krinkle added a parent task: T106244: URL encoded values using fallback 8-bit encoding (invalid UTF-8) cause mediawiki.Uri to crash.

Krinkle added subscribers: yuvipanda, gerritbot, matmarex and 2 others.

Krinkle mentioned this in T106244: URL encoded values using fallback 8-bit encoding (invalid UTF-8) cause mediawiki.Uri to crash.Jun 6 2019, 8:52 AM

• Nikerabbit subscribed.Jun 6 2019, 9:53 AM

Tarrow awarded a token.Jul 18 2019, 1:04 PM

Krinkle added a project: Performance-Team.Jul 18 2019, 2:31 PM

Krinkle moved this task from Inbox, needs triage to To-do: Goals, prioritized next 4 Quarters on the Performance-Team board.

Tarrow mentioned this in T228407: Double query string parameters in EntityData request.Jul 18 2019, 4:03 PM

Krinkle added a project: patch-welcome.Oct 11 2019, 12:47 AM

Krinkle mentioned this in T287935: mw.Uri does not roundtrip fragment characters.Aug 3 2021, 4:29 PM

Krinkle added a parent task: T207365: URL with % in fragment breaks scripts that use mw.Uri.Nov 28 2021, 12:27 AM

• G1964j subscribed.Feb 4 2022, 3:53 AM

Krinkle claimed this task.Feb 4 2022, 6:38 PM

Krinkle triaged this task as Medium priority.

Krinkle added a project: Developer Productivity.

Krinkle mentioned this in T300912: Add a polyfill for IntersectionObserver to ResourceLoader.Feb 9 2022, 5:01 AM

egardner mentioned this in T301489: Create a "web 2017" polyfill RL module.Feb 10 2022, 5:05 PM

Change 763279 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] web2017-polyfills: Add WHATWG URL polyfill

https://gerrit.wikimedia.org/r/763279

gerritbot added a project: Patch-For-Review.Feb 16 2022, 5:07 PM

Krinkle mentioned this in T66884: mediawiki.Uri does not support IPv6 URIs.Feb 16 2022, 5:29 PM

Krinkle mentioned this in T301356: URL Shortener showed "Not a valid URL" with metawiki link that contains "#1%".

Krinkle edited projects, added MediaWiki-ResourceLoader; removed patch-welcome, MediaWiki-General.Feb 16 2022, 5:35 PM

Krinkle moved this task from Inbox to Accepted Enhancement on the MediaWiki-ResourceLoader board.

Seb35 subscribed.Feb 20 2022, 12:18 PM

Change 763279 merged by jenkins-bot:

[mediawiki/core@master] web2017-polyfills: Add WHATWG URL polyfill

https://gerrit.wikimedia.org/r/763279

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.25; 2022-03-07).Mar 2 2022, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Mar 2 2022, 12:10 AM

Krinkle closed this task as Resolved.Mar 2 2022, 5:22 PM

Krinkle removed a project: MW-1.38-notes (1.38.0-wmf.25; 2022-03-07).

In T106244#7753476, @matmarex wrote:

By the way, replacing mw.Uri with the URL polyfill from T103379 does not fix the issue – I tested on IE 11, and the polyfill also throws an exception.

In T106244#7753871, @Krinkle wrote:

Reproduced and reported upstream:

https://codepen.io/Krinkle/pen/gOXqZNK
https://github.com/Financial-Times/polyfill-library/issues/4

I'm working on a fix, re-opening to track the work here.

Change 771445 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] URL: Update 'url' polyfill to latest version containing our fixes

https://gerrit.wikimedia.org/r/771445

gerritbot added a project: Patch-For-Review.Mar 16 2022, 8:10 PM

Change 771445 merged by jenkins-bot:

[mediawiki/core@master] web2017-polyfills: Update URL polyfill to latest version with our fixes

https://gerrit.wikimedia.org/r/771445

Maintenance_bot removed a project: Patch-For-Review.Mar 27 2022, 9:10 PM

Krinkle closed this task as Resolved.Mar 27 2022, 10:21 PM

Krinkle mentioned this in T207365: URL with % in fragment breaks scripts that use mw.Uri.Mar 27 2022, 10:28 PM

Krinkle mentioned this in T268064: VisualEditor onEditSectionLinkClick should catch Uri exceptions.Sep 9 2022, 11:36 PM