Since T73200: Support redirects in JavaScriptContent was fixed, when I move a JS page and allow MW to create a redirect, it is created with a code such as
/* #REDIRECT */mw.loader.load("//pt.wikipedia.org/w/index.php?title=Usu%C3%A1rio(a):He7d3r/common.js\u0026action=raw\u0026ctype=text/javascript");
However, this usage of \u0026 makes it hard to copy the URL directly from the code, because we have to replace all \u0026 by & before pasting it somewhere.
This is automatically done by Xml::encodeJsCall -> Xml::encodeJsVar -> FormatJson::encode( ..., ..., FormatJson::UTF8_OK ). I don't know if there is a specific reason for it...
Xml::escapeJsString() has encoded ampersands since 1.8 (rSVN15871 / rMW584c456a942fc8ae). Presumably, the reason is that within script elements in XHTML documents, ampersands must be encoded unless inside a CDATA section.
When I made Xml::encodeJsVar() instead use FormatJson::encode(), I grepped extensions and found a few that did not use Html::inlineScript(), so I decided to have FormatJson encode ampersands, as Xml::escapeJsString() had already done.
Change 267174 had a related patch set uploaded (by IoannisKydonis):
Use "&" instead of "\u0026".
Change 267174 abandoned by Thiemo Kreuz (WMDE):
Use "&" instead of "\u0026".
Reason:
This patch is incomplete and does not even touch the one line of code that creates these encoded ampersands, as explained by Krinkle in the last comment. Better start over, as a 2 years old incomplete draft won't help fixing the issue.
@IoannisKydonis are you still planning to work on this? At JavaScriptContentHandler::makeRedirectContent, using $url = str_replace( "\u0026", "&", $url ); should do the trick
Tagging CPT as likely steward for the content handler. This is a low-priority enhancement to improve usability of wiki pages that are JS redirects. Probably won't reach the surface of any backlog, but tagging for visibility and tracking in case a volunteer has questions about the code and (later) for code review.
Change 566120 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Do not encode & in JS redirect content
Change 566120 abandoned by Ammarpad:
[mediawiki/core@master] Do not encode & in JS redirect content
Reason:
Change 837202 had a related patch set uploaded (by Legoktm; author: Legoktm):
[mediawiki/core@master] Do not encode `&` in JavaScript redirect content
Taking on as closely related to ResourceLoader and benefiting general usability of JavaScript content editing on-wiki.
Change 970467 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/core@master] content: Improve roundtrip tests for JavaScriptContent
Change 837202 merged by jenkins-bot:
[mediawiki/core@master] content: Stop encoding `&` in JavaScript redirect content