There is a way to specify a privacyPolicy param for external surveys, but no such option for internal surveys.
Internal surveys still have a footer, and still need a privacy policy link. As of now, it falls back to the default message originally set for external surveys, and it is not gracefully customizable.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | mpopov | T113240 Analyze qualitative user satisfaction data for search on-wiki | |||
| Declined | JGirault | T118800 QuickSurveys: Add survey on article page when coming from a wiki search | |||
| Resolved | JGirault | T119033 QuickSurveys: Add privacy link | |||
| Resolved | debt | T130755 [EPIC] Portal Production release: bug fixes and small updates | |||
| Resolved | debt | T119149 QuickSurveys: Allow internal surveys to provide a custom privacy policy |
Change 254328 had a related patch set uploaded (by JGirault):
Make privacy policy an optional parameter for internal and external surveys.
@ksmith As far as I remember, there was an action item to talk with Legal again, to figure out if a specific privacy policy must be displayed on internal surveys, and if that privacy policy is specific to our quick survey, or is required for any internal quick survey that will be run on wiki projects.
I don't remember who was assigned to this action item (I just remember it wasn't myself), but I believe this discussion should happen between Legal and QuickSurveys teams. We, as the
Nonetheless, I can rebase my patch (and will).
Thanks Julien.
@debt @Deskana @dr0ptp4kt: Can one of you move this forward (or propose a plan for me to do so)? (I sent a ping on IRC but am following up here as well).
@JGirault, just chatted with @debt. Say, could you update the patch to add support for a customizable privacy policy URL for "internal" (i.e., not 3rd party) surveys?
Our next sprint, sprint 70, starts 11-April-2016, so was wondering if this was something we could expect in the Reading Web code review queue during the sprint.
Change 282143 had a related patch set uploaded (by JGirault):
Make privacy policy an optional parameter for internal survey.
Change 282143 abandoned by JGirault:
Make privacy policy an optional parameter for internal survey.
Reason:
Abandoned in favor of https://gerrit.wikimedia.org/r/#/c/254328
(wrong branch: master)
Just a comment/confirmation - I've been chatting with Aeryn in Legal and she confirmed that we do need a privacy policy for all surveys (internal and external) and that they should be customizable and not be "default" wording.
Aeryn also let me know that Legal is working on streamlining their processes to make it easier for any team to submit a request for a review or proper wording for a privacy policy message for any upcoming survey.
Hi @JGirault - can the patch be fixed? It looks like gerrit didn't like it: https://gerrit.wikimedia.org/r/#/c/254328
Change 282143 restored by Phuedx:
Make privacy policy an optional parameter for internal survey.
Reason:
The default branch is indeed master.
@debt, @JGirault: I think that 254328: Make privacy policy an optional parameter for internal and external surveys. isn't building as it's based on the outdated dev branch. I've taken the liberty of restoring and updating 282143.
Thanks, @phuedx, looks like we just need a code review now - @dr0ptp4kt do you think your team can help with that?
I've reviewed and tested 254328: Make privacy policy an optional parameter for internal and external surveys. and it LGTM. However, I updated the commit message as privacyPolicy is a required property for external surveys. If @JGirault could sign off on that, albeit cosmetic, tweak then I'll C+2.
Change 254328 abandoned by JGirault:
Make privacy policy an optional parameter for internal and external surveys.
Reason:
Now it's this one who gets abandoned in favor of https://gerrit.wikimedia.org/r/#/c/282143
@phuedx , @jhobs , no problem with the new commit message, makes sense.
We should now be good to merge https://gerrit.wikimedia.org/r/#/c/282143/ :)
I abandoned the other patch that was against dev branch.
@debt over to you to sign off. This should be testable on http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings from midday PST time but you may need @JGirault to help assure you all is good.
Hi @Jdlrobson @JGirault - I had looked earlier and it seemed like the survey was there with the privacy policy link, but now it's gone from http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings ...did something get changed?
Cool - it's working now :) Can we add this to the production ticket to go out (hopefully) later this week?
I moved this to Done on Reading-Web-Sprint-70-Lady-and-the-Trumps as the associated change has been merged.