Page MenuHomePhabricator
Create Task
Maniphest T125333

Don't show Default, Example and Auto value section of the TemplateData description cell if no information is provided
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The rows of the TemplateData table in the documentation page take a lot of space even if the Default, Example and Auto value parameters are empty. This makes the documentation pages with lot of parameters unnecessarily long providing a lot of no relevant visual clutter and a huge vertical scroll. This can be seen for example in the Cite web template of the English Wikipedia, where most of the length of the page is irrelevant information such as:

Default
empty
Example
empty
Auto value
empty

It would be great to make these sections only visible in the documentation page when they are no empty.

Details

SubjectRepoBranchLines +/-
Remove empty Default, Example and Auto value sections of the output tablemediawiki/extensions/TemplateDatamaster+13 -37
Customize query in gerrit

Related Objects

Event Timeline

Agabi10 created this task.Jan 31 2016, 12:35 PM
Agabi10 raised the priority of this task from to Needs Triage.
Agabi10 updated the task description. (Show Details)
Agabi10 added a project: TemplateData.
Agabi10 subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 31 2016, 12:35 PM
Krenair subscribed.Jan 31 2016, 5:58 PM

So you suggest that if all parameters have no default, then the default: empty is not shown for any parameters, and the same for example and autovalue?

Krenair added a comment.Jan 31 2016, 5:58 PM

I was considering something similar for https://gerrit.wikimedia.org/r/#/c/263655/

Agabi10 added a comment.Jan 31 2016, 9:42 PM

More or less. What I suggest is to make the default: empty and the others not visible for the values which have it undefined. If one parameter have a default value and the others no the one with the default parameter should be the only one specifying a default.

Jdforrester-WMF added a project: VisualEditor.Feb 23 2016, 11:30 PM
Jdforrester-WMF renamed this task from Remove Default, Example and Auto value section of the TemplateData description cell if no information is provided to Don't show Default, Example and Auto value section of the TemplateData description cell if no information is provided.Apr 19 2016, 7:24 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF set Security to None.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 7:24 PM
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Apr 19 2016, 7:24 PM
PerfektesChaos mentioned this in T160254: Do not display unused settings parameters (default/example/auto value) in TemplateData display table.Mar 26 2017, 5:19 PM
Iniquity merged a task: T160254: Do not display unused settings parameters (default/example/auto value) in TemplateData display table.Apr 10 2017, 9:56 PM
Iniquity merged a task: T137443: Don't display default value and auto value in the TemplateData block when they're empty.
Iniquity added subscribers: MarcoAurelio, PerfektesChaos.
Iniquity added subscribers: • Whatamidoing-WMF, • AlexMonk-WMF, Zppix.
Iniquity added projects: Design, Web-Team-Backlog.Apr 10 2017, 9:58 PM
Jdlrobson moved this task from Incoming to 2014-15 Q4 on the Web-Team-Backlog board.Apr 10 2017, 10:32 PM
Jdlrobson removed a project: Web-Team-Backlog.Jun 15 2017, 9:27 PM
Agabi10 claimed this task.Sep 1 2018, 11:34 PM
gerritbot subscribed.Sep 2 2018, 12:36 AM

Change 457072 had a related patch set uploaded (by Agabi10; owner: Agabi10):
[mediawiki/extensions/TemplateData@master] Remove empty Default, Example and Auto value sections of the output table

https://gerrit.wikimedia.org/r/457072

gerritbot added a project: Patch-For-Review.Sep 2 2018, 12:36 AM
Agabi10 mentioned this in T176956: Add a class to empty TemplateData fields titles (dt).Sep 2 2018, 12:58 AM
Krinkle merged a task: T176956: Add a class to empty TemplateData fields titles (dt).Sep 2 2018, 12:59 AM
Krinkle updated the task description. (Show Details)
Krinkle awarded a token.
Krinkle added subscribers: The_RedBurn, Krinkle, Kizule and 2 others.
The_RedBurn awarded a token.Sep 5 2018, 11:29 AM
The_RedBurn updated the task description. (Show Details)Sep 6 2018, 5:57 AM
gerritbot added a comment.Sep 28 2018, 4:08 PM

Change 457072 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Remove empty Default, Example and Auto value sections of the output table

https://gerrit.wikimedia.org/r/457072

matmarex closed this task as Resolved.Sep 28 2018, 4:10 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 28 2018, 4:10 PM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)).Sep 28 2018, 5:00 PM
matmarex subscribed.Sep 28 2018, 5:49 PM

It's crazy how much better the TemplateData tables look without these. @Agabi10 Thank you for working on this!

The_RedBurn added a subscriber: Jdforrester-WMF.Sep 29 2018, 7:38 AM

Indeed, thanks @Agabi10 for the patch and @Jdforrester-WMF and @matmarex for the review!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL