Page MenuHomePhabricator
Create Task
Maniphest T125373

Language fallback for Lzh (Zh-classical) should be Zh_hant
Closed, ResolvedPublic
Actions

Description

Please set messages for Lzh fall back to Zh_hant instead of English.

Discussion: https://zh-classical.wikipedia.org/wiki/Wikipedia:%E6%9C%83%E9%A4%A8#.E7.B3.BB.E7.B5.B1.E6.B6.88.E6.81.AF.E5.9B.9E.E8.90.BD

See also: T126944: Wikibase LanguageFallbackChainFactoryTest makes assumptions on MediaWiki's language fallback chains

Details

SubjectRepoBranchLines +/-
Set fallback language for lzh to zh-hantmediawiki/coremaster+2 -0
Setting fallback to zh-hans for lzhmediawiki/coremaster+88 -86
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lantern created this task.Feb 1 2016, 8:07 AM
Lantern raised the priority of this task from to Medium.
Lantern updated the task description. (Show Details)
Lantern added projects: I18n, MediaWiki-Internationalization.
Lantern added a subscriber: liangent.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2016, 8:07 AM
Aklapper renamed this task from Lzh (Zh-classical) should fall back to Zh_hant to Language fallback for Lzh (Zh-classical) should be Zh_hant.Feb 1 2016, 8:46 AM
Aklapper lowered the priority of this task from Medium to Low.
Aklapper set Security to None.
MarcoAurelio claimed this task.Feb 1 2016, 11:44 AM
MarcoAurelio added a project: Community-consensus-needed.

As far as I can see, there's no real discussion there, or am I mistaken?

Lantern subscribed.EditedFeb 2 2016, 3:36 AM

You are right. This wiki has few people, and many messages are left untranslated, which makes viewers confused.

In 2014 there was a same proposal, but they obviously didn't know how to report the bug.

MarcoAurelio added subscribers: siebrand, Nikerabbit.Feb 2 2016, 6:58 PM

Well, it looks like a reasonable request to me after all, that a Chinese wiki fallback missing messages to another Chinese dialect, so I'm taking this. Just a question, do you want fallback for zh or zh-hans, zh-hant, etc. Sorry for my ignorance, but I get lost with the so many ways to speak Chinese. I'd say that we should also fallback to a language that has all or the vast majority of messages translated too. Ping to @siebrand and @Nikerabbit for their opinions.

Lantern added a comment.EditedFeb 3 2016, 2:50 AM

Comparing file sizes in mediawiki/languages/i18n/, zh-hans and zh-hant have most messages. zh is an empty shell combined by them, and others like zh-hk zh-sg zh-tw are regional words.
Both lzh and zh-hant use traditional Chinese characters, so zh-hant only seems enough.

Liuxinyu970226 subscribed.Feb 3 2016, 5:11 AM

BTW, should we do samething for Cantonese (yue)? (If someone says OK then please let him to create another task).

gerritbot subscribed.Feb 3 2016, 6:54 PM

Change 268189 had a related patch set uploaded (by MarcoAurelio):
Setting fallback to zh-hans for lzh

https://gerrit.wikimedia.org/r/268189

gerritbot added a project: Patch-For-Review.Feb 3 2016, 6:54 PM
MarcoAurelio removed a project: Community-consensus-needed.Feb 6 2016, 11:15 PM
hashar mentioned this in T126944: Wikibase LanguageFallbackChainFactoryTest makes assumptions on MediaWiki's language fallback chains.Feb 16 2016, 8:49 AM
gerritbot added a comment.Feb 22 2016, 5:12 PM

Change 268189 abandoned by MarcoAurelio:
Setting fallback to zh-hans for lzh

Reason:
Re-doing from the start.

https://gerrit.wikimedia.org/r/268189

gerritbot added a comment.Feb 22 2016, 5:17 PM

Change 272499 had a related patch set uploaded (by MarcoAurelio):
Setting fallback configuration for lzh to zh-hant

https://gerrit.wikimedia.org/r/272499

MarcoAurelio updated the task description. (Show Details)Feb 24 2016, 4:04 PM
MarcoAurelio subscribed.
MarcoAurelio removed MarcoAurelio as the assignee of this task.Feb 29 2016, 5:24 PM

Since I can't resolve this task myself as it depends on some Wikibase stuff that is not being resolved.

gerritbot added a comment.Apr 9 2016, 10:09 AM

Change 272499 abandoned by MarcoAurelio:
Set fallback for lzh to zh-hant

Reason:
It seems there's no interest in getting the test error fixed anytime soon, thus preventing this patch to me merged, wich now even needs manual rebase.

https://gerrit.wikimedia.org/r/272499

MarcoAurelio removed a project: Patch-For-Review.Apr 9 2016, 10:09 AM
gerritbot added a comment.Apr 11 2016, 1:56 PM

Change 272499 restored by MarcoAurelio:
Set fallback for lzh to zh-hant

Reason:
Per T126944#2194839

https://gerrit.wikimedia.org/r/272499

MarcoAurelio closed this task as Resolved by committing rMWb31aa179bd3d: Setting fallback to zh-hans for lzh.Apr 28 2016, 3:01 AM
MarcoAurelio added a commit: rMWb31aa179bd3d: Setting fallback to zh-hans for lzh.
MarcoAurelio added a commit: rMWbe077c2ccfae: Setting fallback to zh-hans for lzh.
MarcoAurelio added a commit: rMW431a87347e96: Setting fallback to zh-hans for lzh.
MarcoAurelio added a commit: rMW8257e824a95a: Setting fallback to zh-hans for lzh.
MarcoAurelio added a commit: rMWbe7231b3d3b7: Setting fallback to zh-hans for lzh.
Aklapper reopened this task as Open.Apr 28 2016, 3:03 PM
Liuxinyu970226 added a subscriber: shinjiman.Jul 4 2016, 3:10 AM
Nikerabbit moved this task from Backlog to Language changes on the MediaWiki-Internationalization board.Jul 14 2016, 7:45 AM
MarcoAurelio changed the task status from Open to Stalled.Jul 21 2016, 9:28 AM

We can't move until T126944 it seems, otherwise my patch will continue to fail. Although I'm exploring @siebrand option of adding a fake "depends on" commit message to get this unlocked. I'm not well versed at that so I hope you understand my reticence to that.

Liuxinyu970226 awarded a token.Aug 2 2016, 11:25 PM
MarcoAurelio changed the task status from Stalled to Open.Aug 24 2016, 3:05 PM
MarcoAurelio claimed this task.

It seems that the Wikibase issues are now fixed and the patch is passing jenkins-tests, so maybe we can merge the mediawiki/core patch now and get this resolved?

hoo closed subtask T126944: Wikibase LanguageFallbackChainFactoryTest makes assumptions on MediaWiki's language fallback chains as Resolved.Aug 24 2016, 3:43 PM
MarcoAurelio added a project: Patch-For-Review.Sep 15 2016, 11:41 AM
MarcoAurelio removed commits: rMWbe7231b3d3b7: Setting fallback to zh-hans for lzh, rMW8257e824a95a: Setting fallback to zh-hans for lzh, rMWbe077c2ccfae: Setting fallback to zh-hans for lzh, rMW431a87347e96: Setting fallback to zh-hans for lzh, rMWb31aa179bd3d: Setting fallback to zh-hans for lzh.
gerritbot added a comment.Sep 15 2016, 1:02 PM

Change 272499 merged by jenkins-bot:
Set fallback language for lzh to zh-hant

https://gerrit.wikimedia.org/r/272499

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-09-20_(1.28.0-wmf.20)).Sep 15 2016, 2:00 PM
MarcoAurelio closed this task as Resolved.Sep 17 2016, 10:05 AM

Patch is merged. I'll be live on the wiki on the next mediawiki train.

MarcoAurelio removed a project: Patch-For-Review.Sep 17 2016, 10:06 AM
Liuxinyu970226 unsubscribed.Sep 17 2016, 10:42 AM
LNDDYL subscribed.Jan 6 2018, 12:01 PM
Restricted Application added a project: User-MarcoAurelio. · View Herald TranscriptJan 6 2018, 12:01 PM
MarcoAurelio moved this task from unsorted/backlog to cabinet on the User-MarcoAurelio board.Jan 6 2018, 12:06 PM
Winston_Sung subscribed.EditedJan 15 2022, 11:01 AM

BTW, should we do samething for Cantonese (yue)? (If someone says OK then please let him to create another task).

Will be covered by T296188 .

Winston_Sung added a parent task: T296188: Clean up, merge, update zh/zh-* translations and update zh-related language fallback chains in mediawiki/core.Jan 15 2022, 11:02 AM

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/703560/65

Winston_Sung reopened subtask T126944: Wikibase LanguageFallbackChainFactoryTest makes assumptions on MediaWiki's language fallback chains as In Progress.Jan 15 2022, 12:05 PM
Winston_Sung closed subtask T126944: Wikibase LanguageFallbackChainFactoryTest makes assumptions on MediaWiki's language fallback chains as Resolved.Jan 18 2022, 7:19 AM
Winston_Sung added a comment.Jun 2 2022, 4:50 AM

BTW, should we do samething for Cantonese (yue)? (If someone says OK then please let him to create another task).

Done within:

[mediawiki/core@master] Rearrange zh-related language fallback chain

https://gerrit.wikimedia.org/r/703560

Winston_Sung mentioned this in T296188: Clean up, merge, update zh/zh-* translations and update zh-related language fallback chains in mediawiki/core.Jun 15 2022, 5:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL