Page MenuHomePhabricator

Separate AQS off of RESTBase
Closed, ResolvedPublic5 Estimated Story Points

Description

We have moved the framework part of RESTBase into a separate package called HyperSwitch (as per T118404: RFC: Move RESTBase framework functionality to a new package (swagger-service?)). That means that now AQS can have its own source repository and Puppet module, so that its development and deployment can be completely independent of RESTBase.

TODO

  • Repository separation
    • Create a new source repo based on RESTBase's (preserve history)
    • Clean it up of redundant and irrelevant code
    • Clean up RESTBase repository from AQS code and configs
    • Change the AQS deploy repo to point to the new source repo
  • Create a new Puppet module for AQS
  • Deploy the new repo and config to the nodes, replacing the current installation present in /srv/deployment/restbase

Event Timeline

mobrovac raised the priority of this task from to High.
mobrovac updated the task description. (Show Details)

Change 269477 had a related patch set uploaded (by Ppchelko):
Removed RESTBase-specific code from AQS repository.

https://gerrit.wikimedia.org/r/269477

Status: @Milimetric created a new source repository directly in Gerrit - analytics/query-service and @Pchelolo imported the history and clean up the code.

Change 269477 merged by Mobrovac:
Removed RESTBase-specific code from AQS repository.

https://gerrit.wikimedia.org/r/269477

Change 271687 had a related patch set uploaded (by Mobrovac):
AQS: Separate AQS off of RESTBase

https://gerrit.wikimedia.org/r/271687

Preliminary plan for scap deployment of AQS:

  1. figure out proper scap.cfg placement in aqs/deploy
  2. make sure aqs/deploy repo exists and is all good
  3. get /srv/deployment/aqs/deploy on tin (via trebuchet stuff?)
  4. disable puppet on aqs100*
  5. depool aqs1001
  6. merge https://gerrit.wikimedia.org/r/#/c/271687, run puppet on tin and aqs1001
  7. make sure scap deploy works and /srv/deployment/aqs/deploy exists on aqs1001
  8. stop restbase, remove systemd and config files on aqs1001
  9. start aqs, check that things are cool
  10. repool aqs1001
  11. repeat 5-9 for other aqs nodes
mobrovac updated the task description. (Show Details)

The AQS deploy repo is ready for deployment. It needs the scap directory and config file in order for it to be deployed via Scap3, though.

Change 271796 had a related patch set uploaded (by Ottomata):
Add scap config

https://gerrit.wikimedia.org/r/271796

Ok, we are good to go on this. Dan and I moved repos to analytics/aqs and analytics/aqs/deploy. scap.cfg has been added to analytics/aqs/deploy. We're going to wait til Monday to continue.

Change 271687 merged by Ottomata:
AQS: Separate AQS off of RESTBase

https://gerrit.wikimedia.org/r/271687

Change 272516 had a related patch set uploaded (by Ottomata):
Use aqs-admins group for AQS deployment via deploy-service user

https://gerrit.wikimedia.org/r/272516

Change 272516 merged by Ottomata:
Use aqs-admins group for AQS deployment via deploy-service user

https://gerrit.wikimedia.org/r/272516

Change 272518 had a related patch set uploaded (by Ottomata):
Add otto to aqs-admins

https://gerrit.wikimedia.org/r/272518

Change 272518 merged by Ottomata:
Add otto to aqs-admins

https://gerrit.wikimedia.org/r/272518

FYI Step 8. is

sudo rm -rf /etc/restbase/
sudo rm -rf /var/log/restbase/
sudo rm -f /lib/systemd/system/restbase.service
sudo update-rc.d -f restbase remove
Milimetric set the point value for this task to 5.Mar 3 2016, 5:12 PM